From: Icenowy Zheng <icenowy@aosc.io>
To: Antony Antony <antony@phenome.org>, Code Kipper <codekipper@gmail.com>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>,
Chen-Yu Tsai <wens@csie.org>,
linux-sunxi <linux-sunxi@googlegroups.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
devicetree <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] arm64: allwinner: h5: add support for NanoPi NEO Plus 2
Date: Mon, 28 Aug 2017 20:18:58 +0800 [thread overview]
Message-ID: <BF2F26DC-7014-4AF6-9C02-D1038A0FDA38@aosc.io> (raw)
In-Reply-To: <20170828121644.p7mknytubsajzctg@AntonyAntony.local>
于 2017年8月28日 GMT+08:00 下午8:16:44, Antony Antony <antony@phenome.org> 写到:
>On Fri, Aug 25, 2017 at 03:28:41PM +0200, Code Kipper wrote:
>> On 25 August 2017 at 12:32, Antony Antony <antony@phenome.org> wrote:
>
>> > +
>> > + brcmf: bcrmf@1 {
>> > + reg = <1>;
>> > + compatible = "brcm,bcm4329-fmac";
>> > + };
>> Incorrect wifi chip - just deliver what you've tested.
Nope, this compatible is required by the dt binding, see the
binding document or other DTs with brcmfmac SDIO.
Please complain to brcmfmac maintainers.
>
>You are right. Now I found the correct chip ID by enabling debug with
>Broadcom kernel module 'modprobe brcmfmac debug=0x3ffff6'
>
>The module is Ampak AP6212A with Broadcom 43430 rev=1 inside it.
>
>brcmfmac: brcmf_chip_recognition found AXI chip: BCM43430, rev=1
>brcmfmac: brcmf_ops_sdio_probe sdio vendor ID: 0x02d0
>brcmfmac: brcmf_ops_sdio_probe sdio device ID: 0xa9a6
>
>IPv6: ADDRCONF(NETDEV_CHANGE): wlan0: link becomes ready
>
>This information mostly match with https://wikidevi.com/wiki/AMPAK,
>except
>module is actually AP6212A. Some of the modules may not have 'A'
>printed on
>them. However the ones that identify as rev=1 is a AP6212A.
>
>FYI: there were two things that confused me
> - bcm4329-fmac also works.
> - I couldn't configure it to join WiFi network with password.
>
>With change I will send a v4. Here is the propssed diff to v3.
>
>arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts
>
> /*
>- * WiFi driver support could be incomplete,
>- * wlan0 is able to see Base Stations, however not able to
>join.
>+ * AMPAK AP6212A WiFi module with BCM43430, rev=1 inside
>+ * sdio vendor ID: 0x02d0, sdio device ID: 0xa9a6
> */
> brcmf: wifi@1 {
> reg = <1>;
>- compatible = "brcm,bcm4329-fmac";
>+ compatible = "brcm,bcm43430-fmac";
> };
>
>I think now nanopi-neo-plus2.dts, v4, is in a good shape to merge.
>
>thanks for the feedback and review.
>
>regards,
>-antony
next prev parent reply other threads:[~2017-08-28 12:19 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170824231716.2623-1-antony@phenome.org>
2017-08-25 10:32 ` [PATCH v2] arm64: allwinner: h5: add support for NanoPi NEO Plus 2 Antony Antony
2017-08-25 12:05 ` Corentin Labbe
2017-08-25 17:47 ` Antony Antony
2017-08-25 13:28 ` Code Kipper
2017-08-25 17:42 ` Antony Antony
2017-08-28 12:16 ` Antony Antony
2017-08-28 12:18 ` Icenowy Zheng [this message]
2017-08-29 21:51 ` Antony Antony
2017-08-26 11:11 ` [PATCH v3] " Antony Antony
2017-08-28 12:19 ` [PATCH v4] arm64: allwinner: h5: add support for NanoPi NEO Plus2 Antony Antony
2017-08-30 12:50 ` [PATCH v5] " Antony Antony
2017-08-31 14:58 ` Maxime Ripard
2017-09-01 10:53 ` Antony Antony
2017-09-04 8:27 ` Maxime Ripard
2017-09-04 14:26 ` Antony Antony
2017-09-05 11:04 ` Maxime Ripard
2017-09-01 10:58 ` [PATCH] arm64: allwinner: h5: add NanoPi NEO Plus2 DT support Antony Antony
2017-09-01 20:45 ` [PATCH v7] " Antony Antony
2017-09-04 14:30 ` [PATCH v8] " Antony Antony
2017-09-05 11:09 ` Maxime Ripard
2017-09-07 16:42 ` [PATCH v9] " Antony Antony
2017-09-08 14:49 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BF2F26DC-7014-4AF6-9C02-D1038A0FDA38@aosc.io \
--to=icenowy@aosc.io \
--cc=antony@phenome.org \
--cc=codekipper@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=maxime.ripard@free-electrons.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).