From: Mark Brown <broonie@kernel.org>
To: "Łukasz Majewski" <lukma@denx.de>
Cc: Nicolin Chen <nicoleotsuka@gmail.com>,
Timur Tabi <timur@tabi.org>, Xiubo Li <Xiubo.Lee@gmail.com>,
Fabio Estevam <fabio.estevam@nxp.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq
Date: Tue, 5 Sep 2017 16:15:50 +0100 [thread overview]
Message-ID: <20170905151550.5mhb535p22lsohlh@sirena.org.uk> (raw)
In-Reply-To: <deb40031-9db0-d667-7314-352cf548c295@denx.de>
[-- Attachment #1: Type: text/plain, Size: 764 bytes --]
On Tue, Sep 05, 2017 at 10:19:05AM +0200, Łukasz Majewski wrote:
> On 09/05/2017 09:52 AM, Nicolin Chen wrote:
> > Can you elaborate why you set ipg clock as bclk? I don't remember SSI could
> > derive bitclock from ipg clock.
> Just to be clear:
> What clock shall be set with:
> struct snd_soc_dai_ops {
> int (*set_sysclk)(struct snd_soc_dai *dai,
> int clk_id, unsigned int freq, int dir);
> }
> callback?
> The SSI IP block or BCLK ?
Not the BCLK, probably the IP clock but perhaps nothing. The bclk is
usually derived from the sample rate and width, the system clock is the
clock rate going into the device. It doesn't *have* to be configured
(particuarly if it's discoverable by the IP and managable via the clock
API).
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2017-09-05 15:16 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-03 11:05 [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq Lukasz Majewski
[not found] ` <AM5PR0401MB262706674539BFE651706CC6E3900@AM5PR0401MB2627.eurprd04.prod.outlook.com>
2017-09-03 14:40 ` Łukasz Majewski
2017-09-03 15:29 ` Fabio Estevam
2017-09-05 5:20 ` Nicolin Chen
2017-09-05 8:35 ` Łukasz Majewski
2017-09-05 18:11 ` Nicolin Chen
2017-09-05 21:13 ` Łukasz Majewski
2017-09-05 22:52 ` Nicolin Chen
2017-09-06 9:22 ` Łukasz Majewski
2017-09-06 17:33 ` Nicolin Chen
2017-09-06 18:35 ` Łukasz Majewski
2017-09-06 19:47 ` Nicolin Chen
2017-09-06 21:18 ` Łukasz Majewski
2017-09-07 23:10 ` Łukasz Majewski
2017-09-08 0:39 ` Nicolin Chen
2017-09-05 23:20 ` Fabio Estevam
2017-09-06 8:44 ` Łukasz Majewski
2017-09-05 20:14 ` Fabio Estevam
2017-09-05 21:14 ` Łukasz Majewski
2017-09-05 5:06 ` Nicolin Chen
2017-09-05 7:37 ` Łukasz Majewski
2017-09-05 7:52 ` Nicolin Chen
2017-09-05 8:19 ` Łukasz Majewski
2017-09-05 15:15 ` Mark Brown [this message]
2017-09-05 17:45 ` Nicolin Chen
2017-09-07 13:44 ` Mark Brown
2017-09-07 23:03 ` Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170905151550.5mhb535p22lsohlh@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=fabio.estevam@nxp.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lukma@denx.de \
--cc=nicoleotsuka@gmail.com \
--cc=perex@perex.cz \
--cc=timur@tabi.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).