From: "Łukasz Majewski" <lukma@denx.de>
To: Nicolin Chen <nicoleotsuka@gmail.com>
Cc: Fabio Estevam <fabio.estevam@nxp.com>,
Timur Tabi <timur@tabi.org>, Xiubo Li <Xiubo.Lee@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
"festevam@gmail.com" <festevam@gmail.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq
Date: Fri, 8 Sep 2017 01:10:12 +0200 [thread overview]
Message-ID: <76aeecd9-bff8-7b25-ca10-73d0743f724e@denx.de> (raw)
In-Reply-To: <20170906194748.GA31334@Asurada-Nvidia>
Hi Nicolin,
> On Wed, Sep 06, 2017 at 08:35:50PM +0200, Łukasz Majewski wrote:
>
>> clocks = <&clks IMX6QDL_CLK_SSI2_IPG>,
>> <&clks IMX6QDL_CLK_SSI2>;
>> clock-names = "ipg", "baud";
>
>>>> dailink_master: cpu {
>>>> sound-dai = <&ssi2>;
>>>> clock = <&SSSS>;
>>
>> If possible I do prefer a solution, which uses only DTS.
>> Side question - how to refer to baud clock from [1]?
>
> Just add a property to this cpu node like:
> clock = <&clks IMX6QDL_CLK_SSI2>;
This doesn't solve the issue:
root@display5:~# speaker-test
speaker-test 1.1.3
Playback device is default
Stream parameters are 48000Hz, S16_LE, 1 channels
Using 16 octaves of pink noise
Rate set to 48000Hz (requested 48fsl-ssi-dai 202c000.ssi: bitclk > ipgclk/5
000Hz)
Buffer size range from 64fsl-ssi-dai 202c000.ssi: ASoC: can't set
202c000.ssi hw params: -22
to 65536
Period size range from 32 to 8191
Using max buffer size 65536
Periods = 4
Unable to set hw params for playback: Invalid argument
Setting of hwparams failed: Invalid argument
>
>>>> system-clock-frequency = <XXXX>;
>
> This would not be necessary unless you want to specify a clock rate
> so as to override the clock rate configuration in hw_params().
>
>>> This is the right solution based on current simple-card driver. For
>>> SSI (having two clocks), you have to specify the baud clock in the
>>> cpu node like that. I believe this is what the simple-card designer
>>> expected users to do since the cpu node is the first place that the
>>> driver tries to look at.
>>
>> I will give a shoot the option with adding the ipg clock.
>
> No, not ipg clock. You should use the second clock -- baud clock.
>
--
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
next prev parent reply other threads:[~2017-09-07 23:10 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-03 11:05 [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq Lukasz Majewski
[not found] ` <AM5PR0401MB262706674539BFE651706CC6E3900@AM5PR0401MB2627.eurprd04.prod.outlook.com>
2017-09-03 14:40 ` Łukasz Majewski
2017-09-03 15:29 ` Fabio Estevam
2017-09-05 5:20 ` Nicolin Chen
2017-09-05 8:35 ` Łukasz Majewski
2017-09-05 18:11 ` Nicolin Chen
2017-09-05 21:13 ` Łukasz Majewski
2017-09-05 22:52 ` Nicolin Chen
2017-09-06 9:22 ` Łukasz Majewski
2017-09-06 17:33 ` Nicolin Chen
2017-09-06 18:35 ` Łukasz Majewski
2017-09-06 19:47 ` Nicolin Chen
2017-09-06 21:18 ` Łukasz Majewski
2017-09-07 23:10 ` Łukasz Majewski [this message]
2017-09-08 0:39 ` Nicolin Chen
2017-09-05 23:20 ` Fabio Estevam
2017-09-06 8:44 ` Łukasz Majewski
2017-09-05 20:14 ` Fabio Estevam
2017-09-05 21:14 ` Łukasz Majewski
2017-09-05 5:06 ` Nicolin Chen
2017-09-05 7:37 ` Łukasz Majewski
2017-09-05 7:52 ` Nicolin Chen
2017-09-05 8:19 ` Łukasz Majewski
2017-09-05 15:15 ` Mark Brown
2017-09-05 17:45 ` Nicolin Chen
2017-09-07 13:44 ` Mark Brown
2017-09-07 23:03 ` Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76aeecd9-bff8-7b25-ca10-73d0743f724e@denx.de \
--to=lukma@denx.de \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=festevam@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nicoleotsuka@gmail.com \
--cc=perex@perex.cz \
--cc=timur@tabi.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).