* [PATCH] crypto: axis - hide an unused variable
@ 2017-09-06 13:10 Arnd Bergmann
0 siblings, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2017-09-06 13:10 UTC (permalink / raw)
To: Herbert Xu, David S. Miller
Cc: Arnd Bergmann, Jesper Nilsson, Lars Persson, Niklas Cassel,
linux-arm-kernel, linux-crypto, linux-kernel
Without CONFIG_DEBUG_FS, we get a harmless warning:
drivers/crypto/axis/artpec6_crypto.c:352:23: error: 'dbgfs_root' defined but not used [-Werror=unused-variable]
This moves it into the #ifdef that hides the only user.
Fixes: a21eb94fc4d3 ("crypto: axis - add ARTPEC-6/7 crypto accelerator driver")
Acked-by: Lars Persson <larper@axis.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
Originally sent on August 25, but hasn't made it into linux-next
yet. Resending it in case it got lost, sorry for any duplicates
if this was still pending.
---
drivers/crypto/axis/artpec6_crypto.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/crypto/axis/artpec6_crypto.c b/drivers/crypto/axis/artpec6_crypto.c
index d9fbbf01062b..0f9754e07719 100644
--- a/drivers/crypto/axis/artpec6_crypto.c
+++ b/drivers/crypto/axis/artpec6_crypto.c
@@ -349,8 +349,6 @@ struct artpec6_crypto_aead_req_ctx {
/* The crypto framework makes it hard to avoid this global. */
static struct device *artpec6_crypto_dev;
-static struct dentry *dbgfs_root;
-
#ifdef CONFIG_FAULT_INJECTION
static DECLARE_FAULT_ATTR(artpec6_crypto_fail_status_read);
static DECLARE_FAULT_ATTR(artpec6_crypto_fail_dma_array_full);
@@ -2984,6 +2982,8 @@ struct dbgfs_u32 {
char *desc;
};
+static struct dentry *dbgfs_root;
+
static void artpec6_crypto_init_debugfs(void)
{
dbgfs_root = debugfs_create_dir("artpec6_crypto", NULL);
--
2.9.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] crypto: axis - hide an unused variable
2017-08-24 22:19 Arnd Bergmann
2017-08-26 7:57 ` Lars Persson
@ 2017-09-22 10:14 ` Herbert Xu
1 sibling, 0 replies; 4+ messages in thread
From: Herbert Xu @ 2017-09-22 10:14 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Jesper Nilsson, Lars Persson, Niklas Cassel, David S. Miller,
linux-arm-kernel, linux-crypto, linux-kernel
On Fri, Aug 25, 2017 at 12:19:54AM +0200, Arnd Bergmann wrote:
> Without CONFIG_DEBUG_FS, we get a harmless warning:
>
> drivers/crypto/axis/artpec6_crypto.c:352:23: error: 'dbgfs_root' defined but not used [-Werror=unused-variable]
>
> This moves it into the #ifdef that hides the only user.
>
> Fixes: a21eb94fc4d3 ("crypto: axis - add ARTPEC-6/7 crypto accelerator driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] crypto: axis - hide an unused variable
2017-08-24 22:19 Arnd Bergmann
@ 2017-08-26 7:57 ` Lars Persson
2017-09-22 10:14 ` Herbert Xu
1 sibling, 0 replies; 4+ messages in thread
From: Lars Persson @ 2017-08-26 7:57 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Jesper Nilsson, Niklas Cassel, Herbert Xu, David S. Miller,
linux-arm-kernel, linux-crypto, linux-kernel
> 25 aug. 2017 kl. 01:20 skrev Arnd Bergmann <arnd@arndb.de>:
>
> Without CONFIG_DEBUG_FS, we get a harmless warning:
>
> drivers/crypto/axis/artpec6_crypto.c:352:23: error: 'dbgfs_root' defined but not used [-Werror=unused-variable]
>
> This moves it into the #ifdef that hides the only user.
>
> Fixes: a21eb94fc4d3 ("crypto: axis - add ARTPEC-6/7 crypto accelerator driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/crypto/axis/artpec6_crypto.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/crypto/axis/artpec6_crypto.c b/drivers/crypto/axis/artpec6_crypto.c
> index d9fbbf01062b..0f9754e07719 100644
> --- a/drivers/crypto/axis/artpec6_crypto.c
> +++ b/drivers/crypto/axis/artpec6_crypto.c
> @@ -349,8 +349,6 @@ struct artpec6_crypto_aead_req_ctx {
> /* The crypto framework makes it hard to avoid this global. */
> static struct device *artpec6_crypto_dev;
>
> -static struct dentry *dbgfs_root;
> -
> #ifdef CONFIG_FAULT_INJECTION
> static DECLARE_FAULT_ATTR(artpec6_crypto_fail_status_read);
> static DECLARE_FAULT_ATTR(artpec6_crypto_fail_dma_array_full);
> @@ -2984,6 +2982,8 @@ struct dbgfs_u32 {
> char *desc;
> };
>
> +static struct dentry *dbgfs_root;
> +
> static void artpec6_crypto_init_debugfs(void)
> {
> dbgfs_root = debugfs_create_dir("artpec6_crypto", NULL);
> --
> 2.9.0
Acked-by: Lars Persson <larper@axis.com>
Thanks,
Lars
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] crypto: axis - hide an unused variable
@ 2017-08-24 22:19 Arnd Bergmann
2017-08-26 7:57 ` Lars Persson
2017-09-22 10:14 ` Herbert Xu
0 siblings, 2 replies; 4+ messages in thread
From: Arnd Bergmann @ 2017-08-24 22:19 UTC (permalink / raw)
To: Jesper Nilsson, Lars Persson, Niklas Cassel, Herbert Xu, David S. Miller
Cc: Arnd Bergmann, linux-arm-kernel, linux-crypto, linux-kernel
Without CONFIG_DEBUG_FS, we get a harmless warning:
drivers/crypto/axis/artpec6_crypto.c:352:23: error: 'dbgfs_root' defined but not used [-Werror=unused-variable]
This moves it into the #ifdef that hides the only user.
Fixes: a21eb94fc4d3 ("crypto: axis - add ARTPEC-6/7 crypto accelerator driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/crypto/axis/artpec6_crypto.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/crypto/axis/artpec6_crypto.c b/drivers/crypto/axis/artpec6_crypto.c
index d9fbbf01062b..0f9754e07719 100644
--- a/drivers/crypto/axis/artpec6_crypto.c
+++ b/drivers/crypto/axis/artpec6_crypto.c
@@ -349,8 +349,6 @@ struct artpec6_crypto_aead_req_ctx {
/* The crypto framework makes it hard to avoid this global. */
static struct device *artpec6_crypto_dev;
-static struct dentry *dbgfs_root;
-
#ifdef CONFIG_FAULT_INJECTION
static DECLARE_FAULT_ATTR(artpec6_crypto_fail_status_read);
static DECLARE_FAULT_ATTR(artpec6_crypto_fail_dma_array_full);
@@ -2984,6 +2982,8 @@ struct dbgfs_u32 {
char *desc;
};
+static struct dentry *dbgfs_root;
+
static void artpec6_crypto_init_debugfs(void)
{
dbgfs_root = debugfs_create_dir("artpec6_crypto", NULL);
--
2.9.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-09-22 10:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-06 13:10 [PATCH] crypto: axis - hide an unused variable Arnd Bergmann
-- strict thread matches above, loose matches on Subject: below --
2017-08-24 22:19 Arnd Bergmann
2017-08-26 7:57 ` Lars Persson
2017-09-22 10:14 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).