* [PATCH] Staging: atomisp: fix alloc_cast.cocci warnings
@ 2017-09-07 16:26 Branislav Radocaj
2017-09-11 14:59 ` Sakari Ailus
0 siblings, 1 reply; 2+ messages in thread
From: Branislav Radocaj @ 2017-09-07 16:26 UTC (permalink / raw)
To: mchehab, gregkh
Cc: alan, hans.verkuil, rvarsha016, singhalsimran0, branislav,
linux-media, devel, linux-kernel
Remove casting the values returned by memory allocation functions
like kmalloc, kzalloc, kmem_cache_alloc, kmem_cache_zalloc etc.
Semantic patch information:
This makes an effort to find cases of casting of values returned by
kmalloc, kzalloc, kcalloc, kmem_cache_alloc, kmem_cache_zalloc,
kmem_cache_alloc_node, kmalloc_node and kzalloc_node and removes
the casting as it is not required. The result in the patch case may
need some reformatting.
Generated by: scripts/coccinelle/api/alloc/alloc_cast.cocci
Signed-off-by: Branislav Radocaj <branislav@radocaj.org>
---
drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_firmware.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_firmware.c b/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_firmware.c
index eecd8cf71951..56765d6a0498 100644
--- a/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_firmware.c
+++ b/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_firmware.c
@@ -133,7 +133,7 @@ sh_css_load_blob_info(const char *fw, const struct ia_css_fw_info *bi, struct ia
char *namebuffer;
int namelength = (int)strlen(name);
- namebuffer = (char *) kmalloc(namelength + 1, GFP_KERNEL);
+ namebuffer = kmalloc(namelength + 1, GFP_KERNEL);
if (namebuffer == NULL)
return IA_CSS_ERR_CANNOT_ALLOCATE_MEMORY;
@@ -149,7 +149,7 @@ sh_css_load_blob_info(const char *fw, const struct ia_css_fw_info *bi, struct ia
size_t configstruct_size = sizeof(struct ia_css_config_memory_offsets);
size_t statestruct_size = sizeof(struct ia_css_state_memory_offsets);
- char *parambuf = (char *)kmalloc(paramstruct_size + configstruct_size + statestruct_size,
+ char *parambuf = kmalloc(paramstruct_size + configstruct_size + statestruct_size,
GFP_KERNEL);
if (parambuf == NULL)
return IA_CSS_ERR_CANNOT_ALLOCATE_MEMORY;
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Staging: atomisp: fix alloc_cast.cocci warnings
2017-09-07 16:26 [PATCH] Staging: atomisp: fix alloc_cast.cocci warnings Branislav Radocaj
@ 2017-09-11 14:59 ` Sakari Ailus
0 siblings, 0 replies; 2+ messages in thread
From: Sakari Ailus @ 2017-09-11 14:59 UTC (permalink / raw)
To: Branislav Radocaj
Cc: mchehab, gregkh, alan, hans.verkuil, rvarsha016, singhalsimran0,
linux-media, devel, linux-kernel
Hi Branislav,
On Thu, Sep 07, 2017 at 06:26:42PM +0200, Branislav Radocaj wrote:
> Remove casting the values returned by memory allocation functions
> like kmalloc, kzalloc, kmem_cache_alloc, kmem_cache_zalloc etc.
>
> Semantic patch information:
> This makes an effort to find cases of casting of values returned by
> kmalloc, kzalloc, kcalloc, kmem_cache_alloc, kmem_cache_zalloc,
> kmem_cache_alloc_node, kmalloc_node and kzalloc_node and removes
> the casting as it is not required. The result in the patch case may
> need some reformatting.
>
> Generated by: scripts/coccinelle/api/alloc/alloc_cast.cocci
>
> Signed-off-by: Branislav Radocaj <branislav@radocaj.org>
> ---
> drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_firmware.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_firmware.c b/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_firmware.c
> index eecd8cf71951..56765d6a0498 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_firmware.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_firmware.c
> @@ -133,7 +133,7 @@ sh_css_load_blob_info(const char *fw, const struct ia_css_fw_info *bi, struct ia
> char *namebuffer;
> int namelength = (int)strlen(name);
>
> - namebuffer = (char *) kmalloc(namelength + 1, GFP_KERNEL);
> + namebuffer = kmalloc(namelength + 1, GFP_KERNEL);
This chunk no longer applies, I'm applying the one that does. The kmalloc
has been replaced by kstrdup.
> if (namebuffer == NULL)
> return IA_CSS_ERR_CANNOT_ALLOCATE_MEMORY;
>
> @@ -149,7 +149,7 @@ sh_css_load_blob_info(const char *fw, const struct ia_css_fw_info *bi, struct ia
> size_t configstruct_size = sizeof(struct ia_css_config_memory_offsets);
> size_t statestruct_size = sizeof(struct ia_css_state_memory_offsets);
>
> - char *parambuf = (char *)kmalloc(paramstruct_size + configstruct_size + statestruct_size,
> + char *parambuf = kmalloc(paramstruct_size + configstruct_size + statestruct_size,
> GFP_KERNEL);
> if (parambuf == NULL)
> return IA_CSS_ERR_CANNOT_ALLOCATE_MEMORY;
--
Sakari Ailus
e-mail: sakari.ailus@iki.fi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-11 14:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-07 16:26 [PATCH] Staging: atomisp: fix alloc_cast.cocci warnings Branislav Radocaj
2017-09-11 14:59 ` Sakari Ailus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).