From: Eduardo Valentin <edubezval@gmail.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: ldewangan@nvidia.com, linux-pm@vger.kernel.org,
Zhang Rui <rui.zhang@intel.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] thermal/drivers/generic-iio-adc: Switch tz request to devm version
Date: Thu, 7 Sep 2017 19:56:07 -0700 [thread overview]
Message-ID: <20170908025606.GA2755@localhost.localdomain> (raw)
In-Reply-To: <1504808230-12288-1-git-send-email-daniel.lezcano@linaro.org>
Hey Daniel,
On Thu, Sep 07, 2017 at 08:17:10PM +0200, Daniel Lezcano wrote:
> Everything mentionned here:
> https://lkml.org/lkml/2016/4/20/850
>
> This driver was added before the devm_iio_channel_get() function version was
> merged. The sensor should be released before the iio channel, thus we had to
> use the non-devm version of thermal_zone_of_sensor_register().
>
> Now the devm_iio_channel_get() is available, do the corresponding change in
> this driver.
>
> [Compiled tested only]
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
> drivers/thermal/thermal-generic-adc.c | 13 ++++---------
> 1 file changed, 4 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/thermal/thermal-generic-adc.c b/drivers/thermal/thermal-generic-adc.c
> index 73f55d6..71d0365 100644
> --- a/drivers/thermal/thermal-generic-adc.c
> +++ b/drivers/thermal/thermal-generic-adc.c
> @@ -126,28 +126,23 @@ static int gadc_thermal_probe(struct platform_device *pdev)
> gti->dev = &pdev->dev;
> platform_set_drvdata(pdev, gti);
>
> - gti->channel = iio_channel_get(&pdev->dev, "sensor-channel");
> + gti->channel = devm_iio_channel_get(&pdev->dev, "sensor-channel");
> if (IS_ERR(gti->channel)) {
> ret = PTR_ERR(gti->channel);
> dev_err(&pdev->dev, "IIO channel not found: %d\n", ret);
> return ret;
> }
>
> - gti->tz_dev = thermal_zone_of_sensor_register(&pdev->dev, 0,
> - gti, &gadc_thermal_ops);
> + gti->tz_dev = devm_thermal_zone_of_sensor_register(&pdev->dev, 0, gti,
> + &gadc_thermal_ops);
> if (IS_ERR(gti->tz_dev)) {
> ret = PTR_ERR(gti->tz_dev);
> dev_err(&pdev->dev, "Thermal zone sensor register failed: %d\n",
> ret);
> - goto sensor_fail;
> + return ret;
> }
>
> return 0;
> -
> -sensor_fail:
> - iio_channel_release(gti->channel);
> -
> - return ret;
> }
>
> static int gadc_thermal_remove(struct platform_device *pdev)
Any particular reason why this patch does not include a removal of
gadc_thermal_remove()?
> --
> 2.7.4
>
next prev parent reply other threads:[~2017-09-08 2:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-07 18:17 [PATCH] thermal/drivers/generic-iio-adc: Switch tz request to devm version Daniel Lezcano
2017-09-08 2:56 ` Eduardo Valentin [this message]
2017-09-08 7:01 ` [PATCH V2] " Daniel Lezcano
2017-09-08 7:13 ` Laxman Dewangan
2017-09-08 7:02 ` [PATCH] " Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170908025606.GA2755@localhost.localdomain \
--to=edubezval@gmail.com \
--cc=daniel.lezcano@linaro.org \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).