From: Thiebaud Weksteen <tweek@google.com>
To: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
Ashley Lai <ashleydlai@gmail.com>,
Nayna Jain <nayna@linux.vnet.ibm.com>
Cc: linux-efi@vger.kernel.org, ard.biesheuvel@linaro.org,
matt@codeblueprint.co.uk, linux-kernel@vger.kernel.org,
mjg59@google.com, tpmdd-devel@lists.sourceforge.net,
peterhuewe@gmx.de, jarkko.sakkinen@linux.intel.com,
tpmdd@selhorst.net
Subject: Re: [PATCH v2 3/3] tpm: parse TPM event logs based on EFI table
Date: Tue, 12 Sep 2017 10:48:51 +0200 [thread overview]
Message-ID: <20170912084851.z3ednbeojawnyxk2@google.com> (raw)
In-Reply-To: <20170911164750.GA2607@obsidianresearch.com>
On Mon, Sep 11, 2017 at 10:47:50AM -0600, Jason Gunthorpe wrote:
> On Mon, Sep 11, 2017 at 12:00:22PM +0200, Thiebaud Weksteen wrote:
>
> > chip->bin_log_seqops.chip = chip;
> > - if (chip->flags & TPM_CHIP_FLAG_TPM2)
> > +
> > + if (log_version == EFI_TCG2_EVENT_LOG_FORMAT_TCG_2 ||
> > + (!log_version && (chip->flags & TPM_CHIP_FLAG_TPM2)))
> > chip->bin_log_seqops.seqops =
> > &tpm2_binary_b_measurements_seqops;
>
> Lets have all the read_log_* versions return the postitive log_version
> and get rid of the chip->flags check here.
>
> ie Doesn't ACPI always return the TPM 1 version?
That is my understanding. Ashley, Nayna, could you confirm the format
version expected by tpm_of? Could it be both?
>
> Jason
next prev parent reply other threads:[~2017-09-12 8:49 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-11 10:00 [PATCH v2 0/3] Call GetEventLog before ExitBootServices Thiebaud Weksteen
2017-09-11 10:00 ` [PATCH v2 1/3] tpm: move tpm_eventlog.h outside of drivers folder Thiebaud Weksteen
2017-09-11 10:00 ` [PATCH v2 2/3] efi: call get_event_log before ExitBootServices Thiebaud Weksteen
2017-09-13 14:49 ` kbuild test robot
2017-09-14 10:24 ` [tpmdd-devel] " Javier Martinez Canillas
2017-09-18 12:11 ` Thiebaud Weksteen
2017-09-18 12:49 ` Javier Martinez Canillas
2017-09-14 18:43 ` Jarkko Sakkinen
2017-09-14 18:48 ` Matthew Garrett
2017-09-14 19:02 ` Jarkko Sakkinen
2017-09-15 4:06 ` Jarkko Sakkinen
2017-09-18 12:28 ` Thiebaud Weksteen
2017-09-18 17:56 ` Jarkko Sakkinen
2017-09-11 10:00 ` [PATCH v2 3/3] tpm: parse TPM event logs based on EFI table Thiebaud Weksteen
2017-09-11 16:47 ` Jason Gunthorpe
2017-09-12 8:48 ` Thiebaud Weksteen [this message]
2017-09-18 12:38 ` Thiebaud Weksteen
2017-09-18 16:28 ` Jason Gunthorpe
2017-09-13 16:27 ` kbuild test robot
2017-09-13 16:43 ` Thiebaud Weksteen
2017-09-14 18:47 ` Jarkko Sakkinen
2017-09-18 12:33 ` Thiebaud Weksteen
2017-09-13 18:59 ` [PATCH v2 0/3] Call GetEventLog before ExitBootServices Jarkko Sakkinen
2017-09-14 10:21 ` [tpmdd-devel] " Javier Martinez Canillas
2017-11-03 15:27 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170912084851.z3ednbeojawnyxk2@google.com \
--to=tweek@google.com \
--cc=ard.biesheuvel@linaro.org \
--cc=ashleydlai@gmail.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeblueprint.co.uk \
--cc=mjg59@google.com \
--cc=nayna@linux.vnet.ibm.com \
--cc=peterhuewe@gmx.de \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tpmdd@selhorst.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).