From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Thiebaud Weksteen <tweek@google.com>
Cc: linux-efi@vger.kernel.org, ard.biesheuvel@linaro.org,
matt@codeblueprint.co.uk, linux-kernel@vger.kernel.org,
mjg59@google.com, tpmdd-devel@lists.sourceforge.net,
peterhuewe@gmx.de, jgunthorpe@obsidianresearch.com,
tpmdd@selhorst.net
Subject: Re: [PATCH v2 2/3] efi: call get_event_log before ExitBootServices
Date: Thu, 14 Sep 2017 11:43:28 -0700 [thread overview]
Message-ID: <20170914184126.eevnstwq3i6fiq4j@linux.intel.com> (raw)
In-Reply-To: <20170911100022.7251-3-tweek@google.com>
On Mon, Sep 11, 2017 at 12:00:21PM +0200, Thiebaud Weksteen wrote:
> With TPM 2.0 specification, the event logs may only be accessible by
> calling an EFI Boot Service. Modify the EFI stub to copy the log area to
> a new Linux-specific EFI configuration table so it remains accessible
> once booted.
>
> When calling this service, it is possible to specify the expected format
> of the logs: TPM 1.2 (SHA1) or TPM 2.0 ("Crypto Agile"). For now, only the
> first format is retrieved.
>
> Signed-off-by: Thiebaud Weksteen <tweek@google.com>
With a quick skim the code change looks good but I remember from
Matthew's talk that there was this issue that ExitBootServices() would
cause a yet another event?
I guess you could manually synthetize that event by reading the PCR
values right after ExitBootServices()?
Anyway, great work, thanks for making this effort.
/Jarkko
next prev parent reply other threads:[~2017-09-14 18:43 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-11 10:00 [PATCH v2 0/3] Call GetEventLog before ExitBootServices Thiebaud Weksteen
2017-09-11 10:00 ` [PATCH v2 1/3] tpm: move tpm_eventlog.h outside of drivers folder Thiebaud Weksteen
2017-09-11 10:00 ` [PATCH v2 2/3] efi: call get_event_log before ExitBootServices Thiebaud Weksteen
2017-09-13 14:49 ` kbuild test robot
2017-09-14 10:24 ` [tpmdd-devel] " Javier Martinez Canillas
2017-09-18 12:11 ` Thiebaud Weksteen
2017-09-18 12:49 ` Javier Martinez Canillas
2017-09-14 18:43 ` Jarkko Sakkinen [this message]
2017-09-14 18:48 ` Matthew Garrett
2017-09-14 19:02 ` Jarkko Sakkinen
2017-09-15 4:06 ` Jarkko Sakkinen
2017-09-18 12:28 ` Thiebaud Weksteen
2017-09-18 17:56 ` Jarkko Sakkinen
2017-09-11 10:00 ` [PATCH v2 3/3] tpm: parse TPM event logs based on EFI table Thiebaud Weksteen
2017-09-11 16:47 ` Jason Gunthorpe
2017-09-12 8:48 ` Thiebaud Weksteen
2017-09-18 12:38 ` Thiebaud Weksteen
2017-09-18 16:28 ` Jason Gunthorpe
2017-09-13 16:27 ` kbuild test robot
2017-09-13 16:43 ` Thiebaud Weksteen
2017-09-14 18:47 ` Jarkko Sakkinen
2017-09-18 12:33 ` Thiebaud Weksteen
2017-09-13 18:59 ` [PATCH v2 0/3] Call GetEventLog before ExitBootServices Jarkko Sakkinen
2017-09-14 10:21 ` [tpmdd-devel] " Javier Martinez Canillas
2017-11-03 15:27 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170914184126.eevnstwq3i6fiq4j@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=ard.biesheuvel@linaro.org \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeblueprint.co.uk \
--cc=mjg59@google.com \
--cc=peterhuewe@gmx.de \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tpmdd@selhorst.net \
--cc=tweek@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).