* [PATCH] remoteproc: qcom: select QCOM_SMP2P for all qcom pils
@ 2017-09-13 16:04 srinivas.kandagatla
2017-09-14 16:57 ` Bjorn Andersson
0 siblings, 1 reply; 3+ messages in thread
From: srinivas.kandagatla @ 2017-09-13 16:04 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Ohad Ben-Cohen, linux-remoteproc, linux-kernel, Srinivas Kandagatla
From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
All Qualcomm PIL drivers require SMP2P module to get a functional PIL,
Currently user has to explicitly select SMP2P module, after looking
at failure logs.
Fix this by selecting SMP2P as part of dependency of pil kconfig itself.
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
drivers/remoteproc/Kconfig | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig
index 8891a8e50f12..052c9e20abb6 100644
--- a/drivers/remoteproc/Kconfig
+++ b/drivers/remoteproc/Kconfig
@@ -87,6 +87,7 @@ config QCOM_ADSP_PIL
select QCOM_MDT_LOADER
select QCOM_RPROC_COMMON
select QCOM_SCM
+ select QCOM_SMP2P
help
Say y here to support the TrustZone based Peripherial Image Loader
for the Qualcomm ADSP remote processors.
@@ -102,6 +103,7 @@ config QCOM_Q6V5_PIL
select MFD_SYSCON
select QCOM_RPROC_COMMON
select QCOM_SCM
+ select QCOM_SMP2P
help
Say y here to support the Qualcomm Peripherial Image Loader for the
Hexagon V5 based remote processors.
@@ -114,6 +116,7 @@ config QCOM_WCNSS_PIL
select QCOM_MDT_LOADER
select QCOM_RPROC_COMMON
select QCOM_SCM
+ select QCOM_SMP2P
help
Say y here to support the Peripheral Image Loader for the Qualcomm
Wireless Connectivity Subsystem.
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] remoteproc: qcom: select QCOM_SMP2P for all qcom pils
2017-09-13 16:04 [PATCH] remoteproc: qcom: select QCOM_SMP2P for all qcom pils srinivas.kandagatla
@ 2017-09-14 16:57 ` Bjorn Andersson
2017-09-15 9:09 ` Srinivas Kandagatla
0 siblings, 1 reply; 3+ messages in thread
From: Bjorn Andersson @ 2017-09-14 16:57 UTC (permalink / raw)
To: srinivas.kandagatla; +Cc: Ohad Ben-Cohen, linux-remoteproc, linux-kernel
On Wed 13 Sep 09:04 PDT 2017, srinivas.kandagatla@linaro.org wrote:
> From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>
> All Qualcomm PIL drivers require SMP2P module to get a functional PIL,
> Currently user has to explicitly select SMP2P module, after looking
> at failure logs.
>
> Fix this by selecting SMP2P as part of dependency of pil kconfig itself.
>
The Kconfig should describe dependencies needed by the code, not by the
system.
I agree with you that this leads to wasted time trying figure out if
we're missing drivers/modules in the kernel, but I think that needs to
be solved in a more generic way.
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
> drivers/remoteproc/Kconfig | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig
> index 8891a8e50f12..052c9e20abb6 100644
> --- a/drivers/remoteproc/Kconfig
> +++ b/drivers/remoteproc/Kconfig
> @@ -87,6 +87,7 @@ config QCOM_ADSP_PIL
> select QCOM_MDT_LOADER
> select QCOM_RPROC_COMMON
> select QCOM_SCM
> + select QCOM_SMP2P
NB. QCOM_SMP2P is a user-selectable config option, so you are not
allowed to "select" it, only "depends on" it.
Regards,
Bjorn
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] remoteproc: qcom: select QCOM_SMP2P for all qcom pils
2017-09-14 16:57 ` Bjorn Andersson
@ 2017-09-15 9:09 ` Srinivas Kandagatla
0 siblings, 0 replies; 3+ messages in thread
From: Srinivas Kandagatla @ 2017-09-15 9:09 UTC (permalink / raw)
To: Bjorn Andersson; +Cc: Ohad Ben-Cohen, linux-remoteproc, linux-kernel
On 14/09/17 17:57, Bjorn Andersson wrote:
> On Wed 13 Sep 09:04 PDT 2017, srinivas.kandagatla@linaro.org wrote:
>
>> From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>>
>> All Qualcomm PIL drivers require SMP2P module to get a functional PIL,
>> Currently user has to explicitly select SMP2P module, after looking
>> at failure logs.
>>
>> Fix this by selecting SMP2P as part of dependency of pil kconfig itself.
>>
>
> The Kconfig should describe dependencies needed by the code, not by the
> system.
I partially agree with this! As I did not realize that that there are
more than one SMEM_STATE drivers.
The driver bindings clearly marks "qcom,smem-states" and
"qcom,smem-state-names" as required properties, so it makes the driver
dependent on SMEM_STATE.
But SMEM_STATE is only selected from SMP2P Kconfig.
Indirectly/directly the driver is dependent on the SMEM_STATE drivers.
>
> I agree with you that this leads to wasted time trying figure out if
> we're missing drivers/modules in the kernel, but I think that needs to
> be solved in a more generic way.
>
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>> ---
>> drivers/remoteproc/Kconfig | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig
>> index 8891a8e50f12..052c9e20abb6 100644
>> --- a/drivers/remoteproc/Kconfig
>> +++ b/drivers/remoteproc/Kconfig
>> @@ -87,6 +87,7 @@ config QCOM_ADSP_PIL
>> select QCOM_MDT_LOADER
>> select QCOM_RPROC_COMMON
>> select QCOM_SCM
>> + select QCOM_SMP2P
I agree, instead of select, we should mark these configs with a
depends on QCOM_SMEM_STATE
so that the final pil kconfigs are only selected with right dependencies
are in place.
Does that sound okay?
thanks,
srini
>
> NB. QCOM_SMP2P is a user-selectable config option, so you are not
> allowed to "select" it, only "depends on" it.
>
> Regards,
> Bjorn
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-09-15 9:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-13 16:04 [PATCH] remoteproc: qcom: select QCOM_SMP2P for all qcom pils srinivas.kandagatla
2017-09-14 16:57 ` Bjorn Andersson
2017-09-15 9:09 ` Srinivas Kandagatla
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).