From: Martin Kepplinger <martink@posteo.de>
To: mingo.kernel.org@gmail.com, jpoimboe@redhat.com
Cc: linux-kernel@vger.kernel.org, Martin Kepplinger <martink@posteo.de>
Subject: [PATCH v2] tools: objtool: fix memory leak in elf_create_rela_section()
Date: Thu, 14 Sep 2017 08:01:38 +0200 [thread overview]
Message-ID: <20170914060138.26472-1-martink@posteo.de> (raw)
In-Reply-To: <20170914053145.7clhcoauwecrldi2@gmail.com>
Let's free the allocated char array relaname before returning
in order to avoid leaking memory.
Signed-off-by: Martin Kepplinger <martink@posteo.de>
---
I should've allocated some brain resources before freeing some computer's.
tools/objtool/elf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/objtool/elf.c b/tools/objtool/elf.c
index 6e9f980a7d26..1e89a5f8bfc9 100644
--- a/tools/objtool/elf.c
+++ b/tools/objtool/elf.c
@@ -508,6 +508,7 @@ struct section *elf_create_rela_section(struct elf *elf, struct section *base)
strcat(relaname, base->name);
sec = elf_create_section(elf, relaname, sizeof(GElf_Rela), 0);
+ free(relaname);
if (!sec)
return NULL;
--
2.11.0
next prev parent reply other threads:[~2017-09-14 6:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-13 22:41 [PATCH] tools: objtool: fix memory leak in elf_create_rela_section() Josh Poimboeuf
2017-09-14 5:31 ` Ingo Molnar
2017-09-14 6:01 ` Martin Kepplinger [this message]
2017-09-14 12:50 ` [PATCH v2] " Josh Poimboeuf
2017-09-14 14:06 ` [tip:core/urgent] tools/objtool: Fix " tip-bot for Martin Kepplinger
2017-09-15 8:43 ` tip-bot for Martin Kepplinger
2017-09-15 9:36 ` [tip:core/urgent] objtool: " tip-bot for Martin Kepplinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170914060138.26472-1-martink@posteo.de \
--to=martink@posteo.de \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo.kernel.org@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).