linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: linux-kernel@vger.kernel.org, Martin Kepplinger <martink@posteo.de>
Subject: Re: [PATCH] tools: objtool: fix memory leak in elf_create_rela_section()
Date: Thu, 14 Sep 2017 07:31:45 +0200	[thread overview]
Message-ID: <20170914053145.7clhcoauwecrldi2@gmail.com> (raw)
In-Reply-To: <8143a814a7c4ed2d099ee2c520f20ff30d2b3e17.1505342451.git.jpoimboe@redhat.com>


* Josh Poimboeuf <jpoimboe@redhat.com> wrote:

> From: Martin Kepplinger <martink@posteo.de>
> 
> Let's free the allocated char array relaname before returning
> in order to avoid leaking memory.
> 
> Signed-off-by: Martin Kepplinger <martink@posteo.de>
> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
> ---
>  tools/objtool/elf.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/objtool/elf.c b/tools/objtool/elf.c
> index 6e9f980a7d26..6aacbc31316d 100644
> --- a/tools/objtool/elf.c
> +++ b/tools/objtool/elf.c
> @@ -508,8 +508,12 @@ struct section *elf_create_rela_section(struct elf *elf, struct section *base)
>  	strcat(relaname, base->name);
>  
>  	sec = elf_create_section(elf, relaname, sizeof(GElf_Rela), 0);
> -	if (!sec)
> +	if (!sec) {
> +		free(relaname);
>  		return NULL;
> +	}
> +
> +	free(relaname);

Erm, I'm quite sure if you read this code a second time you'll see how this 
pattern could be improved! ;-)

Thanks,

	Ingo

  reply	other threads:[~2017-09-14  5:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-13 22:41 [PATCH] tools: objtool: fix memory leak in elf_create_rela_section() Josh Poimboeuf
2017-09-14  5:31 ` Ingo Molnar [this message]
2017-09-14  6:01   ` [PATCH v2] " Martin Kepplinger
2017-09-14 12:50     ` Josh Poimboeuf
2017-09-14 14:06     ` [tip:core/urgent] tools/objtool: Fix " tip-bot for Martin Kepplinger
2017-09-15  8:43     ` tip-bot for Martin Kepplinger
2017-09-15  9:36     ` [tip:core/urgent] objtool: " tip-bot for Martin Kepplinger
  -- strict thread matches above, loose matches on Subject: below --
2017-09-13 18:52 [PATCH] tools: objtool: fix " Martin Kepplinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170914053145.7clhcoauwecrldi2@gmail.com \
    --to=mingo@kernel.org \
    --cc=jpoimboe@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martink@posteo.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).