* Re: [PATCH v9] usb: serial: add vid:pid for Cypress WICED dev board
[not found] <BLUPR11MB0673DEB7AA176C24DFD599A3ED950@BLUPR11MB0673.namprd11.prod.outlook.com>
@ 2017-09-18 8:40 ` Johan Hovold
2017-09-18 16:58 ` Jeffrey Chu
0 siblings, 1 reply; 3+ messages in thread
From: Johan Hovold @ 2017-09-18 8:40 UTC (permalink / raw)
To: Sheng-Hui J. Chu; +Cc: gregkh, johan, linux-usb, linux-kernel, Jeffrey Chu
On Fri, Sep 08, 2017 at 09:08:58PM +0000, Sheng-Hui J. Chu wrote:
> From: Jeffrey Chu <jeffrey.chu@cypress.com>
>
> Add CYPRESS_VID vid and CYPRESS_WICED_BT_USB and CYPRESS_WICED_WL_USB
> device IDs to ftdi_sio driver
>
> Signed-off-by: Jeffrey Chu <jeffrey.chu@cypress.com>
I have two v9 of this patch in my mailbox with different authorship and
sent five minutes apart. I figured you really wanted this last one
applied, but next time make sure to increase the patch revision (e.g.
mark it as v10) to avoid any confusion.
> ---
> drivers/usb/serial/ftdi_sio.c | 2 ++
> drivers/usb/serial/ftdi_sio_ids.h | 7 +++++++
> 2 files changed, 9 insertions(+)
>
> diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c
> index 1cec037..49d1b2d 100644
> --- a/drivers/usb/serial/ftdi_sio.c
> +++ b/drivers/usb/serial/ftdi_sio.c
> @@ -1015,6 +1015,8 @@ static const struct usb_device_id id_table_combined[] = {
> { USB_DEVICE(WICED_VID, WICED_USB20706V2_PID) },
> { USB_DEVICE(TI_VID, TI_CC3200_LAUNCHPAD_PID),
> .driver_info = (kernel_ulong_t)&ftdi_jtag_quirk },
> + { USB_DEVICE(CYPRESS_VID, CYPRESS_WICED_BT_USB_PID) },
> + { USB_DEVICE(CYPRESS_VID, CYPRESS_WICED_WL_USB_PID) },
> { } /* Terminating entry */
> };
>
> diff --git a/drivers/usb/serial/ftdi_sio_ids.h b/drivers/usb/serial/ftdi_sio_ids.h
> index 4fcf1ce..d58dc1b 100644
> --- a/drivers/usb/serial/ftdi_sio_ids.h
> +++ b/drivers/usb/serial/ftdi_sio_ids.h
> @@ -692,6 +692,13 @@
> #define WICED_USB20706V2_PID 0x6422
>
> /*
> + * Cypress WICED USB UART
> + */
> +#define CYPRESS_VID 0x04B4
> +#define CYPRESS_WICED_BT_USB_PID 0x009B
> +#define CYPRESS_WICED_WL_USB_PID 0xF900
> +
> +/*
> * Definitions for ID TECH (www.idt-net.com) devices
> */
> #define IDTECH_VID 0x0ACD /* ID TECH Vendor ID */
I've applied this one now with some minor tweaks (e.g. kept the define
sections sorted by VID, and adjusted the commit message slightly).
Thanks,
Johan
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH v9] usb: serial: add vid:pid for Cypress WICED dev board
2017-09-18 8:40 ` [PATCH v9] usb: serial: add vid:pid for Cypress WICED dev board Johan Hovold
@ 2017-09-18 16:58 ` Jeffrey Chu
0 siblings, 0 replies; 3+ messages in thread
From: Jeffrey Chu @ 2017-09-18 16:58 UTC (permalink / raw)
To: Johan Hovold, Sheng-Hui J. Chu; +Cc: gregkh, linux-usb, linux-kernel
Thanks, -Jeffrey
-----Original Message-----
From: Johan Hovold [mailto:jhovold@gmail.com] On Behalf Of Johan Hovold
Sent: Monday, September 18, 2017 4:41 AM
To: Sheng-Hui J. Chu <jeffrey.chu@outlook.com>
Cc: gregkh@linuxfoundation.org; johan@kernel.org; linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org; Jeffrey Chu <Jeffrey.chu@cypress.com>
Subject: Re: [PATCH v9] usb: serial: add vid:pid for Cypress WICED dev board
On Fri, Sep 08, 2017 at 09:08:58PM +0000, Sheng-Hui J. Chu wrote:
> From: Jeffrey Chu <jeffrey.chu@cypress.com>
>
> Add CYPRESS_VID vid and CYPRESS_WICED_BT_USB and CYPRESS_WICED_WL_USB
> device IDs to ftdi_sio driver
>
> Signed-off-by: Jeffrey Chu <jeffrey.chu@cypress.com>
I have two v9 of this patch in my mailbox with different authorship and sent five minutes apart. I figured you really wanted this last one applied, but next time make sure to increase the patch revision (e.g.
mark it as v10) to avoid any confusion.
> ---
> drivers/usb/serial/ftdi_sio.c | 2 ++
> drivers/usb/serial/ftdi_sio_ids.h | 7 +++++++
> 2 files changed, 9 insertions(+)
>
> diff --git a/drivers/usb/serial/ftdi_sio.c
> b/drivers/usb/serial/ftdi_sio.c index 1cec037..49d1b2d 100644
> --- a/drivers/usb/serial/ftdi_sio.c
> +++ b/drivers/usb/serial/ftdi_sio.c
> @@ -1015,6 +1015,8 @@ static const struct usb_device_id id_table_combined[] = {
> { USB_DEVICE(WICED_VID, WICED_USB20706V2_PID) },
> { USB_DEVICE(TI_VID, TI_CC3200_LAUNCHPAD_PID),
> .driver_info = (kernel_ulong_t)&ftdi_jtag_quirk },
> +{ USB_DEVICE(CYPRESS_VID, CYPRESS_WICED_BT_USB_PID) },
> +{ USB_DEVICE(CYPRESS_VID, CYPRESS_WICED_WL_USB_PID) },
> { }/* Terminating entry */
> };
>
> diff --git a/drivers/usb/serial/ftdi_sio_ids.h
> b/drivers/usb/serial/ftdi_sio_ids.h
> index 4fcf1ce..d58dc1b 100644
> --- a/drivers/usb/serial/ftdi_sio_ids.h
> +++ b/drivers/usb/serial/ftdi_sio_ids.h
> @@ -692,6 +692,13 @@
> #define WICED_USB20706V2_PID0x6422
>
> /*
> + * Cypress WICED USB UART
> + */
> +#define CYPRESS_VID0x04B4
> +#define CYPRESS_WICED_BT_USB_PID0x009B
> +#define CYPRESS_WICED_WL_USB_PID0xF900
> +
> +/*
> * Definitions for ID TECH (www.idt-net.com) devices
> */
> #define IDTECH_VID0x0ACD/* ID TECH Vendor ID */
I've applied this one now with some minor tweaks (e.g. kept the define sections sorted by VID, and adjusted the commit message slightly).
Thanks,
Johan
This message and any attachments may contain confidential information from Cypress or its subsidiaries. If it has been received in error, please advise the sender and immediately delete this message.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v9] usb: serial: add vid:pid for Cypress WICED dev board
@ 2017-09-08 17:47 Jeffrey Chu
0 siblings, 0 replies; 3+ messages in thread
From: Jeffrey Chu @ 2017-09-08 17:47 UTC (permalink / raw)
To: gregkh, johan, linux-usb, linux-kernel; +Cc: Jeffrey Chu
From: Jeffrey Chu <jeffrey.chu@cypress.com>
Add CYPRESS_VID vid and CYPRESS_WICED_BT_USB and CYPRESS_WICED_WL_USB
device IDs to ftdi_sio driver
Signed-off-by: Jeffrey Chu <jeffrey.chu@cypress.com>
---
drivers/usb/serial/ftdi_sio.c | 2 ++
drivers/usb/serial/ftdi_sio_ids.h | 7 +++++++
2 files changed, 9 insertions(+)
diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c
index 1cec037..49d1b2d 100644
--- a/drivers/usb/serial/ftdi_sio.c
+++ b/drivers/usb/serial/ftdi_sio.c
@@ -1015,6 +1015,8 @@ static const struct usb_device_id id_table_combined[] = {
{ USB_DEVICE(WICED_VID, WICED_USB20706V2_PID) },
{ USB_DEVICE(TI_VID, TI_CC3200_LAUNCHPAD_PID),
.driver_info = (kernel_ulong_t)&ftdi_jtag_quirk },
+ { USB_DEVICE(CYPRESS_VID, CYPRESS_WICED_BT_USB_PID) },
+ { USB_DEVICE(CYPRESS_VID, CYPRESS_WICED_WL_USB_PID) },
{ } /* Terminating entry */
};
diff --git a/drivers/usb/serial/ftdi_sio_ids.h b/drivers/usb/serial/ftdi_sio_ids.h
index 4fcf1ce..d58dc1b 100644
--- a/drivers/usb/serial/ftdi_sio_ids.h
+++ b/drivers/usb/serial/ftdi_sio_ids.h
@@ -692,6 +692,13 @@
#define WICED_USB20706V2_PID 0x6422
/*
+ * Cypress WICED USB UART
+ */
+#define CYPRESS_VID 0x04B4
+#define CYPRESS_WICED_BT_USB_PID 0x009B
+#define CYPRESS_WICED_WL_USB_PID 0xF900
+
+/*
* Definitions for ID TECH (www.idt-net.com) devices
*/
#define IDTECH_VID 0x0ACD /* ID TECH Vendor ID */
--
2.7.4
This message and any attachments may contain confidential information from Cypress or its subsidiaries. If it has been received in error, please advise the sender and immediately delete this message.
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-09-18 16:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <BLUPR11MB0673DEB7AA176C24DFD599A3ED950@BLUPR11MB0673.namprd11.prod.outlook.com>
2017-09-18 8:40 ` [PATCH v9] usb: serial: add vid:pid for Cypress WICED dev board Johan Hovold
2017-09-18 16:58 ` Jeffrey Chu
2017-09-08 17:47 Jeffrey Chu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).