* [PATCH] pinctrl: meson: fix incorrect usage of ENOSYS
@ 2017-09-20 14:08 Jerome Brunet
2017-09-21 12:18 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Jerome Brunet @ 2017-09-20 14:08 UTC (permalink / raw)
To: Linus Walleij, Kevin Hilman, Carlo Caione
Cc: Jerome Brunet, linux-gpio, linux-amlogic, linux-kernel
ENOSYS is special and should only be used for incorrect syscall number.
It is not the case here. let's use ENOTSUPP instead.
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
drivers/pinctrl/meson/pinctrl-meson.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/meson/pinctrl-meson.c b/drivers/pinctrl/meson/pinctrl-meson.c
index c9cd54de0449..71bccb7acbf8 100644
--- a/drivers/pinctrl/meson/pinctrl-meson.c
+++ b/drivers/pinctrl/meson/pinctrl-meson.c
@@ -399,7 +399,7 @@ static int meson_pinconf_group_set(struct pinctrl_dev *pcdev,
static int meson_pinconf_group_get(struct pinctrl_dev *pcdev,
unsigned int group, unsigned long *config)
{
- return -ENOSYS;
+ return -ENOTSUPP;
}
static const struct pinconf_ops meson_pinconf_ops = {
--
2.13.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pinctrl: meson: fix incorrect usage of ENOSYS
2017-09-20 14:08 [PATCH] pinctrl: meson: fix incorrect usage of ENOSYS Jerome Brunet
@ 2017-09-21 12:18 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2017-09-21 12:18 UTC (permalink / raw)
To: Jerome Brunet
Cc: Kevin Hilman, Carlo Caione, linux-gpio,
open list:ARM/Amlogic Meson...,
linux-kernel
On Wed, Sep 20, 2017 at 4:08 PM, Jerome Brunet <jbrunet@baylibre.com> wrote:
> ENOSYS is special and should only be used for incorrect syscall number.
> It is not the case here. let's use ENOTSUPP instead.
>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-21 12:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-20 14:08 [PATCH] pinctrl: meson: fix incorrect usage of ENOSYS Jerome Brunet
2017-09-21 12:18 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).