[PATCH v2 0/2] Fix I2C repeated start timing violation on Armada-38x.

[PATCH v2 0/2] Fix I2C repeated start timing violation on Armada-38x.

[Kalyan Kinthada]

All the Armada 38x(380, 385, 388) have a silicon issue in
the I2C controller which violates the I2C repeated start timing
(errata FE-8471889).

Activate the compatible string "marvell,mv78230-a0-i2c" in the
device tree file of Armada-38x to fx this errata (FE-8471889).

Updated the Documentation for the compatible string
"marvell,mv78230-a0-i2c".

Thank You Gregory Clement for suggesting to reuse the
"marvell,mv78230-a0-i2c" compatible string on Armada-38x SoCs.

Changes since v1:
* "dt-bindings: i2c: Update documentation for "mv78230-a0-i2c""
   Modified commit message.
   Added details describing the compatible string "mv78230-a0-i2c"

-------
Kalyan Kinthada (2):
  ARM: dts: Fix I2C repeated start issue on Armada-38x
  dt-bindings: i2c: Update documentation for "mv78230-a0-i2c"

 Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt | 10 ++++++----
 arch/arm/boot/dts/armada-38x.dtsi                     |  4 ++--
 2 files changed, 8 insertions(+), 6 deletions(-)

-- 
2.14.1

[PATCH v2 1/2] ARM: dts: Fix I2C repeated start issue on Armada-38x

[Kalyan Kinthada]

All the Armada 38x(380, 385, 388) have a silicon issue in
the I2C controller which violates the I2C repeated start timing
(errata FE-8471889).

i2c-mv64xxx driver handles this errata based on the compatible string
"marvell,mv78230-a0-i2c".

This patch activates the "marvell,mv78230-a0-i2c" compatible string
for the I2C controller on armada-38x SoC based devices.

Signed-off-by: Kalyan Kinthada <kalyan.kinthada@alliedtelesis.co.nz>
---
 arch/arm/boot/dts/armada-38x.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/armada-38x.dtsi b/arch/arm/boot/dts/armada-38x.dtsi
index 7ff0811e61db..4960722aab32 100644
--- a/arch/arm/boot/dts/armada-38x.dtsi
+++ b/arch/arm/boot/dts/armada-38x.dtsi
@@ -178,7 +178,7 @@
 			};
 
 			i2c0: i2c@11000 {
-				compatible = "marvell,mv64xxx-i2c";
+				compatible = "marvell,mv78230-a0-i2c", "marvell,mv64xxx-i2c";
 				reg = <0x11000 0x20>;
 				#address-cells = <1>;
 				#size-cells = <0>;
@@ -189,7 +189,7 @@
 			};
 
 			i2c1: i2c@11100 {
-				compatible = "marvell,mv64xxx-i2c";
+				compatible = "marvell,mv78230-a0-i2c", "marvell,mv64xxx-i2c";
 				reg = <0x11100 0x20>;
 				#address-cells = <1>;
 				#size-cells = <0>;
-- 
2.14.1

[PATCH v2 2/2] dt-bindings: i2c: Update documentation for "mv78230-a0-i2c"

[Kalyan Kinthada]

This commit modifies the documentation for
"marvell,mv78230-a0-i2c" compatible string.

The "marvell,mv78230-a0-i2c" compatible string enables the workaround
for an i2c repeated start timing violation, but unlike
"marvell,mv78230-i2c" it disables the i2c offload support. This is
applicable to a number of SoCs such as early revisions of the Armada XP
and the Armada 38x.

Signed-off-by: Kalyan Kinthada <kalyan.kinthada@alliedtelesis.co.nz>
---
 Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt b/Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt
index 5c30026921ae..c6cbab17ed0a 100644
--- a/Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt
+++ b/Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt
@@ -10,10 +10,12 @@ Required properties :
                      - "marvell,mv64xxx-i2c"
                      - "marvell,mv78230-i2c"
                      - "marvell,mv78230-a0-i2c"
-                       * Note: Only use "marvell,mv78230-a0-i2c" for a
-                         very rare, initial version of the SoC which
-                         had broken offload support.  Linux
-                         auto-detects this and sets it appropriately.
+                       * Note: Use "marvell,mv78230-a0-i2c" for
+                         controller which do not support offload
+                         but still have the i2c repeated start
+                         timing violation issue, such as the
+                         ones found in the Armada XP A0 and the
+                         Armada 38x SoCs.
  - interrupts      : The interrupt number
 
 Optional properties :
-- 
2.14.1

Re: [PATCH v2 1/2] ARM: dts: Fix I2C repeated start issue on Armada-38x

[Gregory CLEMENT]

Hi Kalyan,
 
 On ven., sept. 29 2017, Kalyan Kinthada <kalyan.kinthada@alliedtelesis.co.nz> wrote:

> All the Armada 38x(380, 385, 388) have a silicon issue in
> the I2C controller which violates the I2C repeated start timing
> (errata FE-8471889).
>
> i2c-mv64xxx driver handles this errata based on the compatible string
> "marvell,mv78230-a0-i2c".
>
> This patch activates the "marvell,mv78230-a0-i2c" compatible string
> for the I2C controller on armada-38x SoC based devices.
>
> Signed-off-by: Kalyan Kinthada <kalyan.kinthada@alliedtelesis.co.nz>

Applied on mvebu/fixes

Thanks,

Gregory

> ---
>  arch/arm/boot/dts/armada-38x.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/armada-38x.dtsi b/arch/arm/boot/dts/armada-38x.dtsi
> index 7ff0811e61db..4960722aab32 100644
> --- a/arch/arm/boot/dts/armada-38x.dtsi
> +++ b/arch/arm/boot/dts/armada-38x.dtsi
> @@ -178,7 +178,7 @@
>  			};
>  
>  			i2c0: i2c@11000 {
> -				compatible = "marvell,mv64xxx-i2c";
> +				compatible = "marvell,mv78230-a0-i2c", "marvell,mv64xxx-i2c";
>  				reg = <0x11000 0x20>;
>  				#address-cells = <1>;
>  				#size-cells = <0>;
> @@ -189,7 +189,7 @@
>  			};
>  
>  			i2c1: i2c@11100 {
> -				compatible = "marvell,mv64xxx-i2c";
> +				compatible = "marvell,mv78230-a0-i2c", "marvell,mv64xxx-i2c";
>  				reg = <0x11100 0x20>;
>  				#address-cells = <1>;
>  				#size-cells = <0>;
> -- 
> 2.14.1
>

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

Re: [PATCH v2 2/2] dt-bindings: i2c: Update documentation for "mv78230-a0-i2c"

[Gregory CLEMENT]

Hi Wolfram,
 
 On ven., sept. 29 2017, Kalyan Kinthada <kalyan.kinthada@alliedtelesis.co.nz> wrote:

> This commit modifies the documentation for
> "marvell,mv78230-a0-i2c" compatible string.
>
> The "marvell,mv78230-a0-i2c" compatible string enables the workaround
> for an i2c repeated start timing violation, but unlike
> "marvell,mv78230-i2c" it disables the i2c offload support. This is
> applicable to a number of SoCs such as early revisions of the Armada XP
> and the Armada 38x.
>
> Signed-off-by: Kalyan Kinthada <kalyan.kinthada@alliedtelesis.co.nz>


I applied the dt fix on my mvebu/fixes branch. Do you want to apply this
one on your branch, or do you prefer I take it. In this case an acked-by
would be nice.

Thanks,

Gregory


> ---
>  Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt b/Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt
> index 5c30026921ae..c6cbab17ed0a 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt
> @@ -10,10 +10,12 @@ Required properties :
>                       - "marvell,mv64xxx-i2c"
>                       - "marvell,mv78230-i2c"
>                       - "marvell,mv78230-a0-i2c"
> -                       * Note: Only use "marvell,mv78230-a0-i2c" for a
> -                         very rare, initial version of the SoC which
> -                         had broken offload support.  Linux
> -                         auto-detects this and sets it appropriately.
> +                       * Note: Use "marvell,mv78230-a0-i2c" for
> +                         controller which do not support offload
> +                         but still have the i2c repeated start
> +                         timing violation issue, such as the
> +                         ones found in the Armada XP A0 and the
> +                         Armada 38x SoCs.
>   - interrupts      : The interrupt number
>  
>  Optional properties :
> -- 
> 2.14.1
>

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

Re: [PATCH v2 2/2] dt-bindings: i2c: Update documentation for "mv78230-a0-i2c"

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 1002 bytes --]

On Mon, Oct 02, 2017 at 04:23:43PM +0200, Gregory CLEMENT wrote:
> Hi Wolfram,
>  
>  On ven., sept. 29 2017, Kalyan Kinthada <kalyan.kinthada@alliedtelesis.co.nz> wrote:
> 
> > This commit modifies the documentation for
> > "marvell,mv78230-a0-i2c" compatible string.
> >
> > The "marvell,mv78230-a0-i2c" compatible string enables the workaround
> > for an i2c repeated start timing violation, but unlike
> > "marvell,mv78230-i2c" it disables the i2c offload support. This is
> > applicable to a number of SoCs such as early revisions of the Armada XP
> > and the Armada 38x.
> >
> > Signed-off-by: Kalyan Kinthada <kalyan.kinthada@alliedtelesis.co.nz>
> 
> 
> I applied the dt fix on my mvebu/fixes branch. Do you want to apply this
> one on your branch, or do you prefer I take it. In this case an acked-by
> would be nice.

I'd prefer to take it. What I'd really like to see here is an ack from
Rob because of the previous discussion of an earlier revision of this
patch.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH v2 2/2] dt-bindings: i2c: Update documentation for "mv78230-a0-i2c"

[Rob Herring]

On Thu, Oct 05, 2017 at 01:08:20PM +0200, Wolfram Sang wrote:
> On Mon, Oct 02, 2017 at 04:23:43PM +0200, Gregory CLEMENT wrote:
> > Hi Wolfram,
> >  
> >  On ven., sept. 29 2017, Kalyan Kinthada <kalyan.kinthada@alliedtelesis.co.nz> wrote:
> > 
> > > This commit modifies the documentation for
> > > "marvell,mv78230-a0-i2c" compatible string.
> > >
> > > The "marvell,mv78230-a0-i2c" compatible string enables the workaround
> > > for an i2c repeated start timing violation, but unlike
> > > "marvell,mv78230-i2c" it disables the i2c offload support. This is
> > > applicable to a number of SoCs such as early revisions of the Armada XP
> > > and the Armada 38x.
> > >
> > > Signed-off-by: Kalyan Kinthada <kalyan.kinthada@alliedtelesis.co.nz>
> > 
> > 
> > I applied the dt fix on my mvebu/fixes branch. Do you want to apply this
> > one on your branch, or do you prefer I take it. In this case an acked-by
> > would be nice.
> 
> I'd prefer to take it. What I'd really like to see here is an ack from
> Rob because of the previous discussion of an earlier revision of this
> patch.

I'm confused how mv78230 relates to Armada XP or 38x... I don't really 
want to know either. If normal compatible string conventions were 
followed then I wouldn't have to.

Rob

Re: [PATCH v2 2/2] dt-bindings: i2c: Update documentation for "mv78230-a0-i2c"

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 1468 bytes --]

On Thu, Oct 05, 2017 at 06:29:53PM -0500, Rob Herring wrote:
> On Thu, Oct 05, 2017 at 01:08:20PM +0200, Wolfram Sang wrote:
> > On Mon, Oct 02, 2017 at 04:23:43PM +0200, Gregory CLEMENT wrote:
> > > Hi Wolfram,
> > >  
> > >  On ven., sept. 29 2017, Kalyan Kinthada <kalyan.kinthada@alliedtelesis.co.nz> wrote:
> > > 
> > > > This commit modifies the documentation for
> > > > "marvell,mv78230-a0-i2c" compatible string.
> > > >
> > > > The "marvell,mv78230-a0-i2c" compatible string enables the workaround
> > > > for an i2c repeated start timing violation, but unlike
> > > > "marvell,mv78230-i2c" it disables the i2c offload support. This is
> > > > applicable to a number of SoCs such as early revisions of the Armada XP
> > > > and the Armada 38x.
> > > >
> > > > Signed-off-by: Kalyan Kinthada <kalyan.kinthada@alliedtelesis.co.nz>
> > > 
> > > 
> > > I applied the dt fix on my mvebu/fixes branch. Do you want to apply this
> > > one on your branch, or do you prefer I take it. In this case an acked-by
> > > would be nice.
> > 
> > I'd prefer to take it. What I'd really like to see here is an ack from
> > Rob because of the previous discussion of an earlier revision of this
> > patch.
> 
> I'm confused how mv78230 relates to Armada XP or 38x... I don't really 
> want to know either. If normal compatible string conventions were 
> followed then I wouldn't have to.

Is this a NAK or "annoyed, but don't really care"? ;)


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]