* [PATCH] USB: serial: qcserial: add Dell DW5818, DW5819
@ 2017-09-29 4:39 Shrirang Bagul
2017-10-03 13:37 ` Johan Hovold
0 siblings, 1 reply; 4+ messages in thread
From: Shrirang Bagul @ 2017-09-29 4:39 UTC (permalink / raw)
To: johan; +Cc: linux-usb, linux-kernel
Dell Wireless 5819/5818 devices are re-branded Sierra Wireless MC74
series which will by default boot with vid 0x413c and pid's 0x81cf,
0x81d0, 0x81d1,0x81d2.
Signed-off-by: Shrirang Bagul <shrirang.bagul@canonical.com>
---
drivers/usb/serial/qcserial.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/usb/serial/qcserial.c b/drivers/usb/serial/qcserial.c
index ebc0beea69d6..eb9928963a53 100644
--- a/drivers/usb/serial/qcserial.c
+++ b/drivers/usb/serial/qcserial.c
@@ -174,6 +174,10 @@ static const struct usb_device_id id_table[] = {
{DEVICE_SWI(0x413c, 0x81b3)}, /* Dell Wireless 5809e Gobi(TM) 4G LTE Mobile Broadband Card (rev3) */
{DEVICE_SWI(0x413c, 0x81b5)}, /* Dell Wireless 5811e QDL */
{DEVICE_SWI(0x413c, 0x81b6)}, /* Dell Wireless 5811e QDL */
+ {DEVICE_SWI(0x413c, 0x81cf)}, /* Dell Wireless 5819 */
+ {DEVICE_SWI(0x413c, 0x81d0)}, /* Dell Wireless 5819 */
+ {DEVICE_SWI(0x413c, 0x81d1)}, /* Dell Wireless 5818 */
+ {DEVICE_SWI(0x413c, 0x81d2)}, /* Dell Wireless 5818 */
/* Huawei devices */
{DEVICE_HWI(0x03f0, 0x581d)}, /* HP lt4112 LTE/HSPA+ Gobi 4G Modem (Huawei me906e) */
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] USB: serial: qcserial: add Dell DW5818, DW5819
2017-09-29 4:39 [PATCH] USB: serial: qcserial: add Dell DW5818, DW5819 Shrirang Bagul
@ 2017-10-03 13:37 ` Johan Hovold
2017-10-05 3:41 ` Shrirang Bagul
0 siblings, 1 reply; 4+ messages in thread
From: Johan Hovold @ 2017-10-03 13:37 UTC (permalink / raw)
To: Shrirang Bagul; +Cc: johan, linux-usb, linux-kernel, Bjørn Mork
On Fri, Sep 29, 2017 at 12:39:51PM +0800, Shrirang Bagul wrote:
> Dell Wireless 5819/5818 devices are re-branded Sierra Wireless MC74
> series which will by default boot with vid 0x413c and pid's 0x81cf,
> 0x81d0, 0x81d1,0x81d2.
>
> Signed-off-by: Shrirang Bagul <shrirang.bagul@canonical.com>
Now applied.
Don't you want to add these to qmi_wwan as well?
> ---
> drivers/usb/serial/qcserial.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/usb/serial/qcserial.c b/drivers/usb/serial/qcserial.c
> index ebc0beea69d6..eb9928963a53 100644
> --- a/drivers/usb/serial/qcserial.c
> +++ b/drivers/usb/serial/qcserial.c
> @@ -174,6 +174,10 @@ static const struct usb_device_id id_table[] = {
> {DEVICE_SWI(0x413c, 0x81b3)}, /* Dell Wireless 5809e Gobi(TM) 4G LTE Mobile Broadband Card (rev3) */
> {DEVICE_SWI(0x413c, 0x81b5)}, /* Dell Wireless 5811e QDL */
> {DEVICE_SWI(0x413c, 0x81b6)}, /* Dell Wireless 5811e QDL */
> + {DEVICE_SWI(0x413c, 0x81cf)}, /* Dell Wireless 5819 */
> + {DEVICE_SWI(0x413c, 0x81d0)}, /* Dell Wireless 5819 */
> + {DEVICE_SWI(0x413c, 0x81d1)}, /* Dell Wireless 5818 */
> + {DEVICE_SWI(0x413c, 0x81d2)}, /* Dell Wireless 5818 */
>
> /* Huawei devices */
> {DEVICE_HWI(0x03f0, 0x581d)}, /* HP lt4112 LTE/HSPA+ Gobi 4G Modem (Huawei me906e) */
Thanks,
Johan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] USB: serial: qcserial: add Dell DW5818, DW5819
2017-10-03 13:37 ` Johan Hovold
@ 2017-10-05 3:41 ` Shrirang Bagul
2017-10-05 5:21 ` Bjørn Mork
0 siblings, 1 reply; 4+ messages in thread
From: Shrirang Bagul @ 2017-10-05 3:41 UTC (permalink / raw)
To: Johan Hovold; +Cc: linux-usb, linux-kernel, Bjørn Mork
On Tue, 2017-10-03 at 15:37 +0200, Johan Hovold wrote:
> On Fri, Sep 29, 2017 at 12:39:51PM +0800, Shrirang Bagul wrote:
> > Dell Wireless 5819/5818 devices are re-branded Sierra Wireless MC74
> > series which will by default boot with vid 0x413c and pid's 0x81cf,
> > 0x81d0, 0x81d1,0x81d2.
> >
> > Signed-off-by: Shrirang Bagul <shrirang.bagul@canonical.com>
>
> Now applied.
Thank you.
>
> Don't you want to add these to qmi_wwan as well?
I haven't tested these devices with qmi_wwan. Perhaps a separate patch once it's
verified.
>
> > ---
> > drivers/usb/serial/qcserial.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/usb/serial/qcserial.c b/drivers/usb/serial/qcserial.c
> > index ebc0beea69d6..eb9928963a53 100644
> > --- a/drivers/usb/serial/qcserial.c
> > +++ b/drivers/usb/serial/qcserial.c
> > @@ -174,6 +174,10 @@ static const struct usb_device_id id_table[] = {
> > {DEVICE_SWI(0x413c, 0x81b3)}, /* Dell Wireless 5809e Gobi(TM) 4G
> > LTE Mobile Broadband Card (rev3) */
> > {DEVICE_SWI(0x413c, 0x81b5)}, /* Dell Wireless 5811e QDL */
> > {DEVICE_SWI(0x413c, 0x81b6)}, /* Dell Wireless 5811e QDL */
> > + {DEVICE_SWI(0x413c, 0x81cf)}, /* Dell Wireless 5819 */
> > + {DEVICE_SWI(0x413c, 0x81d0)}, /* Dell Wireless 5819 */
> > + {DEVICE_SWI(0x413c, 0x81d1)}, /* Dell Wireless 5818 */
> > + {DEVICE_SWI(0x413c, 0x81d2)}, /* Dell Wireless 5818 */
> >
> > /* Huawei devices */
> > {DEVICE_HWI(0x03f0, 0x581d)}, /* HP lt4112 LTE/HSPA+ Gobi 4G
> > Modem (Huawei me906e) */
>
> Thanks,
> Johan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] USB: serial: qcserial: add Dell DW5818, DW5819
2017-10-05 3:41 ` Shrirang Bagul
@ 2017-10-05 5:21 ` Bjørn Mork
0 siblings, 0 replies; 4+ messages in thread
From: Bjørn Mork @ 2017-10-05 5:21 UTC (permalink / raw)
To: Shrirang Bagul; +Cc: Johan Hovold, linux-usb, linux-kernel
Shrirang Bagul <shrirang.bagul@canonical.com> writes:
> On Tue, 2017-10-03 at 15:37 +0200, Johan Hovold wrote:
>
>> Don't you want to add these to qmi_wwan as well?
>
> I haven't tested these devices with qmi_wwan. Perhaps a separate patch once it's
> verified.
Please do, if you can. I realize that QMI isn't a default config for
these modems, but it's always good to have the driver support in case
some user wants to switch configs.
Note that they most likely support two "RMNET" interfaces, so two
entries will be necessary to make the support complete.
Bjørn
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-10-05 5:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-29 4:39 [PATCH] USB: serial: qcserial: add Dell DW5818, DW5819 Shrirang Bagul
2017-10-03 13:37 ` Johan Hovold
2017-10-05 3:41 ` Shrirang Bagul
2017-10-05 5:21 ` Bjørn Mork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).