linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/3] arm/xen: don't inclide rwlock.h directly.
@ 2017-10-05 12:56 Sebastian Andrzej Siewior
  2017-10-05 12:56 ` [PATCH 2/3] greybus: audio: " Sebastian Andrzej Siewior
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Sebastian Andrzej Siewior @ 2017-10-05 12:56 UTC (permalink / raw)
  To: linux-kernel
  Cc: tglx, Sebastian Andrzej Siewior, Stefano Stabellini, xen-devel,
	linux-arm-kernel

rwlock.h should not be included directly. Instead linux/splinlock.h
should be included. One thing it does is to break the RT build.

Cc: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org
Cc: linux-arm-kernel@lists.infradead.org
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
 arch/arm/xen/p2m.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/xen/p2m.c b/arch/arm/xen/p2m.c
index e71eefa2e427..0641ba54ab62 100644
--- a/arch/arm/xen/p2m.c
+++ b/arch/arm/xen/p2m.c
@@ -1,7 +1,7 @@
 #include <linux/bootmem.h>
 #include <linux/gfp.h>
 #include <linux/export.h>
-#include <linux/rwlock.h>
+#include <linux/spinlock.h>
 #include <linux/slab.h>
 #include <linux/types.h>
 #include <linux/dma-mapping.h>
-- 
2.14.2

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH 2/3] greybus: audio: don't inclide rwlock.h directly.
  2017-10-05 12:56 [PATCH 1/3] arm/xen: don't inclide rwlock.h directly Sebastian Andrzej Siewior
@ 2017-10-05 12:56 ` Sebastian Andrzej Siewior
  2017-10-05 15:17   ` Mark Greer
  2017-10-05 12:56 ` [PATCH 3/3] xen/9pfs: " Sebastian Andrzej Siewior
  2017-10-05 19:58 ` [PATCH 1/3] arm/xen: don't inclide rwlock.h directly.1~B Stefano Stabellini
  2 siblings, 1 reply; 7+ messages in thread
From: Sebastian Andrzej Siewior @ 2017-10-05 12:56 UTC (permalink / raw)
  To: linux-kernel
  Cc: tglx, Sebastian Andrzej Siewior, Vaibhav Agarwal, Mark Greer,
	Johan Hovold, Alex Elder, Greg Kroah-Hartman, greybus-dev, devel

rwlock.h should not be included directly. Instead linux/splinlock.h
should be included. One thing it does is to break the RT build.

Cc: Vaibhav Agarwal <vaibhav.sr@gmail.com>
Cc: Mark Greer <mgreer@animalcreek.com>
Cc: Johan Hovold <johan@kernel.org>
Cc: Alex Elder <elder@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: greybus-dev@lists.linaro.org
Cc: devel@driverdev.osuosl.org
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
 drivers/staging/greybus/audio_manager.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/greybus/audio_manager.c b/drivers/staging/greybus/audio_manager.c
index aa6508b44fab..045696ce85c7 100644
--- a/drivers/staging/greybus/audio_manager.c
+++ b/drivers/staging/greybus/audio_manager.c
@@ -10,7 +10,7 @@
 #include <linux/sysfs.h>
 #include <linux/module.h>
 #include <linux/init.h>
-#include <linux/rwlock.h>
+#include <linux/spinlock.h>
 #include <linux/idr.h>
 
 #include "audio_manager.h"
-- 
2.14.2

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH 3/3] xen/9pfs: don't inclide rwlock.h directly.
  2017-10-05 12:56 [PATCH 1/3] arm/xen: don't inclide rwlock.h directly Sebastian Andrzej Siewior
  2017-10-05 12:56 ` [PATCH 2/3] greybus: audio: " Sebastian Andrzej Siewior
@ 2017-10-05 12:56 ` Sebastian Andrzej Siewior
  2017-10-05 19:58 ` [PATCH 1/3] arm/xen: don't inclide rwlock.h directly.1~B Stefano Stabellini
  2 siblings, 0 replies; 7+ messages in thread
From: Sebastian Andrzej Siewior @ 2017-10-05 12:56 UTC (permalink / raw)
  To: linux-kernel
  Cc: tglx, Sebastian Andrzej Siewior, Eric Van Hensbergen,
	Ron Minnich, Latchesar Ionkov, David S. Miller, v9fs-developer,
	netdev

rwlock.h should not be included directly. Instead linux/splinlock.h
should be included. One thing it does is to break the RT build.

Cc: Eric Van Hensbergen <ericvh@gmail.com>
Cc: Ron Minnich <rminnich@sandia.gov>
Cc: Latchesar Ionkov <lucho@ionkov.net>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: v9fs-developer@lists.sourceforge.net
Cc: netdev@vger.kernel.org
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
 net/9p/trans_xen.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/net/9p/trans_xen.c b/net/9p/trans_xen.c
index 6ad3e043c617..02c6c467a99c 100644
--- a/net/9p/trans_xen.c
+++ b/net/9p/trans_xen.c
@@ -38,7 +38,6 @@
 
 #include <linux/module.h>
 #include <linux/spinlock.h>
-#include <linux/rwlock.h>
 #include <net/9p/9p.h>
 #include <net/9p/client.h>
 #include <net/9p/transport.h>
-- 
2.14.2

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH 2/3] greybus: audio: don't inclide rwlock.h directly.
  2017-10-05 12:56 ` [PATCH 2/3] greybus: audio: " Sebastian Andrzej Siewior
@ 2017-10-05 15:17   ` Mark Greer
  0 siblings, 0 replies; 7+ messages in thread
From: Mark Greer @ 2017-10-05 15:17 UTC (permalink / raw)
  To: Sebastian Andrzej Siewior
  Cc: linux-kernel, tglx, Vaibhav Agarwal, Mark Greer, Johan Hovold,
	Alex Elder, Greg Kroah-Hartman, greybus-dev, devel

On Thu, Oct 05, 2017 at 02:56:54PM +0200, Sebastian Andrzej Siewior wrote:
> rwlock.h should not be included directly. Instead linux/splinlock.h
> should be included. One thing it does is to break the RT build.
> 
> Cc: Vaibhav Agarwal <vaibhav.sr@gmail.com>
> Cc: Mark Greer <mgreer@animalcreek.com>
> Cc: Johan Hovold <johan@kernel.org>
> Cc: Alex Elder <elder@kernel.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: greybus-dev@lists.linaro.org
> Cc: devel@driverdev.osuosl.org
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> ---
>  drivers/staging/greybus/audio_manager.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/greybus/audio_manager.c b/drivers/staging/greybus/audio_manager.c
> index aa6508b44fab..045696ce85c7 100644
> --- a/drivers/staging/greybus/audio_manager.c
> +++ b/drivers/staging/greybus/audio_manager.c
> @@ -10,7 +10,7 @@
>  #include <linux/sysfs.h>
>  #include <linux/module.h>
>  #include <linux/init.h>
> -#include <linux/rwlock.h>
> +#include <linux/spinlock.h>
>  #include <linux/idr.h>
>  
>  #include "audio_manager.h"
> -- 
> 2.14.2

Thanks for the patch.

Reviewed-by: Mark Greer <mgreer@animalcreek.com>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/3] arm/xen: don't inclide rwlock.h directly.1~B
  2017-10-05 12:56 [PATCH 1/3] arm/xen: don't inclide rwlock.h directly Sebastian Andrzej Siewior
  2017-10-05 12:56 ` [PATCH 2/3] greybus: audio: " Sebastian Andrzej Siewior
  2017-10-05 12:56 ` [PATCH 3/3] xen/9pfs: " Sebastian Andrzej Siewior
@ 2017-10-05 19:58 ` Stefano Stabellini
  2017-10-05 21:32   ` Sebastian Andrzej Siewior
  2017-10-26 22:56   ` [Xen-devel] " Boris Ostrovsky
  2 siblings, 2 replies; 7+ messages in thread
From: Stefano Stabellini @ 2017-10-05 19:58 UTC (permalink / raw)
  To: Sebastian Andrzej Siewior
  Cc: linux-kernel, tglx, Stefano Stabellini, xen-devel, linux-arm-kernel

On Thu, 5 Oct 2017, Sebastian Andrzej Siewior wrote:
> rwlock.h should not be included directly. Instead linux/splinlock.h
> should be included. One thing it does is to break the RT build.
> 
> Cc: Stefano Stabellini <sstabellini@kernel.org>
> Cc: xen-devel@lists.xenproject.org
> Cc: linux-arm-kernel@lists.infradead.org
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>

Let me know if you want this patch to go via the xen tree.

> ---
>  arch/arm/xen/p2m.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/xen/p2m.c b/arch/arm/xen/p2m.c
> index e71eefa2e427..0641ba54ab62 100644
> --- a/arch/arm/xen/p2m.c
> +++ b/arch/arm/xen/p2m.c
> @@ -1,7 +1,7 @@
>  #include <linux/bootmem.h>
>  #include <linux/gfp.h>
>  #include <linux/export.h>
> -#include <linux/rwlock.h>
> +#include <linux/spinlock.h>
>  #include <linux/slab.h>
>  #include <linux/types.h>
>  #include <linux/dma-mapping.h>
> -- 
> 2.14.2
> 

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/3] arm/xen: don't inclide rwlock.h directly.1~B
  2017-10-05 19:58 ` [PATCH 1/3] arm/xen: don't inclide rwlock.h directly.1~B Stefano Stabellini
@ 2017-10-05 21:32   ` Sebastian Andrzej Siewior
  2017-10-26 22:56   ` [Xen-devel] " Boris Ostrovsky
  1 sibling, 0 replies; 7+ messages in thread
From: Sebastian Andrzej Siewior @ 2017-10-05 21:32 UTC (permalink / raw)
  To: Stefano Stabellini; +Cc: linux-kernel, tglx, xen-devel, linux-arm-kernel

On 2017-10-05 12:58:32 [-0700], Stefano Stabellini wrote:
> Let me know if you want this patch to go via the xen tree.
Yes, please.

Sebastian

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [Xen-devel] [PATCH 1/3] arm/xen: don't inclide rwlock.h directly.1~B
  2017-10-05 19:58 ` [PATCH 1/3] arm/xen: don't inclide rwlock.h directly.1~B Stefano Stabellini
  2017-10-05 21:32   ` Sebastian Andrzej Siewior
@ 2017-10-26 22:56   ` Boris Ostrovsky
  1 sibling, 0 replies; 7+ messages in thread
From: Boris Ostrovsky @ 2017-10-26 22:56 UTC (permalink / raw)
  To: Stefano Stabellini, Sebastian Andrzej Siewior
  Cc: xen-devel, tglx, linux-kernel, linux-arm-kernel

On 10/05/2017 03:58 PM, Stefano Stabellini wrote:
> On Thu, 5 Oct 2017, Sebastian Andrzej Siewior wrote:
>> rwlock.h should not be included directly. Instead linux/splinlock.h
>> should be included. One thing it does is to break the RT build.
>>
>> Cc: Stefano Stabellini <sstabellini@kernel.org>
>> Cc: xen-devel@lists.xenproject.org
>> Cc: linux-arm-kernel@lists.infradead.org
>> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>


Applied to for-linus-4.14c.

-boris

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2017-10-26 22:55 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-05 12:56 [PATCH 1/3] arm/xen: don't inclide rwlock.h directly Sebastian Andrzej Siewior
2017-10-05 12:56 ` [PATCH 2/3] greybus: audio: " Sebastian Andrzej Siewior
2017-10-05 15:17   ` Mark Greer
2017-10-05 12:56 ` [PATCH 3/3] xen/9pfs: " Sebastian Andrzej Siewior
2017-10-05 19:58 ` [PATCH 1/3] arm/xen: don't inclide rwlock.h directly.1~B Stefano Stabellini
2017-10-05 21:32   ` Sebastian Andrzej Siewior
2017-10-26 22:56   ` [Xen-devel] " Boris Ostrovsky

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).