* [PATCH v2] ASoC: Intel: Skylake: Decrease loglevel for topology loading
@ 2017-10-12 16:44 Chintan Patel
2017-10-16 6:05 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Chintan Patel @ 2017-10-12 16:44 UTC (permalink / raw)
Cc: vinod.koul, Chintan Patel, Liam Girdwood, Mark Brown,
Jaroslav Kysela, Takashi Iwai, Jeeja KP, guneshwor.o.singh,
Shreyas NC, Takashi Sakamoto, Ramesh Babu, Dharageswari R,
alsa-devel, linux-kernel
In case of failure in loading customize topology firmware, dfw_sst.bin
gets loaded. However, current log provides this message as error even
after successfully falling back to default topology "dfw_sst.bin".
Hence to convey proper message, changing log level and message.
Signed-off-by: Chintan Patel <chintan.m.patel@intel.com>
---
Changes in v2:
Addressing review comments from Takashi Iwai by changing
loglevel as info
sound/soc/intel/skylake/skl-topology.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/intel/skylake/skl-topology.c b/sound/soc/intel/skylake/skl-topology.c
index 22f768ca3c73..12f383fd7c39 100644
--- a/sound/soc/intel/skylake/skl-topology.c
+++ b/sound/soc/intel/skylake/skl-topology.c
@@ -3404,7 +3404,7 @@ int skl_tplg_init(struct snd_soc_platform *platform, struct hdac_ext_bus *ebus)
ret = request_firmware(&fw, skl->tplg_name, bus->dev);
if (ret < 0) {
- dev_err(bus->dev, "tplg fw %s load failed with %d\n",
+ dev_info(bus->dev, "tplg fw %s load failed with %d, falling back to dfw_sst.bin",
skl->tplg_name, ret);
ret = request_firmware(&fw, "dfw_sst.bin", bus->dev);
if (ret < 0) {
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] ASoC: Intel: Skylake: Decrease loglevel for topology loading
2017-10-12 16:44 [PATCH v2] ASoC: Intel: Skylake: Decrease loglevel for topology loading Chintan Patel
@ 2017-10-16 6:05 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2017-10-16 6:05 UTC (permalink / raw)
To: Chintan Patel
Cc: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
Jeeja KP, guneshwor.o.singh, Shreyas NC, Takashi Sakamoto,
Ramesh Babu, Dharageswari R, alsa-devel, linux-kernel
On Thu, Oct 12, 2017 at 09:44:37AM -0700, Chintan Patel wrote:
> In case of failure in loading customize topology firmware, dfw_sst.bin
> gets loaded. However, current log provides this message as error even
> after successfully falling back to default topology "dfw_sst.bin".
>
> Hence to convey proper message, changing log level and message.
Acked-By: Vinod Koul <vinod.koul@intel.com>
> Signed-off-by: Chintan Patel <chintan.m.patel@intel.com>
> ---
> Changes in v2:
> Addressing review comments from Takashi Iwai by changing
> loglevel as info
>
> sound/soc/intel/skylake/skl-topology.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/intel/skylake/skl-topology.c b/sound/soc/intel/skylake/skl-topology.c
> index 22f768ca3c73..12f383fd7c39 100644
> --- a/sound/soc/intel/skylake/skl-topology.c
> +++ b/sound/soc/intel/skylake/skl-topology.c
> @@ -3404,7 +3404,7 @@ int skl_tplg_init(struct snd_soc_platform *platform, struct hdac_ext_bus *ebus)
>
> ret = request_firmware(&fw, skl->tplg_name, bus->dev);
> if (ret < 0) {
> - dev_err(bus->dev, "tplg fw %s load failed with %d\n",
> + dev_info(bus->dev, "tplg fw %s load failed with %d, falling back to dfw_sst.bin",
> skl->tplg_name, ret);
> ret = request_firmware(&fw, "dfw_sst.bin", bus->dev);
> if (ret < 0) {
> --
> 1.9.1
>
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-16 6:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-12 16:44 [PATCH v2] ASoC: Intel: Skylake: Decrease loglevel for topology loading Chintan Patel
2017-10-16 6:05 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).