From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 1/2] perf, tools: Enable type checking for perf_evsel_config_term types
Date: Tue, 24 Oct 2017 09:38:49 +0200 [thread overview]
Message-ID: <20171024073849.GA31772@krava> (raw)
In-Reply-To: <20171020202755.21410-1-andi@firstfloor.org>
On Fri, Oct 20, 2017 at 01:27:54PM -0700, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
>
> Use a typed enum for the perf_evsel_config_term type enum.
> This allows gcc to do much stronger type checks, and also
> check for missing case statements.
>
> I removed the unused _MAX member from the number.
>
> It found one missing case. I'm not sure it's a real problem,
> so I just turned it into a BUG_ON for now.
>
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
> ---
> tools/perf/util/evsel.c | 2 ++
> tools/perf/util/evsel.h | 5 ++---
> 2 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
> index f894893c203d..d1f63b93bf69 100644
> --- a/tools/perf/util/evsel.c
> +++ b/tools/perf/util/evsel.c
> @@ -775,6 +775,8 @@ static void apply_config_terms(struct perf_evsel *evsel,
> case PERF_EVSEL__CONFIG_TERM_OVERWRITE:
> attr->write_backward = term->val.overwrite ? 1 : 0;
> break;
> + case PERF_EVSEL__CONFIG_TERM_DRV_CFG:
> + BUG_ON(1);
> default:
> break;
> }
> diff --git a/tools/perf/util/evsel.h b/tools/perf/util/evsel.h
> index db658785d828..6728d8d6e513 100644
> --- a/tools/perf/util/evsel.h
> +++ b/tools/perf/util/evsel.h
> @@ -37,7 +37,7 @@ struct cgroup_sel;
> * It is allocated within event parsing and attached to
> * perf_evsel::config_terms list head.
> */
> -enum {
> +enum period_type {
seems ok, but I'm puzzled with the 'period_type' name
I think it should be more like 'term_type' or something
jirka
> PERF_EVSEL__CONFIG_TERM_PERIOD,
> PERF_EVSEL__CONFIG_TERM_FREQ,
> PERF_EVSEL__CONFIG_TERM_TIME,
> @@ -48,12 +48,11 @@ enum {
> PERF_EVSEL__CONFIG_TERM_OVERWRITE,
> PERF_EVSEL__CONFIG_TERM_DRV_CFG,
> PERF_EVSEL__CONFIG_TERM_BRANCH,
> - PERF_EVSEL__CONFIG_TERM_MAX,
> };
>
> struct perf_evsel_config_term {
> struct list_head list;
> - int type;
> + enum period_type type;
> union {
> u64 period;
> u64 freq;
> --
> 2.13.6
>
next prev parent reply other threads:[~2017-10-24 7:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-20 20:27 [PATCH 1/2] perf, tools: Enable type checking for perf_evsel_config_term types Andi Kleen
2017-10-20 20:27 ` [PATCH 2/2] perf, tools, record: Fix -c/-F options for cpu event aliases Andi Kleen
2017-10-24 7:39 ` Jiri Olsa
2017-11-18 8:25 ` [tip:perf/core] perf " tip-bot for Andi Kleen
2017-11-29 6:28 ` tip-bot for Andi Kleen
2017-10-24 7:38 ` Jiri Olsa [this message]
2017-11-08 15:40 ` [PATCH 1/2] perf, tools: Enable type checking for perf_evsel_config_term types Arnaldo Carvalho de Melo
2017-11-18 8:25 ` [tip:perf/core] perf evsel: " tip-bot for Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171024073849.GA31772@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).