From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Colin King <colin.king@canonical.com>
Cc: linux-xfs@vger.kernel.org, Brian Foster <bfoster@redhat.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xfs: remove redundant assignment to variable bit
Date: Tue, 31 Oct 2017 09:55:52 -0700 [thread overview]
Message-ID: <20171031165552.GD4911@magnolia> (raw)
In-Reply-To: <20171031111350.21208-1-colin.king@canonical.com>
On Tue, Oct 31, 2017 at 11:13:50AM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable bit is being assigned a value that is never read, hence
> the assignment is redundant and can be removed. Cleans up clang
> warning:
>
> fs/xfs/libxfs/xfs_rtbitmap.c:675:3: warning: Value stored to
> 'bit' is never read
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> fs/xfs/libxfs/xfs_rtbitmap.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/xfs/libxfs/xfs_rtbitmap.c b/fs/xfs/libxfs/xfs_rtbitmap.c
> index 5d4e43ef4eea..ac09c4333485 100644
> --- a/fs/xfs/libxfs/xfs_rtbitmap.c
> +++ b/fs/xfs/libxfs/xfs_rtbitmap.c
> @@ -672,7 +672,6 @@ xfs_rtmodify_range(
> /*
> * Compute a mask of relevant bits.
> */
> - bit = 0;
> mask = ((xfs_rtword_t)1 << lastbit) - 1;
> /*
> * Set/clear the active bits.
> --
> 2.14.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2017-10-31 16:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-31 11:13 [PATCH] xfs: remove redundant assignment to variable bit Colin King
2017-10-31 16:55 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171031165552.GD4911@magnolia \
--to=darrick.wong@oracle.com \
--cc=bfoster@redhat.com \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).