* [PATCH] xfs: remove redundant assignment to variable bit
@ 2017-10-31 11:13 Colin King
2017-10-31 16:55 ` Darrick J. Wong
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2017-10-31 11:13 UTC (permalink / raw)
To: Darrick J . Wong, linux-xfs, Brian Foster; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Variable bit is being assigned a value that is never read, hence
the assignment is redundant and can be removed. Cleans up clang
warning:
fs/xfs/libxfs/xfs_rtbitmap.c:675:3: warning: Value stored to
'bit' is never read
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
fs/xfs/libxfs/xfs_rtbitmap.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/xfs/libxfs/xfs_rtbitmap.c b/fs/xfs/libxfs/xfs_rtbitmap.c
index 5d4e43ef4eea..ac09c4333485 100644
--- a/fs/xfs/libxfs/xfs_rtbitmap.c
+++ b/fs/xfs/libxfs/xfs_rtbitmap.c
@@ -672,7 +672,6 @@ xfs_rtmodify_range(
/*
* Compute a mask of relevant bits.
*/
- bit = 0;
mask = ((xfs_rtword_t)1 << lastbit) - 1;
/*
* Set/clear the active bits.
--
2.14.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xfs: remove redundant assignment to variable bit
2017-10-31 11:13 [PATCH] xfs: remove redundant assignment to variable bit Colin King
@ 2017-10-31 16:55 ` Darrick J. Wong
0 siblings, 0 replies; 2+ messages in thread
From: Darrick J. Wong @ 2017-10-31 16:55 UTC (permalink / raw)
To: Colin King; +Cc: linux-xfs, Brian Foster, kernel-janitors, linux-kernel
On Tue, Oct 31, 2017 at 11:13:50AM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable bit is being assigned a value that is never read, hence
> the assignment is redundant and can be removed. Cleans up clang
> warning:
>
> fs/xfs/libxfs/xfs_rtbitmap.c:675:3: warning: Value stored to
> 'bit' is never read
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> fs/xfs/libxfs/xfs_rtbitmap.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/xfs/libxfs/xfs_rtbitmap.c b/fs/xfs/libxfs/xfs_rtbitmap.c
> index 5d4e43ef4eea..ac09c4333485 100644
> --- a/fs/xfs/libxfs/xfs_rtbitmap.c
> +++ b/fs/xfs/libxfs/xfs_rtbitmap.c
> @@ -672,7 +672,6 @@ xfs_rtmodify_range(
> /*
> * Compute a mask of relevant bits.
> */
> - bit = 0;
> mask = ((xfs_rtword_t)1 << lastbit) - 1;
> /*
> * Set/clear the active bits.
> --
> 2.14.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-31 16:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-31 11:13 [PATCH] xfs: remove redundant assignment to variable bit Colin King
2017-10-31 16:55 ` Darrick J. Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).