From: Daniel Vetter <daniel@ffwll.ch>
To: Kees Cook <keescook@chromium.org>
Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
Maling list - DRI developers <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm: gma500: Convert timers to use timer_setup()
Date: Wed, 1 Nov 2017 10:02:14 +0100 [thread overview]
Message-ID: <20171101090213.eqelpqrfa4vwytch@phenom.ffwll.local> (raw)
In-Reply-To: <CAGXu5jJ29yotK7QBY-yL3fxNsDVeg_fTG046tEnVuWvBAM-8Hg@mail.gmail.com>
On Tue, Oct 31, 2017 at 08:08:14AM -0700, Kees Cook wrote:
> On Tue, Oct 31, 2017 at 3:18 AM, Daniel Vetter <daniel@ffwll.ch> wrote:
> > On Mon, Oct 30, 2017 at 03:05:29PM -0700, Kees Cook wrote:
> >> On Mon, Oct 30, 2017 at 3:08 AM, Daniel Vetter <daniel@ffwll.ch> wrote:
> >> > On Tue, Oct 24, 2017 at 08:16:09AM -0700, Kees Cook wrote:
> >> >> In preparation for unconditionally passing the struct timer_list pointer to
> >> >> all timer callbacks, switch to using the new timer_setup() and from_timer()
> >> >> to pass the timer pointer explicitly.
> >> >>
> >> >> Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
> >> >> Cc: David Airlie <airlied@linux.ie>
> >> >> Cc: dri-devel@lists.freedesktop.org
> >> >> Signed-off-by: Kees Cook <keescook@chromium.org>
> >> >
> >> > Do you expect drm folks to apply this, or is this part of a larger refactoring?
> >>
> >> If the drm tree includes -rc3, you can carry these. If you don't want
> >> to carry these and want the timer tree to carry them, we can do that
> >> too.
> >
> > Applied to drm-misc-next for 4.16 (we're way past freeze for 4.15
> > already).
>
> Since this is one of the few remaining "non-trivial" users of the
> ancient init_timer() API, would you mind if the timers tree carried
> this for 4.15? I'm trying to entirely remove the init_timer() API (and
> if I can, remove the old setup_*timer() API too).
I was contemplating before applying it whether I should ask ...
Oh well, problem is that drm-misc is non-rebasing, but you can just apply
it twice. git usually figures it out.
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
in case you do so.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
prev parent reply other threads:[~2017-11-01 9:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-24 15:16 [PATCH] drm: gma500: Convert timers to use timer_setup() Kees Cook
2017-10-30 10:08 ` Daniel Vetter
2017-10-30 22:05 ` Kees Cook
2017-10-31 10:18 ` Daniel Vetter
2017-10-31 15:08 ` Kees Cook
2017-11-01 9:02 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171101090213.eqelpqrfa4vwytch@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patrik.r.jakobsson@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).