From: Daniel Vetter <daniel@ffwll.ch>
To: Kees Cook <keescook@chromium.org>
Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: gma500: Convert timers to use timer_setup()
Date: Mon, 30 Oct 2017 11:08:38 +0100 [thread overview]
Message-ID: <20171030100838.lvjxy3o6q227kjsn@phenom.ffwll.local> (raw)
In-Reply-To: <20171024151609.GA104501@beast>
On Tue, Oct 24, 2017 at 08:16:09AM -0700, Kees Cook wrote:
> In preparation for unconditionally passing the struct timer_list pointer to
> all timer callbacks, switch to using the new timer_setup() and from_timer()
> to pass the timer pointer explicitly.
>
> Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Kees Cook <keescook@chromium.org>
Do you expect drm folks to apply this, or is this part of a larger refactoring?
A notch more context in the commit message would help ...
-Daniel
> ---
> drivers/gpu/drm/gma500/psb_lid.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/gma500/psb_lid.c b/drivers/gpu/drm/gma500/psb_lid.c
> index 1d2ebb5e530f..be6dda58fcae 100644
> --- a/drivers/gpu/drm/gma500/psb_lid.c
> +++ b/drivers/gpu/drm/gma500/psb_lid.c
> @@ -23,9 +23,9 @@
> #include "psb_intel_reg.h"
> #include <linux/spinlock.h>
>
> -static void psb_lid_timer_func(unsigned long data)
> +static void psb_lid_timer_func(struct timer_list *t)
> {
> - struct drm_psb_private * dev_priv = (struct drm_psb_private *)data;
> + struct drm_psb_private *dev_priv = from_timer(dev_priv, t, lid_timer);
> struct drm_device *dev = (struct drm_device *)dev_priv->dev;
> struct timer_list *lid_timer = &dev_priv->lid_timer;
> unsigned long irq_flags;
> @@ -77,10 +77,8 @@ void psb_lid_timer_init(struct drm_psb_private *dev_priv)
> spin_lock_init(&dev_priv->lid_lock);
> spin_lock_irqsave(&dev_priv->lid_lock, irq_flags);
>
> - init_timer(lid_timer);
> + timer_setup(lid_timer, psb_lid_timer_func, 0);
>
> - lid_timer->data = (unsigned long)dev_priv;
> - lid_timer->function = psb_lid_timer_func;
> lid_timer->expires = jiffies + PSB_LID_DELAY;
>
> add_timer(lid_timer);
> --
> 2.7.4
>
>
> --
> Kees Cook
> Pixel Security
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
next prev parent reply other threads:[~2017-10-30 10:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-24 15:16 [PATCH] drm: gma500: Convert timers to use timer_setup() Kees Cook
2017-10-30 10:08 ` Daniel Vetter [this message]
2017-10-30 22:05 ` Kees Cook
2017-10-31 10:18 ` Daniel Vetter
2017-10-31 15:08 ` Kees Cook
2017-11-01 9:02 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171030100838.lvjxy3o6q227kjsn@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patrik.r.jakobsson@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).