From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Andrew Jeffery <andrew@aj.id.au>
Cc: <linux-gpio@vger.kernel.org>, <linus.walleij@linaro.org>,
<robh+dt@kernel.org>, <mark.rutland@arm.com>,
<frowand.list@gmail.com>, <joel@jms.id.au>,
<ckeepax@opensource.wolfsonmicro.com>, <ldewangan@nvidia.com>,
<ryan_chen@aspeedtech.com>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>, <openbmc@lists.ozlabs.org>,
<linux-aspeed@lists.ozlabs.org>
Subject: Re: [PATCH v3 1/2] gpio: gpiolib: Generalise state persistence beyond sleep
Date: Wed, 1 Nov 2017 10:09:53 +0000 [thread overview]
Message-ID: <20171101100953.ye5fp33vxuol5z5a@localhost.localdomain> (raw)
In-Reply-To: <20171101040457.1200-2-andrew@aj.id.au>
On Wed, Nov 01, 2017 at 03:04:56PM +1100, Andrew Jeffery wrote:
> General support for state persistence is added to gpiolib with the
> introduction of a new pinconf parameter to propagate the request to
> hardware. The existing persistence support for sleep is adapted to
> include hardware support if the GPIO driver provides it. Persistence
> continues to be enabled by default; in-kernel consumers can opt out, but
> userspace (currently) does not have a choice.
>
> The *_SLEEP_MAY_LOSE_VALUE and *_SLEEP_MAINTAIN_VALUE symbols are
> renamed, dropping the SLEEP prefix to reflect that the concept is no
> longer sleep-specific. I feel that renaming to just *_MAY_LOSE_VALUE
> could initially be misinterpreted, so I've further changed the symbols
> to *_TRANSITORY and *_PERSISTENT to address this.
>
> The sysfs interface is modified only to keep consistency with the
> chardev interface in enforcing persistence for userspace exports.
>
> Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
> ---
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
next prev parent reply other threads:[~2017-11-01 10:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-01 4:04 [PATCH v3 0/2] gpio: Generalise state persistence Andrew Jeffery
2017-11-01 4:04 ` [PATCH v3 1/2] gpio: gpiolib: Generalise state persistence beyond sleep Andrew Jeffery
2017-11-01 10:09 ` Charles Keepax [this message]
2017-11-02 0:15 ` Rob Herring
2017-11-24 9:50 ` Linus Walleij
2017-11-01 4:04 ` [PATCH v3 2/2] gpio: aspeed: Add support for reset tolerance Andrew Jeffery
2017-11-07 5:01 ` Joel Stanley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171101100953.ye5fp33vxuol5z5a@localhost.localdomain \
--to=ckeepax@opensource.cirrus.com \
--cc=andrew@aj.id.au \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=joel@jms.id.au \
--cc=ldewangan@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
--cc=ryan_chen@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).