From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Milian Wolff <milian.wolff@kdab.com>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Jiri Olsa <jolsa@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
kernel-team@lge.com, Jin Yao <yao.jin@linux.intel.com>
Subject: Re: [PATCH 2/2] perf tools: Show correct function name for srcline of callchains
Date: Wed, 1 Nov 2017 11:41:05 -0300 [thread overview]
Message-ID: <20171101144105.GC3531@kernel.org> (raw)
In-Reply-To: <20171101120559.GC26623@danjae.aot.lge.com>
Em Wed, Nov 01, 2017 at 09:05:59PM +0900, Namhyung Kim escreveu:
> Hi Milian,
>
> On Wed, Nov 01, 2017 at 10:57:12AM +0100, Milian Wolff wrote:
> > On Tuesday, October 31, 2017 3:06:54 AM CET Namhyung Kim wrote:
> > > When libbfd is not used, it doesn't show proper function name and reuse
> > > the original symbol of the sample. That's because it passes the
> > > original sym to inline_list__append(). As `addr2line -f` returns
> > > function names as well, use that to create ad inline_sym and pass it to
> > > inline_list__append().
> >
> > Typo above: "ad" -> "and"
>
> I think it's "an" instead of "and". :)
I didn't catch that, bummer! 8-) Ok, made the ad -> and -> an change :-)
And added Milian's Reviewed-by,
- Arnaldo
> > Otherwise these patches look fine to me
> >
> > Reviewed-by: Milian Wolff <milian.wolff@kdab.com>
>
> Thanks,
> Namhyung
next prev parent reply other threads:[~2017-11-01 14:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-31 2:06 [PATCH 1/2] perf tools: Fix memory leak in addr2inlines() Namhyung Kim
2017-10-31 2:06 ` [PATCH 2/2] perf tools: Show correct function name for srcline of callchains Namhyung Kim
[not found] ` <2208660.mvSdWdKhUF@milian-kdab2>
2017-11-01 12:05 ` Namhyung Kim
2017-11-01 14:41 ` Arnaldo Carvalho de Melo [this message]
2017-11-01 12:14 ` Jiri Olsa
2017-11-03 14:24 ` [tip:perf/core] perf srcline: " tip-bot for Namhyung Kim
2017-11-01 12:13 ` [PATCH 1/2] perf tools: Fix memory leak in addr2inlines() Jiri Olsa
2017-11-01 14:42 ` Arnaldo Carvalho de Melo
2017-11-03 14:23 ` [tip:perf/core] perf srcline: " tip-bot for Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171101144105.GC3531@kernel.org \
--to=acme@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=jolsa@kernel.org \
--cc=kernel-team@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=milian.wolff@kdab.com \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).