From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Jiri Olsa <jolsa@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
kernel-team@lge.com, Jin Yao <yao.jin@linux.intel.com>,
Milian Wolff <milian.wolff@kdab.com>
Subject: Re: [PATCH 1/2] perf tools: Fix memory leak in addr2inlines()
Date: Wed, 1 Nov 2017 11:42:41 -0300 [thread overview]
Message-ID: <20171101144241.GD3531@kernel.org> (raw)
In-Reply-To: <20171101121357.GA20353@krava>
Em Wed, Nov 01, 2017 at 01:13:57PM +0100, Jiri Olsa escreveu:
> On Tue, Oct 31, 2017 at 11:06:53AM +0900, Namhyung Kim wrote:
> > When libbfd is not used, addr2inlines() executes `addr2line -i` and
> > process output line by line. But it resets filename to NULL in the loop
> > so getline() allocates additional memory everytime instead of realloc.
> >
> > Cc: Jin Yao <yao.jin@linux.intel.com>
> > Cc: Milian Wolff <milian.wolff@kdab.com>
> > Signed-off-by: Namhyung Kim <namhyung@kernel.org>
>
> Acked-by: Jiri Olsa <jolsa@kernel.org>
Thanks, added this and the Reviewed-by to 2/2.
- Arnaldo
> jirka
>
> > ---
> > tools/perf/util/srcline.c | 7 ++-----
> > 1 file changed, 2 insertions(+), 5 deletions(-)
> >
> > diff --git a/tools/perf/util/srcline.c b/tools/perf/util/srcline.c
> > index c143c3bc1ef8..51dc49c65476 100644
> > --- a/tools/perf/util/srcline.c
> > +++ b/tools/perf/util/srcline.c
> > @@ -456,20 +456,17 @@ static struct inline_node *addr2inlines(const char *dso_name, u64 addr,
> > while (getline(&filename, &len, fp) != -1) {
> > char *srcline;
> >
> > - if (filename_split(filename, &line_nr) != 1) {
> > - free(filename);
> > + if (filename_split(filename, &line_nr) != 1)
> > goto out;
> > - }
> >
> > srcline = srcline_from_fileline(filename, line_nr);
> > if (inline_list__append(sym, srcline, node) != 0)
> > goto out;
> > -
> > - filename = NULL;
> > }
> >
> > out:
> > pclose(fp);
> > + free(filename);
> >
> > return node;
> > }
> > --
> > 2.14.3
> >
next prev parent reply other threads:[~2017-11-01 14:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-31 2:06 [PATCH 1/2] perf tools: Fix memory leak in addr2inlines() Namhyung Kim
2017-10-31 2:06 ` [PATCH 2/2] perf tools: Show correct function name for srcline of callchains Namhyung Kim
[not found] ` <2208660.mvSdWdKhUF@milian-kdab2>
2017-11-01 12:05 ` Namhyung Kim
2017-11-01 14:41 ` Arnaldo Carvalho de Melo
2017-11-01 12:14 ` Jiri Olsa
2017-11-03 14:24 ` [tip:perf/core] perf srcline: " tip-bot for Namhyung Kim
2017-11-01 12:13 ` [PATCH 1/2] perf tools: Fix memory leak in addr2inlines() Jiri Olsa
2017-11-01 14:42 ` Arnaldo Carvalho de Melo [this message]
2017-11-03 14:23 ` [tip:perf/core] perf srcline: " tip-bot for Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171101144241.GD3531@kernel.org \
--to=acme@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=kernel-team@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=milian.wolff@kdab.com \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).