linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* linux-next: manual merge of the integrity tree with the security tree
@ 2017-11-02  2:02 Stephen Rothwell
  0 siblings, 0 replies; 2+ messages in thread
From: Stephen Rothwell @ 2017-11-02  2:02 UTC (permalink / raw)
  To: Mimi Zohar, Dmitry Kasatkin, James Morris
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Eric Biggers

Hi all,

Today's linux-next merge of the integrity tree got a conflict in:

  MAINTAINERS

between commit:

  e28aa8aeab43 ("MAINTAINERS: remove David Safford as maintainer for encrypted+trusted keys")

from the security tree and commit:

  46d6c35e6882 ("MAINTAINERS: update the IMA, EVM, trusted-keys, encrypted-keys entries")

from the integrity tree.

I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging.  You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.

-- 
Cheers,
Stephen Rothwell

diff --cc MAINTAINERS
index df4a2519b306,80023acd6a7c..000000000000
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@@ -7680,7 -7623,8 +7677,7 @@@ F:	kernel/kexec
  
  KEYS-ENCRYPTED
  M:	Mimi Zohar <zohar@linux.vnet.ibm.com>
- L:	linux-security-module@vger.kernel.org
 -M:	David Safford <safford@us.ibm.com>
+ L:	linux-integrity@vger.kernel.org
  L:	keyrings@vger.kernel.org
  S:	Supported
  F:	Documentation/security/keys/trusted-encrypted.rst
@@@ -7688,8 -7632,9 +7685,8 @@@ F:	include/keys/encrypted-type.
  F:	security/keys/encrypted-keys/
  
  KEYS-TRUSTED
 -M:	David Safford <safford@us.ibm.com>
  M:	Mimi Zohar <zohar@linux.vnet.ibm.com>
- L:	linux-security-module@vger.kernel.org
+ L:	linux-integrity@vger.kernel.org
  L:	keyrings@vger.kernel.org
  S:	Supported
  F:	Documentation/security/keys/trusted-encrypted.rst

^ permalink raw reply	[flat|nested] 2+ messages in thread

* linux-next: manual merge of the integrity tree with the security tree
@ 2019-08-21  3:27 Stephen Rothwell
  0 siblings, 0 replies; 2+ messages in thread
From: Stephen Rothwell @ 2019-08-21  3:27 UTC (permalink / raw)
  To: Mimi Zohar, Dmitry Kasatkin, James Morris
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Jiri Bohac,
	David Howells, Matthew Garrett, Thiago Jung Bauermann

[-- Attachment #1: Type: text/plain, Size: 1875 bytes --]

Hi all,

Today's linux-next merge of the integrity tree got a conflict in:

  arch/s390/kernel/machine_kexec_file.c

between commit:

  99d5cadfde2b ("kexec_file: split KEXEC_VERIFY_SIG into KEXEC_SIG and KEXEC_SIG_FORCE")

from the security tree and commit:

  c8424e776b09 ("MODSIGN: Export module signature definitions")

from the integrity tree.

I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging.  You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.

-- 
Cheers,
Stephen Rothwell

diff --cc arch/s390/kernel/machine_kexec_file.c
index c0f33ba49a9a,1ac9fbc6e01e..000000000000
--- a/arch/s390/kernel/machine_kexec_file.c
+++ b/arch/s390/kernel/machine_kexec_file.c
@@@ -22,29 -22,7 +22,7 @@@ const struct kexec_file_ops * const kex
  	NULL,
  };
  
 -#ifdef CONFIG_KEXEC_VERIFY_SIG
 +#ifdef CONFIG_KEXEC_SIG
- /*
-  * Module signature information block.
-  *
-  * The constituents of the signature section are, in order:
-  *
-  *	- Signer's name
-  *	- Key identifier
-  *	- Signature data
-  *	- Information block
-  */
- struct module_signature {
- 	u8	algo;		/* Public-key crypto algorithm [0] */
- 	u8	hash;		/* Digest algorithm [0] */
- 	u8	id_type;	/* Key identifier type [PKEY_ID_PKCS7] */
- 	u8	signer_len;	/* Length of signer's name [0] */
- 	u8	key_id_len;	/* Length of key identifier [0] */
- 	u8	__pad[3];
- 	__be32	sig_len;	/* Length of signature data */
- };
- 
- #define PKEY_ID_PKCS7 2
- 
  int s390_verify_sig(const char *kernel, unsigned long kernel_len)
  {
  	const unsigned long marker_len = sizeof(MODULE_SIG_STRING) - 1;

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-08-21  3:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-02  2:02 linux-next: manual merge of the integrity tree with the security tree Stephen Rothwell
2019-08-21  3:27 Stephen Rothwell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).