From: Ming Lei <ming.lei@redhat.com>
To: Jens Axboe <axboe@fb.com>,
linux-block@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>
Cc: Omar Sandoval <osandov@fb.com>,
Bart Van Assche <bart.vanassche@sandisk.com>,
Hannes Reinecke <hare@suse.com>,
linux-kernel@vger.kernel.org, Ming Lei <ming.lei@redhat.com>
Subject: [PATCH V3 0/7] blk-mq: don't allocate driver tag beforehand for flush rq
Date: Thu, 2 Nov 2017 23:24:31 +0800 [thread overview]
Message-ID: <20171102152438.25324-1-ming.lei@redhat.com> (raw)
Hi Jens,
This patchset avoids to allocate driver tag beforehand for flush rq
in case of I/O scheduler, then flush rq isn't treated specially
wrt. get/put driver tag, code gets cleanup much, such as,
reorder_tags_to_front() is removed, and we needn't to worry
about request order in dispatch list for avoiding I/O deadlock.
'dbench -t 30 -s 64' has been run on different devices(shared tag,
multi-queue, singele queue, ...), and no issues are observed,
even very low queue depth test are run, debench still works well.
Please consider it for V4.15, thanks!
V3:
- rebase on the latest for-next of block tree
- clean up commit log and comment
- include Jianchao's fix on put driver tag
V2:
- release driver tag before requeue
- warning on inserting a req with driver tag
Jianchao Wang (1):
blk-mq: put the driver tag of nxt rq before first one is requeued
Ming Lei (6):
blk-flush: don't run queue for requests of bypassing flush
block: pass 'run_queue' to blk_mq_request_bypass_insert
blk-flush: use blk_mq_request_bypass_insert()
blk-mq-sched: decide how to handle flush rq via RQF_FLUSH_SEQ
blk-mq: move blk_mq_put_driver_tag*() into blk-mq.h
blk-mq: don't allocate driver tag beforehand for flush rq
block/blk-core.c | 2 +-
block/blk-flush.c | 37 ++++++++++++++------
block/blk-mq-sched.c | 63 +++++++++-------------------------
block/blk-mq.c | 97 ++++++++++------------------------------------------
block/blk-mq.h | 35 ++++++++++++++++++-
5 files changed, 97 insertions(+), 137 deletions(-)
--
2.9.5
next reply other threads:[~2017-11-02 15:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-02 15:24 Ming Lei [this message]
2017-11-02 15:24 ` [PATCH V3 1/7] blk-mq: put the driver tag of nxt rq before first one is requeued Ming Lei
2017-11-02 15:24 ` [PATCH V3 2/7] blk-flush: don't run queue for requests of bypassing flush Ming Lei
2017-11-02 15:24 ` [PATCH V3 3/7] block: pass 'run_queue' to blk_mq_request_bypass_insert Ming Lei
2017-11-02 15:24 ` [PATCH V3 4/7] blk-flush: use blk_mq_request_bypass_insert() Ming Lei
2017-11-02 15:24 ` [PATCH V3 5/7] blk-mq-sched: decide how to handle flush rq via RQF_FLUSH_SEQ Ming Lei
2017-11-02 15:24 ` [PATCH V3 6/7] blk-mq: move blk_mq_put_driver_tag*() into blk-mq.h Ming Lei
2017-11-02 15:24 ` [PATCH V3 7/7] blk-mq: don't allocate driver tag beforehand for flush rq Ming Lei
2017-11-04 4:17 ` [PATCH V3 0/7] " Ming Lei
2017-11-04 14:18 ` Jens Axboe
2017-11-04 18:49 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171102152438.25324-1-ming.lei@redhat.com \
--to=ming.lei@redhat.com \
--cc=axboe@fb.com \
--cc=bart.vanassche@sandisk.com \
--cc=hare@suse.com \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=osandov@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).