From: Jens Axboe <axboe@kernel.dk>
To: Ming Lei <ming.lei@redhat.com>,
linux-block@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>
Cc: Omar Sandoval <osandov@fb.com>,
Bart Van Assche <bart.vanassche@sandisk.com>,
Hannes Reinecke <hare@suse.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3 0/7] blk-mq: don't allocate driver tag beforehand for flush rq
Date: Sat, 4 Nov 2017 12:49:06 -0600 [thread overview]
Message-ID: <38f3a132-0c0d-4ae1-ac05-86a492720a5f@kernel.dk> (raw)
In-Reply-To: <016e4ab3-c5db-9871-0e4d-cd3ff31eee22@kernel.dk>
On 11/04/2017 08:18 AM, Jens Axboe wrote:
> On 11/03/2017 10:17 PM, Ming Lei wrote:
>> On Thu, Nov 02, 2017 at 11:24:31PM +0800, Ming Lei wrote:
>>> Hi Jens,
>>>
>>> This patchset avoids to allocate driver tag beforehand for flush rq
>>> in case of I/O scheduler, then flush rq isn't treated specially
>>> wrt. get/put driver tag, code gets cleanup much, such as,
>>> reorder_tags_to_front() is removed, and we needn't to worry
>>> about request order in dispatch list for avoiding I/O deadlock.
>>>
>>> 'dbench -t 30 -s 64' has been run on different devices(shared tag,
>>> multi-queue, singele queue, ...), and no issues are observed,
>>> even very low queue depth test are run, debench still works well.
>>>
>>> Please consider it for V4.15, thanks!
>>
>> Hi Jens,
>>
>> As we discussed before, this patch is a good cleanup on handling flush
>> request, could you share your opinion on V3?
>
> It looks fine to me. But I'd really like to have the potential hang
> in the current 4.15 branch ironed out, before we pile more stuff on
> top. Meanwhile, I'll see if this passes my testing.
Passes testing. I applied it, but a heads-up that I rewrote most of
your changelogs and also changed formatting. Please at least follow
the 72 char line rule for commit messages, otherwise git log ends
up looking like a mess really quick.
--
Jens Axboe
prev parent reply other threads:[~2017-11-04 18:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-02 15:24 [PATCH V3 0/7] blk-mq: don't allocate driver tag beforehand for flush rq Ming Lei
2017-11-02 15:24 ` [PATCH V3 1/7] blk-mq: put the driver tag of nxt rq before first one is requeued Ming Lei
2017-11-02 15:24 ` [PATCH V3 2/7] blk-flush: don't run queue for requests of bypassing flush Ming Lei
2017-11-02 15:24 ` [PATCH V3 3/7] block: pass 'run_queue' to blk_mq_request_bypass_insert Ming Lei
2017-11-02 15:24 ` [PATCH V3 4/7] blk-flush: use blk_mq_request_bypass_insert() Ming Lei
2017-11-02 15:24 ` [PATCH V3 5/7] blk-mq-sched: decide how to handle flush rq via RQF_FLUSH_SEQ Ming Lei
2017-11-02 15:24 ` [PATCH V3 6/7] blk-mq: move blk_mq_put_driver_tag*() into blk-mq.h Ming Lei
2017-11-02 15:24 ` [PATCH V3 7/7] blk-mq: don't allocate driver tag beforehand for flush rq Ming Lei
2017-11-04 4:17 ` [PATCH V3 0/7] " Ming Lei
2017-11-04 14:18 ` Jens Axboe
2017-11-04 18:49 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38f3a132-0c0d-4ae1-ac05-86a492720a5f@kernel.dk \
--to=axboe@kernel.dk \
--cc=bart.vanassche@sandisk.com \
--cc=hare@suse.com \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=osandov@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).