* [PATCH] ARM: sun7i: Add Cubietech Einstein A20 board device-tree
@ 2017-11-02 14:35 Frank Kunz
2017-11-02 15:57 ` Maxime Ripard
0 siblings, 1 reply; 5+ messages in thread
From: Frank Kunz @ 2017-11-02 14:35 UTC (permalink / raw)
To: devicetree, mark.rutland, maxime.ripard, wens
Cc: linux-kernel, linux-arm-kernel, robh+dt, Frank Kunz
From: Frank Kunz <xxxxxmichl@googlemail.com>
The Einstein A20 board is a Allwinner A20 based board with a credit card
form factor.
Features:
- Allwinner A20 SoC
- DDR3 1GB RAM
- 8GiB eMMC
- AP6210 wifi/Bluetooth
- RTC
- Micro USB-OTG connector
- UART0 debugging port
- 200 pins stamp hole package
Signed-off-by: Frank Kunz <xxxxxmichl@googlemail.com>
---
arch/arm/boot/dts/Makefile | 1 +
arch/arm/boot/dts/sun7i-a20-einstein.dts | 200 +++++++++++++++++++++++++++++++
2 files changed, 201 insertions(+)
create mode 100644 arch/arm/boot/dts/sun7i-a20-einstein.dts
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index faf46abaa4a2..f9158400ea0f 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -878,6 +878,7 @@ dtb-$(CONFIG_MACH_SUN7I) += \
sun7i-a20-bananapro.dtb \
sun7i-a20-cubieboard2.dtb \
sun7i-a20-cubietruck.dtb \
+ sun7i-a20-einstein.dtb \
sun7i-a20-hummingbird.dtb \
sun7i-a20-itead-ibox.dtb \
sun7i-a20-i12-tvbox.dtb \
diff --git a/arch/arm/boot/dts/sun7i-a20-einstein.dts b/arch/arm/boot/dts/sun7i-a20-einstein.dts
new file mode 100644
index 000000000000..59d46b08f21c
--- /dev/null
+++ b/arch/arm/boot/dts/sun7i-a20-einstein.dts
@@ -0,0 +1,200 @@
+/*
+ * Copyright 2017 Frank Kunz
+ *
+ * Frank Kunz <xxxxxmichl@googlemail.com>
+ *
+ * This file is dual-licensed: you can use it either under the terms
+ * of the GPL or the X11 license, at your option. Note that this dual
+ * licensing only applies to this file, and not this project as a
+ * whole.
+ *
+ * a) This file is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of the
+ * License, or (at your option) any later version.
+ *
+ * This file is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * Or, alternatively,
+ *
+ * b) Permission is hereby granted, free of charge, to any person
+ * obtaining a copy of this software and associated documentation
+ * files (the "Software"), to deal in the Software without
+ * restriction, including without limitation the rights to use,
+ * copy, modify, merge, publish, distribute, sublicense, and/or
+ * sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following
+ * conditions:
+ *
+ * The above copyright notice and this permission notice shall be
+ * included in all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+ * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
+ * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+ * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
+ * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
+ * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+ * OTHER DEALINGS IN THE SOFTWARE.
+ */
+
+/dts-v1/;
+#include "sun7i-a20.dtsi"
+#include "sunxi-common-regulators.dtsi"
+
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/interrupt-controller/irq.h>
+
+/ {
+ model = "Cubietech Einstein A20";
+ compatible = "cubietech,einstein-a20", "allwinner,sun7i-a20";
+
+ aliases {
+ serial0 = &uart0;
+ };
+
+ chosen {
+ stdout-path = "serial0:115200n8";
+ };
+
+ mmc3_pwrseq: mmc3_pwrseq {
+ compatible = "mmc-pwrseq-simple";
+ pinctrl-names = "default";
+ pinctrl-0 = <&mmc3_pwrseq_pin_ea20>;
+ reset-gpios = <&pio 7 9 GPIO_ACTIVE_LOW>; /* PH9 WIFI-SHDN */
+ };
+};
+
+&cpu0 {
+ cpu-supply = <®_dcdc2>;
+};
+
+&ehci0 {
+ status = "okay";
+};
+
+&i2c0 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&i2c0_pins_a>;
+ status = "okay";
+
+ axp209: pmic@34 {
+ reg = <0x34>;
+ interrupt-parent = <&nmi_intc>;
+ interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
+ };
+};
+
+&mmc2 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&mmc2_pins_a>;
+ vmmc-supply = <®_vcc3v3>;
+ bus-width = <4>;
+ non-removable;
+ status = "okay";
+};
+
+&mmc3 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&mmc3_pins_a>;
+ vmmc-supply = <®_vcc3v3>;
+ mmc-pwrseq = <&mmc3_pwrseq>;
+ bus-width = <4>;
+ non-removable;
+ wakeup-source;
+ status = "okay";
+
+ brcmf: wifi@1 {
+ reg = <1>;
+ compatible = "brcm,bcm4329-fmac";
+ interrupt-parent = <&pio>;
+ interrupts = <7 10 IRQ_TYPE_LEVEL_LOW>;
+ interrupt-names = "host-wake";
+ };
+};
+
+&ohci0 {
+ status = "okay";
+};
+
+&otg_sram {
+ status = "okay";
+};
+
+&pio {
+ usb0_id_detect_pin: usb0_id_detect_pin@0 {
+ pins = "PH4";
+ function = "gpio_in";
+ bias-pull-up;
+ };
+
+ mmc3_pwrseq_pin_ea20: mmc3_pwrseq_pin@0 {
+ pins = "PH9";
+ function = "gpio_out";
+ };
+};
+
+#include "axp209.dtsi"
+
+&usb_power_supply {
+ status = "okay";
+};
+
+®_dcdc2 {
+ regulator-always-on;
+ regulator-min-microvolt = <1000000>;
+ regulator-max-microvolt = <1450000>;
+ regulator-name = "vdd-cpu";
+};
+
+®_dcdc3 {
+ regulator-always-on;
+ regulator-min-microvolt = <1000000>;
+ regulator-max-microvolt = <1400000>;
+ regulator-name = "vdd-int-dll";
+};
+
+®_ldo1 {
+ regulator-name = "vdd-rtc";
+};
+
+®_ldo2 {
+ regulator-always-on;
+ regulator-min-microvolt = <3000000>;
+ regulator-max-microvolt = <3000000>;
+ regulator-name = "avcc";
+};
+
+®_usb1_vbus {
+ status = "okay";
+};
+
+®_usb2_vbus {
+ status = "okay";
+};
+
+&uart0 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&uart0_pins_a>;
+ status = "okay";
+};
+
+&usb_otg {
+ dr_mode = "otg";
+ status = "okay";
+};
+
+&usbphy {
+ pinctrl-names = "default";
+ pinctrl-0 = <&usb0_id_detect_pin>;
+ usb0_id_det-gpio = <&pio 7 4 GPIO_ACTIVE_HIGH>; /* PH4 */
+ usb1_vbus-supply = <®_usb1_vbus>;
+ usb2_vbus-supply = <®_usb2_vbus>;
+ status = "okay";
+};
--
2.14.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: sun7i: Add Cubietech Einstein A20 board device-tree
2017-11-02 14:35 [PATCH] ARM: sun7i: Add Cubietech Einstein A20 board device-tree Frank Kunz
@ 2017-11-02 15:57 ` Maxime Ripard
2017-11-02 18:59 ` Frank Kunz
0 siblings, 1 reply; 5+ messages in thread
From: Maxime Ripard @ 2017-11-02 15:57 UTC (permalink / raw)
To: Frank Kunz
Cc: devicetree, mark.rutland, wens, linux-kernel, linux-arm-kernel,
robh+dt, Frank Kunz
[-- Attachment #1: Type: text/plain, Size: 5441 bytes --]
Hi Frank,
Thanks for your patch.
On Thu, Nov 02, 2017 at 03:35:34PM +0100, Frank Kunz wrote:
> From: Frank Kunz <xxxxxmichl@googlemail.com>
>
> The Einstein A20 board is a Allwinner A20 based board with a credit card
> form factor.
>
> Features:
> - Allwinner A20 SoC
> - DDR3 1GB RAM
> - 8GiB eMMC
> - AP6210 wifi/Bluetooth
> - RTC
> - Micro USB-OTG connector
> - UART0 debugging port
> - 200 pins stamp hole package
>
> Signed-off-by: Frank Kunz <xxxxxmichl@googlemail.com>
> ---
> arch/arm/boot/dts/Makefile | 1 +
> arch/arm/boot/dts/sun7i-a20-einstein.dts | 200 +++++++++++++++++++++++++++++++
> 2 files changed, 201 insertions(+)
> create mode 100644 arch/arm/boot/dts/sun7i-a20-einstein.dts
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index faf46abaa4a2..f9158400ea0f 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -878,6 +878,7 @@ dtb-$(CONFIG_MACH_SUN7I) += \
> sun7i-a20-bananapro.dtb \
> sun7i-a20-cubieboard2.dtb \
> sun7i-a20-cubietruck.dtb \
> + sun7i-a20-einstein.dtb \
I guess it's not that obvious from what company that board is coming
from. Could you turn it into cubietech-einstein please?
> sun7i-a20-hummingbird.dtb \
> sun7i-a20-itead-ibox.dtb \
> sun7i-a20-i12-tvbox.dtb \
> diff --git a/arch/arm/boot/dts/sun7i-a20-einstein.dts b/arch/arm/boot/dts/sun7i-a20-einstein.dts
> new file mode 100644
> index 000000000000..59d46b08f21c
> --- /dev/null
> +++ b/arch/arm/boot/dts/sun7i-a20-einstein.dts
> @@ -0,0 +1,200 @@
> +/*
> + * Copyright 2017 Frank Kunz
> + *
> + * Frank Kunz <xxxxxmichl@googlemail.com>
> + *
> + * This file is dual-licensed: you can use it either under the terms
> + * of the GPL or the X11 license, at your option. Note that this dual
> + * licensing only applies to this file, and not this project as a
> + * whole.
> + *
> + * a) This file is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of the
> + * License, or (at your option) any later version.
> + *
> + * This file is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * Or, alternatively,
> + *
> + * b) Permission is hereby granted, free of charge, to any person
> + * obtaining a copy of this software and associated documentation
> + * files (the "Software"), to deal in the Software without
> + * restriction, including without limitation the rights to use,
> + * copy, modify, merge, publish, distribute, sublicense, and/or
> + * sell copies of the Software, and to permit persons to whom the
> + * Software is furnished to do so, subject to the following
> + * conditions:
> + *
> + * The above copyright notice and this permission notice shall be
> + * included in all copies or substantial portions of the Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
> + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
> + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
> + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> + * OTHER DEALINGS IN THE SOFTWARE.
> + */
> +
> +/dts-v1/;
> +#include "sun7i-a20.dtsi"
> +#include "sunxi-common-regulators.dtsi"
> +
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/interrupt-controller/irq.h>
> +
> +/ {
> + model = "Cubietech Einstein A20";
> + compatible = "cubietech,einstein-a20", "allwinner,sun7i-a20";
> +
> + aliases {
> + serial0 = &uart0;
> + };
> +
> + chosen {
> + stdout-path = "serial0:115200n8";
> + };
> +
> + mmc3_pwrseq: mmc3_pwrseq {
> + compatible = "mmc-pwrseq-simple";
> + pinctrl-names = "default";
> + pinctrl-0 = <&mmc3_pwrseq_pin_ea20>;
You don't need those GPIO pinctrl nodes, you can remove all of them.
> + reset-gpios = <&pio 7 9 GPIO_ACTIVE_LOW>; /* PH9 WIFI-SHDN */
> + };
> +};
> +
> +&cpu0 {
> + cpu-supply = <®_dcdc2>;
> +};
> +
> +&ehci0 {
> + status = "okay";
> +};
> +
> +&i2c0 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&i2c0_pins_a>;
> + status = "okay";
> +
> + axp209: pmic@34 {
> + reg = <0x34>;
> + interrupt-parent = <&nmi_intc>;
> + interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
> + };
> +};
> +
> +&mmc2 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&mmc2_pins_a>;
> + vmmc-supply = <®_vcc3v3>;
What regulator is this connected to on the PMIC?
> + bus-width = <4>;
> + non-removable;
> + status = "okay";
> +};
> +
> +&mmc3 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&mmc3_pins_a>;
> + vmmc-supply = <®_vcc3v3>;
Same question here.
Looks good otherwise, thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: sun7i: Add Cubietech Einstein A20 board device-tree
2017-11-02 15:57 ` Maxime Ripard
@ 2017-11-02 18:59 ` Frank Kunz
2017-11-03 8:44 ` Maxime Ripard
0 siblings, 1 reply; 5+ messages in thread
From: Frank Kunz @ 2017-11-02 18:59 UTC (permalink / raw)
To: Maxime Ripard
Cc: devicetree, mark.rutland, wens, linux-kernel, linux-arm-kernel, robh+dt
Am Donnerstag, 2. November 2017, 16:57:36 CET schrieb Maxime Ripard:
> Hi Frank,
>
> Thanks for your patch.
>
> On Thu, Nov 02, 2017 at 03:35:34PM +0100, Frank Kunz wrote:
> > From: Frank Kunz <xxxxxmichl@googlemail.com>
> >
> > The Einstein A20 board is a Allwinner A20 based board with a credit card
> > form factor.
> >
> > Features:
> > - Allwinner A20 SoC
> > - DDR3 1GB RAM
> > - 8GiB eMMC
> > - AP6210 wifi/Bluetooth
> > - RTC
> > - Micro USB-OTG connector
> > - UART0 debugging port
> > - 200 pins stamp hole package
> >
> > Signed-off-by: Frank Kunz <xxxxxmichl@googlemail.com>
> > ---
> >
> > arch/arm/boot/dts/Makefile | 1 +
> > arch/arm/boot/dts/sun7i-a20-einstein.dts | 200
> > +++++++++++++++++++++++++++++++ 2 files changed, 201 insertions(+)
> > create mode 100644 arch/arm/boot/dts/sun7i-a20-einstein.dts
> >
> > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> > index faf46abaa4a2..f9158400ea0f 100644
> > --- a/arch/arm/boot/dts/Makefile
> > +++ b/arch/arm/boot/dts/Makefile
> > @@ -878,6 +878,7 @@ dtb-$(CONFIG_MACH_SUN7I) += \
> >
> > sun7i-a20-bananapro.dtb \
> > sun7i-a20-cubieboard2.dtb \
> > sun7i-a20-cubietruck.dtb \
> >
> > + sun7i-a20-einstein.dtb \
>
> I guess it's not that obvious from what company that board is coming
> from. Could you turn it into cubietech-einstein please?
No problem, I will rename it.
>
> > sun7i-a20-hummingbird.dtb \
> > sun7i-a20-itead-ibox.dtb \
> > sun7i-a20-i12-tvbox.dtb \
> >
> > diff --git a/arch/arm/boot/dts/sun7i-a20-einstein.dts
> > b/arch/arm/boot/dts/sun7i-a20-einstein.dts new file mode 100644
> > index 000000000000..59d46b08f21c
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/sun7i-a20-einstein.dts
> > @@ -0,0 +1,200 @@
> > +/*
> > + * Copyright 2017 Frank Kunz
> > + *
> > + * Frank Kunz <xxxxxmichl@googlemail.com>
> > + *
> > + * This file is dual-licensed: you can use it either under the terms
> > + * of the GPL or the X11 license, at your option. Note that this dual
> > + * licensing only applies to this file, and not this project as a
> > + * whole.
> > + *
> > + * a) This file is free software; you can redistribute it and/or
> > + * modify it under the terms of the GNU General Public License as
> > + * published by the Free Software Foundation; either version 2 of the
> > + * License, or (at your option) any later version.
> > + *
> > + * This file is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> > + * GNU General Public License for more details.
> > + *
> > + * Or, alternatively,
> > + *
> > + * b) Permission is hereby granted, free of charge, to any person
> > + * obtaining a copy of this software and associated documentation
> > + * files (the "Software"), to deal in the Software without
> > + * restriction, including without limitation the rights to use,
> > + * copy, modify, merge, publish, distribute, sublicense, and/or
> > + * sell copies of the Software, and to permit persons to whom the
> > + * Software is furnished to do so, subject to the following
> > + * conditions:
> > + *
> > + * The above copyright notice and this permission notice shall be
> > + * included in all copies or substantial portions of the Software.
> > + *
> > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> > + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
> > + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> > + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
> > + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
> > + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> > + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> > + * OTHER DEALINGS IN THE SOFTWARE.
> > + */
> > +
> > +/dts-v1/;
> > +#include "sun7i-a20.dtsi"
> > +#include "sunxi-common-regulators.dtsi"
> > +
> > +#include <dt-bindings/gpio/gpio.h>
> > +#include <dt-bindings/interrupt-controller/irq.h>
> > +
> > +/ {
> > + model = "Cubietech Einstein A20";
> > + compatible = "cubietech,einstein-a20", "allwinner,sun7i-a20";
> > +
> > + aliases {
> > + serial0 = &uart0;
> > + };
> > +
> > + chosen {
> > + stdout-path = "serial0:115200n8";
> > + };
> > +
> > + mmc3_pwrseq: mmc3_pwrseq {
> > + compatible = "mmc-pwrseq-simple";
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&mmc3_pwrseq_pin_ea20>;
>
> You don't need those GPIO pinctrl nodes, you can remove all of them.
Fixed.
>
> > + reset-gpios = <&pio 7 9 GPIO_ACTIVE_LOW>; /* PH9 WIFI-SHDN */
> > + };
> > +};
> > +
> > +&cpu0 {
> > + cpu-supply = <®_dcdc2>;
> > +};
> > +
> > +&ehci0 {
> > + status = "okay";
> > +};
> > +
> > +&i2c0 {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&i2c0_pins_a>;
> > + status = "okay";
> > +
> > + axp209: pmic@34 {
> > + reg = <0x34>;
> > + interrupt-parent = <&nmi_intc>;
> > + interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
> > + };
> > +};
> > +
> > +&mmc2 {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&mmc2_pins_a>;
> > + vmmc-supply = <®_vcc3v3>;
>
> What regulator is this connected to on the PMIC?
Fixed, On the schematic it is finally connected to 3v0.
>
> > + bus-width = <4>;
> > + non-removable;
> > + status = "okay";
> > +};
> > +
> > +&mmc3 {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&mmc3_pins_a>;
> > + vmmc-supply = <®_vcc3v3>;
>
> Same question here.
Same fix here, connected on schematic to 3v0.
>
> Looks good otherwise, thanks!
> Maxime
Thanks for your feedback, new patch is on the way.
Br,
Frank
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: sun7i: Add Cubietech Einstein A20 board device-tree
2017-11-02 18:59 ` Frank Kunz
@ 2017-11-03 8:44 ` Maxime Ripard
2017-11-03 12:01 ` Frank Kunz
0 siblings, 1 reply; 5+ messages in thread
From: Maxime Ripard @ 2017-11-03 8:44 UTC (permalink / raw)
To: Frank Kunz
Cc: devicetree, mark.rutland, wens, linux-kernel, linux-arm-kernel, robh+dt
[-- Attachment #1: Type: text/plain, Size: 569 bytes --]
Hi Frank,
On Thu, Nov 02, 2017 at 07:59:04PM +0100, Frank Kunz wrote:
> > > +&mmc2 {
> > > + pinctrl-names = "default";
> > > + pinctrl-0 = <&mmc2_pins_a>;
> > > + vmmc-supply = <®_vcc3v3>;
> >
> > What regulator is this connected to on the PMIC?
>
> Fixed, On the schematic it is finally connected to 3v0.
Sorry, it wasn't really what I meant. Surely there's a PMIC regulator
providing that 3.0V, you should put that regulator here.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: sun7i: Add Cubietech Einstein A20 board device-tree
2017-11-03 8:44 ` Maxime Ripard
@ 2017-11-03 12:01 ` Frank Kunz
0 siblings, 0 replies; 5+ messages in thread
From: Frank Kunz @ 2017-11-03 12:01 UTC (permalink / raw)
To: Maxime Ripard
Cc: devicetree, mark.rutland, wens, linux-kernel, linux-arm-kernel, robh+dt
Am Freitag, 3. November 2017, 09:44:27 CET schrieb Maxime Ripard:
> Hi Frank,
>
> On Thu, Nov 02, 2017 at 07:59:04PM +0100, Frank Kunz wrote:
> > > > +&mmc2 {
> > > > + pinctrl-names = "default";
> > > > + pinctrl-0 = <&mmc2_pins_a>;
> > > > + vmmc-supply = <®_vcc3v3>;
> > >
> > > What regulator is this connected to on the PMIC?
> >
> > Fixed, On the schematic it is finally connected to 3v0.
>
> Sorry, it wasn't really what I meant. Surely there's a PMIC regulator
> providing that 3.0V, you should put that regulator here.
>
It is not connected to any of the PMIC (AXP209) regulators. There is a
dedicated DCDC converter on that board which is driven by IPSOUT. This one
generates the 3.0V IO supply.
Br,
Frank
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-11-03 12:01 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-02 14:35 [PATCH] ARM: sun7i: Add Cubietech Einstein A20 board device-tree Frank Kunz
2017-11-02 15:57 ` Maxime Ripard
2017-11-02 18:59 ` Frank Kunz
2017-11-03 8:44 ` Maxime Ripard
2017-11-03 12:01 ` Frank Kunz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).