* [PATCH] usb: xhci: tegra: use time64_t for printing timestamp
@ 2017-11-02 14:34 Arnd Bergmann
2017-11-02 16:17 ` Thierry Reding
0 siblings, 1 reply; 4+ messages in thread
From: Arnd Bergmann @ 2017-11-02 14:34 UTC (permalink / raw)
To: Mathias Nyman, Greg Kroah-Hartman, Thierry Reding, Jonathan Hunter
Cc: Arnd Bergmann, Chunfeng Yun, linux-usb, linux-tegra, linux-kernel
The time_t type and time_to_tm() function are deprecated because
of y2038 problems. In this driver, they are used to pretty-print
the timestamp of the firmware build. This is fine as long as
we don't get a firmware build past 2038.
Converting to time64_t and time64_to_tm() avoids the deprecated
interfaces and works until 2106, when the firmware-defined
data structure overflows.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/usb/host/xhci-tegra.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/xhci-tegra.c b/drivers/usb/host/xhci-tegra.c
index 74436f8ca538..39b6e93130d3 100644
--- a/drivers/usb/host/xhci-tegra.c
+++ b/drivers/usb/host/xhci-tegra.c
@@ -771,7 +771,7 @@ static int tegra_xusb_load_firmware(struct tegra_xusb *tegra)
struct device *dev = tegra->dev;
const struct firmware *fw;
unsigned long timeout;
- time_t timestamp;
+ time64_t timestamp;
struct tm time;
u64 address;
u32 value;
@@ -877,7 +877,7 @@ static int tegra_xusb_load_firmware(struct tegra_xusb *tegra)
}
timestamp = le32_to_cpu(header->fwimg_created_time);
- time_to_tm(timestamp, 0, &time);
+ time64_to_tm(timestamp, 0, &time);
dev_info(dev, "Firmware timestamp: %ld-%02d-%02d %02d:%02d:%02d UTC\n",
time.tm_year + 1900, time.tm_mon + 1, time.tm_mday,
--
2.9.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] usb: xhci: tegra: use time64_t for printing timestamp
2017-11-02 14:34 [PATCH] usb: xhci: tegra: use time64_t for printing timestamp Arnd Bergmann
@ 2017-11-02 16:17 ` Thierry Reding
0 siblings, 0 replies; 4+ messages in thread
From: Thierry Reding @ 2017-11-02 16:17 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Mathias Nyman, Greg Kroah-Hartman, Jonathan Hunter, Chunfeng Yun,
linux-usb, linux-tegra, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 673 bytes --]
On Thu, Nov 02, 2017 at 03:34:27PM +0100, Arnd Bergmann wrote:
> The time_t type and time_to_tm() function are deprecated because
> of y2038 problems. In this driver, they are used to pretty-print
> the timestamp of the firmware build. This is fine as long as
> we don't get a firmware build past 2038.
>
> Converting to time64_t and time64_to_tm() avoids the deprecated
> interfaces and works until 2106, when the firmware-defined
> data structure overflows.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/usb/host/xhci-tegra.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] usb: xhci: tegra: use time64_t for printing timestamp
2017-10-20 7:19 Arnd Bergmann
@ 2017-10-20 10:37 ` Mathias Nyman
0 siblings, 0 replies; 4+ messages in thread
From: Mathias Nyman @ 2017-10-20 10:37 UTC (permalink / raw)
To: Arnd Bergmann, Greg Kroah-Hartman, Thierry Reding, Jonathan Hunter
Cc: Chunfeng Yun, linux-usb, linux-tegra, linux-kernel
On 20.10.2017 10:19, Arnd Bergmann wrote:
> The time_t type and time_to_tm() function are deprecated because
> of y2038 problems. In this driver, they are used to pretty-print
> the timestamp of the firmware build. This is fine as long as
> we don't get a firmware build past 2038.
>
> Converting to time64_t and time64_to_tm() avoids the deprecated
> interfaces and works until 2106, when the firmware-defined
> data structure overflows.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/usb/host/xhci-tegra.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/host/xhci-tegra.c b/drivers/usb/host/xhci-tegra.c
> index 74436f8ca538..39b6e93130d3 100644
> --- a/drivers/usb/host/xhci-tegra.c
> +++ b/drivers/usb/host/xhci-tegra.c
> @@ -771,7 +771,7 @@ static int tegra_xusb_load_firmware(struct tegra_xusb *tegra)
> struct device *dev = tegra->dev;
> const struct firmware *fw;
> unsigned long timeout;
> - time_t timestamp;
> + time64_t timestamp;
> struct tm time;
> u64 address;
> u32 value;
> @@ -877,7 +877,7 @@ static int tegra_xusb_load_firmware(struct tegra_xusb *tegra)
> }
>
> timestamp = le32_to_cpu(header->fwimg_created_time);
> - time_to_tm(timestamp, 0, &time);
> + time64_to_tm(timestamp, 0, &time);
>
> dev_info(dev, "Firmware timestamp: %ld-%02d-%02d %02d:%02d:%02d UTC\n",
> time.tm_year + 1900, time.tm_mon + 1, time.tm_mday,
>
Thanks, adding to queue
-Mathias
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] usb: xhci: tegra: use time64_t for printing timestamp
@ 2017-10-20 7:19 Arnd Bergmann
2017-10-20 10:37 ` Mathias Nyman
0 siblings, 1 reply; 4+ messages in thread
From: Arnd Bergmann @ 2017-10-20 7:19 UTC (permalink / raw)
To: Mathias Nyman, Greg Kroah-Hartman, Thierry Reding, Jonathan Hunter
Cc: Arnd Bergmann, Chunfeng Yun, linux-usb, linux-tegra, linux-kernel
The time_t type and time_to_tm() function are deprecated because
of y2038 problems. In this driver, they are used to pretty-print
the timestamp of the firmware build. This is fine as long as
we don't get a firmware build past 2038.
Converting to time64_t and time64_to_tm() avoids the deprecated
interfaces and works until 2106, when the firmware-defined
data structure overflows.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/usb/host/xhci-tegra.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/xhci-tegra.c b/drivers/usb/host/xhci-tegra.c
index 74436f8ca538..39b6e93130d3 100644
--- a/drivers/usb/host/xhci-tegra.c
+++ b/drivers/usb/host/xhci-tegra.c
@@ -771,7 +771,7 @@ static int tegra_xusb_load_firmware(struct tegra_xusb *tegra)
struct device *dev = tegra->dev;
const struct firmware *fw;
unsigned long timeout;
- time_t timestamp;
+ time64_t timestamp;
struct tm time;
u64 address;
u32 value;
@@ -877,7 +877,7 @@ static int tegra_xusb_load_firmware(struct tegra_xusb *tegra)
}
timestamp = le32_to_cpu(header->fwimg_created_time);
- time_to_tm(timestamp, 0, &time);
+ time64_to_tm(timestamp, 0, &time);
dev_info(dev, "Firmware timestamp: %ld-%02d-%02d %02d:%02d:%02d UTC\n",
time.tm_year + 1900, time.tm_mon + 1, time.tm_mday,
--
2.9.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-11-02 16:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-02 14:34 [PATCH] usb: xhci: tegra: use time64_t for printing timestamp Arnd Bergmann
2017-11-02 16:17 ` Thierry Reding
-- strict thread matches above, loose matches on Subject: below --
2017-10-20 7:19 Arnd Bergmann
2017-10-20 10:37 ` Mathias Nyman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).