* [PATCH] crypto: ccp: remove unused variable qim
@ 2017-10-12 16:55 Colin King
2017-10-17 22:12 ` Gary R Hook
2017-11-03 14:23 ` Herbert Xu
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2017-10-12 16:55 UTC (permalink / raw)
To: Tom Lendacky, Gary Hook, David S . Miller, linux-crypto
Cc: kernel-janitors, Herbert Xu, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Variable qim is assigned but never read, it is redundant and can
be removed.
Cleans up clang warning: Value stored to 'qim' is never read
Fixes: 4b394a232df7 ("crypto: ccp - Let a v5 CCP provide the same function as v3")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/crypto/ccp/ccp-dev-v5.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/crypto/ccp/ccp-dev-v5.c b/drivers/crypto/ccp/ccp-dev-v5.c
index 65604fc65e8f..44a4d2779b15 100644
--- a/drivers/crypto/ccp/ccp-dev-v5.c
+++ b/drivers/crypto/ccp/ccp-dev-v5.c
@@ -788,13 +788,12 @@ static int ccp5_init(struct ccp_device *ccp)
struct ccp_cmd_queue *cmd_q;
struct dma_pool *dma_pool;
char dma_pool_name[MAX_DMAPOOL_NAME_LEN];
- unsigned int qmr, qim, i;
+ unsigned int qmr, i;
u64 status;
u32 status_lo, status_hi;
int ret;
/* Find available queues */
- qim = 0;
qmr = ioread32(ccp->io_regs + Q_MASK_REG);
for (i = 0; i < MAX_HW_QUEUES; i++) {
--
2.14.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] crypto: ccp: remove unused variable qim
2017-10-12 16:55 [PATCH] crypto: ccp: remove unused variable qim Colin King
@ 2017-10-17 22:12 ` Gary R Hook
2017-11-03 14:23 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Gary R Hook @ 2017-10-17 22:12 UTC (permalink / raw)
To: Colin King, Tom Lendacky, David S . Miller, linux-crypto
Cc: kernel-janitors, Herbert Xu, linux-kernel
On 10/12/2017 11:55 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable qim is assigned but never read, it is redundant and can
> be removed.
>
> Cleans up clang warning: Value stored to 'qim' is never read
>
> Fixes: 4b394a232df7 ("crypto: ccp - Let a v5 CCP provide the same function as v3")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Gary R Hook <gary.hook@amd.com>
> ---
> drivers/crypto/ccp/ccp-dev-v5.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/crypto/ccp/ccp-dev-v5.c b/drivers/crypto/ccp/ccp-dev-v5.c
> index 65604fc65e8f..44a4d2779b15 100644
> --- a/drivers/crypto/ccp/ccp-dev-v5.c
> +++ b/drivers/crypto/ccp/ccp-dev-v5.c
> @@ -788,13 +788,12 @@ static int ccp5_init(struct ccp_device *ccp)
> struct ccp_cmd_queue *cmd_q;
> struct dma_pool *dma_pool;
> char dma_pool_name[MAX_DMAPOOL_NAME_LEN];
> - unsigned int qmr, qim, i;
> + unsigned int qmr, i;
> u64 status;
> u32 status_lo, status_hi;
> int ret;
>
> /* Find available queues */
> - qim = 0;
> qmr = ioread32(ccp->io_regs + Q_MASK_REG);
> for (i = 0; i < MAX_HW_QUEUES; i++) {
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] crypto: ccp: remove unused variable qim
2017-10-12 16:55 [PATCH] crypto: ccp: remove unused variable qim Colin King
2017-10-17 22:12 ` Gary R Hook
@ 2017-11-03 14:23 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2017-11-03 14:23 UTC (permalink / raw)
To: Colin King
Cc: Tom Lendacky, Gary Hook, David S . Miller, linux-crypto,
kernel-janitors, linux-kernel
On Thu, Oct 12, 2017 at 05:55:41PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable qim is assigned but never read, it is redundant and can
> be removed.
>
> Cleans up clang warning: Value stored to 'qim' is never read
>
> Fixes: 4b394a232df7 ("crypto: ccp - Let a v5 CCP provide the same function as v3")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-03 14:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-12 16:55 [PATCH] crypto: ccp: remove unused variable qim Colin King
2017-10-17 22:12 ` Gary R Hook
2017-11-03 14:23 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).