* [PATCH] clk: meson: gxbb: fix wrong clock for SARADC
@ 2017-11-03 18:17 Yixun Lan
2017-11-04 8:41 ` Yixun Lan
0 siblings, 1 reply; 4+ messages in thread
From: Yixun Lan @ 2017-11-03 18:17 UTC (permalink / raw)
To: Neil Armstrong, Jerome Brunet
Cc: Michael Turquette, Stephen Boyd, Carlo Caione, Kevin Hilman,
linux-amlogic, linux-clk, linux-arm-kernel, linux-kernel,
Yixun Lan
According to the datasheet, the clock gate bit for
SARADC is bit[22] in Meson-GXBB/GXL series.
Change-Id: Ic4fa58276d2a9ea273eef0a08541fc213ac5ac89
Signed-off-by: Yixun Lan <yixun.lan@amlogic.com>
---
drivers/clk/meson/gxbb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/meson/gxbb.c b/drivers/clk/meson/gxbb.c
index b2d1e8ed7152..4f5b535fcd12 100644
--- a/drivers/clk/meson/gxbb.c
+++ b/drivers/clk/meson/gxbb.c
@@ -1139,7 +1139,6 @@ static MESON_GATE(gxbb_pl301, HHI_GCLK_MPEG0, 6);
static MESON_GATE(gxbb_periphs, HHI_GCLK_MPEG0, 7);
static MESON_GATE(gxbb_spicc, HHI_GCLK_MPEG0, 8);
static MESON_GATE(gxbb_i2c, HHI_GCLK_MPEG0, 9);
-static MESON_GATE(gxbb_sar_adc, HHI_GCLK_MPEG0, 10);
static MESON_GATE(gxbb_smart_card, HHI_GCLK_MPEG0, 11);
static MESON_GATE(gxbb_rng0, HHI_GCLK_MPEG0, 12);
static MESON_GATE(gxbb_uart0, HHI_GCLK_MPEG0, 13);
@@ -1149,6 +1148,7 @@ static MESON_GATE(gxbb_async_fifo, HHI_GCLK_MPEG0, 16);
static MESON_GATE(gxbb_sdio, HHI_GCLK_MPEG0, 17);
static MESON_GATE(gxbb_abuf, HHI_GCLK_MPEG0, 18);
static MESON_GATE(gxbb_hiu_iface, HHI_GCLK_MPEG0, 19);
+static MESON_GATE(gxbb_sar_adc, HHI_GCLK_MPEG0, 22);
static MESON_GATE(gxbb_assist_misc, HHI_GCLK_MPEG0, 23);
static MESON_GATE(gxbb_emmc_a, HHI_GCLK_MPEG0, 24);
static MESON_GATE(gxbb_emmc_b, HHI_GCLK_MPEG0, 25);
--
2.14.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] clk: meson: gxbb: fix wrong clock for SARADC
2017-11-03 18:17 [PATCH] clk: meson: gxbb: fix wrong clock for SARADC Yixun Lan
@ 2017-11-04 8:41 ` Yixun Lan
2017-11-04 16:40 ` Neil Armstrong
0 siblings, 1 reply; 4+ messages in thread
From: Yixun Lan @ 2017-11-04 8:41 UTC (permalink / raw)
To: Neil Armstrong, Jerome Brunet
Cc: yixun.lan, Michael Turquette, Stephen Boyd, Carlo Caione,
Kevin Hilman, linux-amlogic, linux-clk, linux-arm-kernel,
linux-kernel
On 11/04/17 02:17, Yixun Lan wrote:
> According to the datasheet, the clock gate bit for
> SARADC is bit[22] in Meson-GXBB/GXL series.
>
> Change-Id: Ic4fa58276d2a9ea273eef0a08541fc213ac5ac89
> Signed-off-by: Yixun Lan <yixun.lan@amlogic.com>
> ---
> drivers/clk/meson/gxbb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/meson/gxbb.c b/drivers/clk/meson/gxbb.c
> index b2d1e8ed7152..4f5b535fcd12 100644
> --- a/drivers/clk/meson/gxbb.c
> +++ b/drivers/clk/meson/gxbb.c
> @@ -1139,7 +1139,6 @@ static MESON_GATE(gxbb_pl301, HHI_GCLK_MPEG0, 6);
> static MESON_GATE(gxbb_periphs, HHI_GCLK_MPEG0, 7);
> static MESON_GATE(gxbb_spicc, HHI_GCLK_MPEG0, 8);
> static MESON_GATE(gxbb_i2c, HHI_GCLK_MPEG0, 9);
> -static MESON_GATE(gxbb_sar_adc, HHI_GCLK_MPEG0, 10);
> static MESON_GATE(gxbb_smart_card, HHI_GCLK_MPEG0, 11);
> static MESON_GATE(gxbb_rng0, HHI_GCLK_MPEG0, 12);
> static MESON_GATE(gxbb_uart0, HHI_GCLK_MPEG0, 13);
> @@ -1149,6 +1148,7 @@ static MESON_GATE(gxbb_async_fifo, HHI_GCLK_MPEG0, 16);
> static MESON_GATE(gxbb_sdio, HHI_GCLK_MPEG0, 17);
> static MESON_GATE(gxbb_abuf, HHI_GCLK_MPEG0, 18);
> static MESON_GATE(gxbb_hiu_iface, HHI_GCLK_MPEG0, 19);
> +static MESON_GATE(gxbb_sar_adc, HHI_GCLK_MPEG0, 22);
> static MESON_GATE(gxbb_assist_misc, HHI_GCLK_MPEG0, 23);
> static MESON_GATE(gxbb_emmc_a, HHI_GCLK_MPEG0, 24);
> static MESON_GATE(gxbb_emmc_b, HHI_GCLK_MPEG0, 25);
>
Hi Neil
I assume you will take this via the clk-meson tree..
could you amend the commit msg and drop the 'Change-Id'?
(for other parts, please feel free to adjust if you see fit)
thanks
Yixun
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] clk: meson: gxbb: fix wrong clock for SARADC
2017-11-04 8:41 ` Yixun Lan
@ 2017-11-04 16:40 ` Neil Armstrong
2017-11-06 2:56 ` Yixun Lan
0 siblings, 1 reply; 4+ messages in thread
From: Neil Armstrong @ 2017-11-04 16:40 UTC (permalink / raw)
To: Yixun Lan, Jerome Brunet
Cc: Michael Turquette, Stephen Boyd, Carlo Caione, Kevin Hilman,
linux-amlogic, linux-clk, linux-arm-kernel, linux-kernel
Hi Yixun,
Le 04/11/2017 09:41, Yixun Lan a écrit :
>
>
> On 11/04/17 02:17, Yixun Lan wrote:
>> According to the datasheet, the clock gate bit for
>> SARADC is bit[22] in Meson-GXBB/GXL series.
>>
>> Change-Id: Ic4fa58276d2a9ea273eef0a08541fc213ac5ac89
>> Signed-off-by: Yixun Lan <yixun.lan@amlogic.com>
>> ---
>> drivers/clk/meson/gxbb.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/clk/meson/gxbb.c b/drivers/clk/meson/gxbb.c
>> index b2d1e8ed7152..4f5b535fcd12 100644
>> --- a/drivers/clk/meson/gxbb.c
>> +++ b/drivers/clk/meson/gxbb.c
>> @@ -1139,7 +1139,6 @@ static MESON_GATE(gxbb_pl301, HHI_GCLK_MPEG0, 6);
>> static MESON_GATE(gxbb_periphs, HHI_GCLK_MPEG0, 7);
>> static MESON_GATE(gxbb_spicc, HHI_GCLK_MPEG0, 8);
>> static MESON_GATE(gxbb_i2c, HHI_GCLK_MPEG0, 9);
>> -static MESON_GATE(gxbb_sar_adc, HHI_GCLK_MPEG0, 10);
>> static MESON_GATE(gxbb_smart_card, HHI_GCLK_MPEG0, 11);
>> static MESON_GATE(gxbb_rng0, HHI_GCLK_MPEG0, 12);
>> static MESON_GATE(gxbb_uart0, HHI_GCLK_MPEG0, 13);
>> @@ -1149,6 +1148,7 @@ static MESON_GATE(gxbb_async_fifo, HHI_GCLK_MPEG0, 16);
>> static MESON_GATE(gxbb_sdio, HHI_GCLK_MPEG0, 17);
>> static MESON_GATE(gxbb_abuf, HHI_GCLK_MPEG0, 18);
>> static MESON_GATE(gxbb_hiu_iface, HHI_GCLK_MPEG0, 19);
>> +static MESON_GATE(gxbb_sar_adc, HHI_GCLK_MPEG0, 22);
>> static MESON_GATE(gxbb_assist_misc, HHI_GCLK_MPEG0, 23);
>> static MESON_GATE(gxbb_emmc_a, HHI_GCLK_MPEG0, 24);
>> static MESON_GATE(gxbb_emmc_b, HHI_GCLK_MPEG0, 25);
>>
> Hi Neil
> I assume you will take this via the clk-meson tree..
> could you amend the commit msg and drop the 'Change-Id'?
> (for other parts, please feel free to adjust if you see fit)
> thanks
Yes, I will push it as a fix.
Can you check if the saradc driver is still functional when applied ?
Neil
>
> Yixun
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] clk: meson: gxbb: fix wrong clock for SARADC
2017-11-04 16:40 ` Neil Armstrong
@ 2017-11-06 2:56 ` Yixun Lan
0 siblings, 0 replies; 4+ messages in thread
From: Yixun Lan @ 2017-11-06 2:56 UTC (permalink / raw)
To: Neil Armstrong, Jerome Brunet
Cc: yixun.lan, Michael Turquette, Stephen Boyd, Carlo Caione,
Kevin Hilman, linux-amlogic, linux-clk, linux-arm-kernel,
linux-kernel
Hi Neil
On 11/05/17 00:40, Neil Armstrong wrote:
> Hi Yixun,
>
> Le 04/11/2017 09:41, Yixun Lan a écrit :
>>
>>
>> On 11/04/17 02:17, Yixun Lan wrote:
>>> According to the datasheet, the clock gate bit for
>>> SARADC is bit[22] in Meson-GXBB/GXL series.
>>>
>>> Change-Id: Ic4fa58276d2a9ea273eef0a08541fc213ac5ac89
>>> Signed-off-by: Yixun Lan <yixun.lan@amlogic.com>
>>> ---
>>> drivers/clk/meson/gxbb.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/clk/meson/gxbb.c b/drivers/clk/meson/gxbb.c
>>> index b2d1e8ed7152..4f5b535fcd12 100644
>>> --- a/drivers/clk/meson/gxbb.c
>>> +++ b/drivers/clk/meson/gxbb.c
>>> @@ -1139,7 +1139,6 @@ static MESON_GATE(gxbb_pl301, HHI_GCLK_MPEG0, 6);
>>> static MESON_GATE(gxbb_periphs, HHI_GCLK_MPEG0, 7);
>>> static MESON_GATE(gxbb_spicc, HHI_GCLK_MPEG0, 8);
>>> static MESON_GATE(gxbb_i2c, HHI_GCLK_MPEG0, 9);
>>> -static MESON_GATE(gxbb_sar_adc, HHI_GCLK_MPEG0, 10);
>>> static MESON_GATE(gxbb_smart_card, HHI_GCLK_MPEG0, 11);
>>> static MESON_GATE(gxbb_rng0, HHI_GCLK_MPEG0, 12);
>>> static MESON_GATE(gxbb_uart0, HHI_GCLK_MPEG0, 13);
>>> @@ -1149,6 +1148,7 @@ static MESON_GATE(gxbb_async_fifo, HHI_GCLK_MPEG0, 16);
>>> static MESON_GATE(gxbb_sdio, HHI_GCLK_MPEG0, 17);
>>> static MESON_GATE(gxbb_abuf, HHI_GCLK_MPEG0, 18);
>>> static MESON_GATE(gxbb_hiu_iface, HHI_GCLK_MPEG0, 19);
>>> +static MESON_GATE(gxbb_sar_adc, HHI_GCLK_MPEG0, 22);
>>> static MESON_GATE(gxbb_assist_misc, HHI_GCLK_MPEG0, 23);
>>> static MESON_GATE(gxbb_emmc_a, HHI_GCLK_MPEG0, 24);
>>> static MESON_GATE(gxbb_emmc_b, HHI_GCLK_MPEG0, 25);
>>>
>> Hi Neil
>> I assume you will take this via the clk-meson tree..
>> could you amend the commit msg and drop the 'Change-Id'?
>> (for other parts, please feel free to adjust if you see fit)
>> thanks
>
> Yes, I will push it as a fix.
>
> Can you check if the saradc driver is still functional when applied ?
>
sorry, this isn't a correct fix.
please drop this one, and I will push another patch
> Neil
>
>>
>> Yixun
>>
>
> .
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-11-06 2:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-03 18:17 [PATCH] clk: meson: gxbb: fix wrong clock for SARADC Yixun Lan
2017-11-04 8:41 ` Yixun Lan
2017-11-04 16:40 ` Neil Armstrong
2017-11-06 2:56 ` Yixun Lan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).