From: Colin King <colin.king@canonical.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] devcoredump: remove redundant assignment to iter
Date: Tue, 7 Nov 2017 10:42:15 +0000 [thread overview]
Message-ID: <20171107104215.10748-1-colin.king@canonical.com> (raw)
From: Colin Ian King <colin.king@canonical.com>
The assignment to pointer iter is redundant as this is also performed
in the following macro for_each_sg, hence it can be removed. Cleans
up clang warning:
./include/linux/devcoredump.h:45:2: warning: Value stored to 'iter'
is never read
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
include/linux/devcoredump.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/linux/devcoredump.h b/include/linux/devcoredump.h
index 269521f143ac..a9f3e2480739 100644
--- a/include/linux/devcoredump.h
+++ b/include/linux/devcoredump.h
@@ -42,7 +42,6 @@ static inline void _devcd_free_sgtable(struct scatterlist *table)
struct scatterlist *delete_iter;
/* free pages */
- iter = table;
for_each_sg(table, iter, sg_nents(table), i) {
page = sg_page(iter);
if (page)
--
2.14.1
next reply other threads:[~2017-11-07 10:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-07 10:42 Colin King [this message]
2017-11-08 1:06 ` [PATCH] devcoredump: remove redundant assignment to iter Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171107104215.10748-1-colin.king@canonical.com \
--to=colin.king@canonical.com \
--cc=johannes@sipsolutions.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).