[PATCH] devcoredump: remove redundant assignment to iter

[PATCH] devcoredump: remove redundant assignment to iter

[Colin King]

From: Colin Ian King <colin.king@canonical.com>

The assignment to pointer iter is redundant as this is also performed
in the following macro for_each_sg, hence it can be removed. Cleans
up clang warning:

./include/linux/devcoredump.h:45:2: warning: Value stored to 'iter'
is never read

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 include/linux/devcoredump.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/include/linux/devcoredump.h b/include/linux/devcoredump.h
index 269521f143ac..a9f3e2480739 100644
--- a/include/linux/devcoredump.h
+++ b/include/linux/devcoredump.h
@@ -42,7 +42,6 @@ static inline void _devcd_free_sgtable(struct scatterlist *table)
 	struct scatterlist *delete_iter;
 
 	/* free pages */
-	iter = table;
 	for_each_sg(table, iter, sg_nents(table), i) {
 		page = sg_page(iter);
 		if (page)
-- 
2.14.1

Re: [PATCH] devcoredump: remove redundant assignment to iter

[Johannes Berg]

On Tue, 2017-11-07 at 10:42 +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The assignment to pointer iter is redundant as this is also performed
> in the following macro for_each_sg, hence it can be removed. Cleans
> up clang warning:
> 
> ./include/linux/devcoredump.h:45:2: warning: Value stored to 'iter'
> is never read
> 
I think you'll have to Cc Greg KH to get this applied, unless somebody
picks it up from janitors.

johannes