* [PATCH 1/1] add mali r6p2 dt node
@ 2017-11-07 10:03 Giulio Benetti
2017-11-07 11:05 ` Maxime Ripard
0 siblings, 1 reply; 7+ messages in thread
From: Giulio Benetti @ 2017-11-07 10:03 UTC (permalink / raw)
To: robh+dt
Cc: mark.rutland, linux, maxime.ripard, wens, devicetree,
linux-arm-kernel, linux-kernel, Giulio Benetti
This patch adds device tree mali node compatible with r6p2 utgard kernel driver
provided by ARM and patched by maxime ripard on his github.
It can be easily used in target.dts with:
&mali {
status = "okay";
}
then loading mali.ko in user space.
Best regards
Giulio Benetti
Micronova srl
Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
---
arch/arm/boot/dts/sun7i-a20.dtsi | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)
diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi
index 228c368..e402596 100644
--- a/arch/arm/boot/dts/sun7i-a20.dtsi
+++ b/arch/arm/boot/dts/sun7i-a20.dtsi
@@ -1216,6 +1216,33 @@
#size-cells = <0>;
};
+ mali: gpu@1c40000 {
+ compatible = "allwinner,sun8i-a23-mali",
+ "allwinner,sun7i-a20-mali", "arm,mali-400";
+ reg = <0x01c40000 0x10000>;
+ interrupts = <GIC_SPI 69 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 70 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 71 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 74 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 75 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "gp",
+ "gpmmu",
+ "pp0",
+ "ppmmu0",
+ "pp1",
+ "ppmmu1",
+ "pmu";
+ clocks = <&ccu CLK_AHB_GPU>, <&ccu CLK_GPU>;
+ clock-names = "bus", "core";
+ resets = <&ccu RST_GPU>;
+ #cooling-cells = <2>;
+
+ assigned-clocks = <&ccu CLK_GPU>;
+ assigned-clock-rates = <381000000>;
+ };
+
gmac: ethernet@1c50000 {
compatible = "allwinner,sun7i-a20-gmac";
reg = <0x01c50000 0x10000>;
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] add mali r6p2 dt node
2017-11-07 10:03 [PATCH 1/1] add mali r6p2 dt node Giulio Benetti
@ 2017-11-07 11:05 ` Maxime Ripard
2017-11-07 17:55 ` Giulio Benetti
0 siblings, 1 reply; 7+ messages in thread
From: Maxime Ripard @ 2017-11-07 11:05 UTC (permalink / raw)
To: Giulio Benetti
Cc: robh+dt, mark.rutland, linux, wens, devicetree, linux-arm-kernel,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 2471 bytes --]
Hi,
On Tue, Nov 07, 2017 at 11:03:30AM +0100, Giulio Benetti wrote:
> This patch adds device tree mali node compatible with r6p2 utgard kernel driver
> provided by ARM and patched by maxime ripard on his github.
>
> It can be easily used in target.dts with:
>
> &mali {
> status = "okay";
> }
>
> then loading mali.ko in user space.
>
> Best regards
> Giulio Benetti
> Micronova srl
Again, you should have a proper commit log here.
Moreover, the DT binding itself doesn't have a dependency on the mali
driver version. This is just a description of the hardware so you
shouldn't mention it.
And there's no need for the status = "okay" in the board DTS, since
you don't disable it in your patch.
> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
> ---
> arch/arm/boot/dts/sun7i-a20.dtsi | 27 +++++++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi
> index 228c368..e402596 100644
> --- a/arch/arm/boot/dts/sun7i-a20.dtsi
> +++ b/arch/arm/boot/dts/sun7i-a20.dtsi
> @@ -1216,6 +1216,33 @@
> #size-cells = <0>;
> };
>
> + mali: gpu@1c40000 {
> + compatible = "allwinner,sun8i-a23-mali",
This doesn't make any sense. The A23 went out later, and...
> + "allwinner,sun7i-a20-mali", "arm,mali-400";
You're actually using the proper compatible already.
> + reg = <0x01c40000 0x10000>;
> + interrupts = <GIC_SPI 69 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 70 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 71 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 74 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 75 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "gp",
> + "gpmmu",
> + "pp0",
> + "ppmmu0",
> + "pp1",
> + "ppmmu1",
> + "pmu";
> + clocks = <&ccu CLK_AHB_GPU>, <&ccu CLK_GPU>;
> + clock-names = "bus", "core";
> + resets = <&ccu RST_GPU>;
> + #cooling-cells = <2>;
This isn't needed unless you're using thermal throttling, but in this
case you would also need to add the OPPs.
> +
> + assigned-clocks = <&ccu CLK_GPU>;
> + assigned-clock-rates = <381000000>;
And this should be in the driver instead.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] add mali r6p2 dt node
2017-11-07 11:05 ` Maxime Ripard
@ 2017-11-07 17:55 ` Giulio Benetti
2017-11-09 13:40 ` Maxime Ripard
0 siblings, 1 reply; 7+ messages in thread
From: Giulio Benetti @ 2017-11-07 17:55 UTC (permalink / raw)
To: Maxime Ripard
Cc: robh+dt, mark.rutland, linux, wens, devicetree, linux-arm-kernel,
linux-kernel
Hi,
Il 07/11/2017 12:05, Maxime Ripard ha scritto:
> Hi,
>
> On Tue, Nov 07, 2017 at 11:03:30AM +0100, Giulio Benetti wrote:
>> This patch adds device tree mali node compatible with r6p2 utgard kernel driver
>> provided by ARM and patched by maxime ripard on his github.
>>
>> It can be easily used in target.dts with:
>>
>> &mali {
>> status = "okay";
>> }
>>
>> then loading mali.ko in user space.
>>
>> Best regards
>> Giulio Benetti
>> Micronova srl
>
> Again, you should have a proper commit log here.
As log could it be:
It seems there is not mali node in sun7i-a20.dtsi << This is "Why"
Add mali node to sun7i-a20.dtsi << This is "How"
Or can you point me to some example?
I've tried to check lot of other patches,
but really I can't understand which is the right way.
>
> Moreover, the DT binding itself doesn't have a dependency on the mali
> driver version. This is just a description of the hardware so you
> shouldn't mention it.
Right
>
> And there's no need for the status = "okay" in the board DTS, since
> you don't disable it in your patch.
Right
>
>> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
>> ---
>> arch/arm/boot/dts/sun7i-a20.dtsi | 27 +++++++++++++++++++++++++++
>> 1 file changed, 27 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi
>> index 228c368..e402596 100644
>> --- a/arch/arm/boot/dts/sun7i-a20.dtsi
>> +++ b/arch/arm/boot/dts/sun7i-a20.dtsi
>> @@ -1216,6 +1216,33 @@
>> #size-cells = <0>;
>> };
>>
>> + mali: gpu@1c40000 {
>> + compatible = "allwinner,sun8i-a23-mali",
>
> This doesn't make any sense. The A23 went out later, and...
>
>> + "allwinner,sun7i-a20-mali", "arm,mali-400";
>
> You're actually using the proper compatible already.
So I will delete "allwinner,sun8i-a23-mali",
>
>> + reg = <0x01c40000 0x10000>;
>> + interrupts = <GIC_SPI 69 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 70 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 71 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 74 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 75 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>;
>> + interrupt-names = "gp",
>> + "gpmmu",
>> + "pp0",
>> + "ppmmu0",
>> + "pp1",
>> + "ppmmu1",
>> + "pmu";
>> + clocks = <&ccu CLK_AHB_GPU>, <&ccu CLK_GPU>;
>> + clock-names = "bus", "core";
>> + resets = <&ccu RST_GPU>;
>> + #cooling-cells = <2>;
>
> This isn't needed unless you're using thermal throttling, but in this
> case you would also need to add the OPPs.
Right,
but at this time OPPs are not ready,
so I can delete #cooling-cells = <2>;
>
>> +
>> + assigned-clocks = <&ccu CLK_GPU>;
>> + assigned-clock-rates = <381000000>;
>
> And this should be in the driver instead.
So it's useless and I will remove that
>
> Maxime
>
Now, to avoid any possible other mistake,
do I have to resubmit patch corrected answering to this thread,
when you give me the ok?
PS. Sorry for the mess with double patches,
but I did a mess with mailing lists
and I'm new to this.
Thank you
--
Giulio Benetti
R&D Manager &
Advanced Research
MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale € 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] add mali r6p2 dt node
2017-11-07 17:55 ` Giulio Benetti
@ 2017-11-09 13:40 ` Maxime Ripard
0 siblings, 0 replies; 7+ messages in thread
From: Maxime Ripard @ 2017-11-09 13:40 UTC (permalink / raw)
To: Giulio Benetti
Cc: robh+dt, mark.rutland, linux, wens, devicetree, linux-arm-kernel,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1556 bytes --]
On Tue, Nov 07, 2017 at 06:55:22PM +0100, Giulio Benetti wrote:
> Hi,
>
> Il 07/11/2017 12:05, Maxime Ripard ha scritto:
> > Hi,
> >
> > On Tue, Nov 07, 2017 at 11:03:30AM +0100, Giulio Benetti wrote:
> > > This patch adds device tree mali node compatible with r6p2 utgard kernel driver
> > > provided by ARM and patched by maxime ripard on his github.
> > >
> > > It can be easily used in target.dts with:
> > >
> > > &mali {
> > > status = "okay";
> > > }
> > >
> > > then loading mali.ko in user space.
> > >
> > > Best regards
> > > Giulio Benetti
> > > Micronova srl
> >
> > Again, you should have a proper commit log here.
>
> As log could it be:
> It seems there is not mali node in sun7i-a20.dtsi << This is "Why"
>
> Add mali node to sun7i-a20.dtsi << This is "How"
>
> Or can you point me to some example?
> I've tried to check lot of other patches,
> but really I can't understand which is the right way.
Not having your signature would be a good start, and describing the
changes would be great as well. You can comment on which Mali chip it
is for example, which variant, whether the BSP uses thermal throttling
or not, and if so why did you leave it out, which frequency it's
running at, etc.
> Now, to avoid any possible other mistake,
> do I have to resubmit patch corrected answering to this thread,
> when you give me the ok?
Please resend it yes.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] add mali r6p2 dt node
2017-11-07 12:59 Giulio Benetti
@ 2017-11-07 13:02 ` Maxime Ripard
0 siblings, 0 replies; 7+ messages in thread
From: Maxime Ripard @ 2017-11-07 13:02 UTC (permalink / raw)
To: Giulio Benetti
Cc: robh+dt, mark.rutland, linux, wens, devicetree, linux-arm-kernel,
linux-kernel, linux-sunxi
[-- Attachment #1: Type: text/plain, Size: 659 bytes --]
On Tue, Nov 07, 2017 at 01:59:03PM +0100, Giulio Benetti wrote:
> It seems there is not mali node in sun7i-a20.dtsi
>
> Add mali node to sun7i-a20.dtsi
>
> This patch adds device tree mali node compatible with r6p2 utgard kernel driver
> provided by ARM and patched by maxime ripard on his github.
>
> It can be easily used in target.dts with:
>
> &mali {
> status = "okay";
> }
>
> then loading mali.ko in user space.
Can you please stop sending the same patch over and over again without
making any changes?
Thanks,
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/1] add mali r6p2 dt node
@ 2017-11-07 12:59 Giulio Benetti
2017-11-07 13:02 ` Maxime Ripard
0 siblings, 1 reply; 7+ messages in thread
From: Giulio Benetti @ 2017-11-07 12:59 UTC (permalink / raw)
To: robh+dt
Cc: mark.rutland, linux, maxime.ripard, wens, devicetree,
linux-arm-kernel, linux-kernel, linux-sunxi, Giulio Benetti
It seems there is not mali node in sun7i-a20.dtsi
Add mali node to sun7i-a20.dtsi
This patch adds device tree mali node compatible with r6p2 utgard kernel driver
provided by ARM and patched by maxime ripard on his github.
It can be easily used in target.dts with:
&mali {
status = "okay";
}
then loading mali.ko in user space.
Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
---
arch/arm/boot/dts/sun7i-a20.dtsi | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)
diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi
index 228c368..e402596 100644
--- a/arch/arm/boot/dts/sun7i-a20.dtsi
+++ b/arch/arm/boot/dts/sun7i-a20.dtsi
@@ -1216,6 +1216,33 @@
#size-cells = <0>;
};
+ mali: gpu@1c40000 {
+ compatible = "allwinner,sun8i-a23-mali",
+ "allwinner,sun7i-a20-mali", "arm,mali-400";
+ reg = <0x01c40000 0x10000>;
+ interrupts = <GIC_SPI 69 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 70 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 71 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 74 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 75 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "gp",
+ "gpmmu",
+ "pp0",
+ "ppmmu0",
+ "pp1",
+ "ppmmu1",
+ "pmu";
+ clocks = <&ccu CLK_AHB_GPU>, <&ccu CLK_GPU>;
+ clock-names = "bus", "core";
+ resets = <&ccu RST_GPU>;
+ #cooling-cells = <2>;
+
+ assigned-clocks = <&ccu CLK_GPU>;
+ assigned-clock-rates = <381000000>;
+ };
+
gmac: ethernet@1c50000 {
compatible = "allwinner,sun7i-a20-gmac";
reg = <0x01c50000 0x10000>;
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 1/1] add mali r6p2 dt node
@ 2017-11-07 9:35 Giulio Benetti
0 siblings, 0 replies; 7+ messages in thread
From: Giulio Benetti @ 2017-11-07 9:35 UTC (permalink / raw)
To: robh+dt
Cc: mark.rutland, linux, maxime.ripard, wens, devicetree,
linux-arm-kernel, linux-kernel, Giulio Benetti
This patch adds device tree mali node compatible with r6p2 utgard kernel driver
provided by ARM and patched by maxime ripard on his github.
It can be easily used in target.dts with:
&mali {
status = "okay";
}
then loading mali.ko in user space.
Best regards
Giulio Benetti
Micronova srl
Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
---
arch/arm/boot/dts/sun7i-a20.dtsi | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)
diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi
index 228c368..e402596 100644
--- a/arch/arm/boot/dts/sun7i-a20.dtsi
+++ b/arch/arm/boot/dts/sun7i-a20.dtsi
@@ -1216,6 +1216,33 @@
#size-cells = <0>;
};
+ mali: gpu@1c40000 {
+ compatible = "allwinner,sun8i-a23-mali",
+ "allwinner,sun7i-a20-mali", "arm,mali-400";
+ reg = <0x01c40000 0x10000>;
+ interrupts = <GIC_SPI 69 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 70 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 71 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 74 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 75 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "gp",
+ "gpmmu",
+ "pp0",
+ "ppmmu0",
+ "pp1",
+ "ppmmu1",
+ "pmu";
+ clocks = <&ccu CLK_AHB_GPU>, <&ccu CLK_GPU>;
+ clock-names = "bus", "core";
+ resets = <&ccu RST_GPU>;
+ #cooling-cells = <2>;
+
+ assigned-clocks = <&ccu CLK_GPU>;
+ assigned-clock-rates = <381000000>;
+ };
+
gmac: ethernet@1c50000 {
compatible = "allwinner,sun7i-a20-gmac";
reg = <0x01c50000 0x10000>;
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-11-09 13:40 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-07 10:03 [PATCH 1/1] add mali r6p2 dt node Giulio Benetti
2017-11-07 11:05 ` Maxime Ripard
2017-11-07 17:55 ` Giulio Benetti
2017-11-09 13:40 ` Maxime Ripard
-- strict thread matches above, loose matches on Subject: below --
2017-11-07 12:59 Giulio Benetti
2017-11-07 13:02 ` Maxime Ripard
2017-11-07 9:35 Giulio Benetti
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).