[PATCH net-next] net: dsa: lan9303: Drop port range check

[PATCH net-next] net: dsa: lan9303: Drop port range check

[Egil Hjelmeland]

Now that ds->num_ports is 3, there is no need to check range of "port"
parameter.

Signed-off-by: Egil Hjelmeland <privat@egil-hjelmeland.no>
---
 drivers/net/dsa/lan9303-core.c | 27 ++++-----------------------
 1 file changed, 4 insertions(+), 23 deletions(-)

diff --git a/drivers/net/dsa/lan9303-core.c b/drivers/net/dsa/lan9303-core.c
index 70ecd18a5e7d..320651a57c6f 100644
--- a/drivers/net/dsa/lan9303-core.c
+++ b/drivers/net/dsa/lan9303-core.c
@@ -1057,17 +1057,7 @@ static int lan9303_port_enable(struct dsa_switch *ds, int port,
 {
 	struct lan9303 *chip = ds->priv;
 
-	/* enable internal packet processing */
-	switch (port) {
-	case 1:
-	case 2:
-		return lan9303_enable_processing_port(chip, port);
-	default:
-		dev_dbg(chip->dev,
-			"Error: request to power up invalid port %d\n", port);
-	}
-
-	return -ENODEV;
+	return lan9303_enable_processing_port(chip, port);
 }
 
 static void lan9303_port_disable(struct dsa_switch *ds, int port,
@@ -1075,18 +1065,9 @@ static void lan9303_port_disable(struct dsa_switch *ds, int port,
 {
 	struct lan9303 *chip = ds->priv;
 
-	/* disable internal packet processing */
-	switch (port) {
-	case 1:
-	case 2:
-		lan9303_disable_processing_port(chip, port);
-		lan9303_phy_write(ds, chip->phy_addr_sel_strap + port,
-				  MII_BMCR, BMCR_PDOWN);
-		break;
-	default:
-		dev_dbg(chip->dev,
-			"Error: request to power down invalid port %d\n", port);
-	}
+	lan9303_disable_processing_port(chip, port);
+	lan9303_phy_write(ds, chip->phy_addr_sel_strap + port,
+			  MII_BMCR, BMCR_PDOWN);
 }
 
 static int lan9303_port_bridge_join(struct dsa_switch *ds, int port,
-- 
2.11.0

Re: [PATCH net-next] net: dsa: lan9303: Drop port range check

[Egil Hjelmeland]

On 06. nov. 2017 15:19, Egil Hjelmeland wrote:
> Now that ds->num_ports is 3, there is no need to check range of "port"
> parameter.
> 
> +	lan9303_disable_processing_port(chip, port);
> +	lan9303_phy_write(ds, chip->phy_addr_sel_strap + port,
> +			  MII_BMCR, BMCR_PDOWN);
>   }

I see now that line breaking could be adjusted here. But I am going to 
touch that line in a upcomming patch about phy_addr_sel_strap. I
promise fix it then, making it to a one-liner.

>   
>   static int lan9303_port_bridge_join(struct dsa_switch *ds, int port,
> 

Egil

Re: [PATCH net-next] net: dsa: lan9303: Drop port range check

[David Miller]

From: Egil Hjelmeland <privat@egil-hjelmeland.no>
Date: Mon,  6 Nov 2017 15:19:49 +0100

> Now that ds->num_ports is 3, there is no need to check range of "port"
> parameter.
> 
> Signed-off-by: Egil Hjelmeland <privat@egil-hjelmeland.no>

Applied.