linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] qrtr: Move to postcore_initcall
@ 2017-11-07  4:50 Bjorn Andersson
  2017-11-08  5:33 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Bjorn Andersson @ 2017-11-07  4:50 UTC (permalink / raw)
  To: David S. Miller; +Cc: netdev, linux-kernel, linux-arm-msm

Registering qrtr with module_init makes the ability of typical platform
code to create AF_QIPCRTR socket during probe a matter of link order
luck. Moving qrtr to postcore_initcall() avoids this.

Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
 net/qrtr/qrtr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/qrtr/qrtr.c b/net/qrtr/qrtr.c
index e458ece96d3d..77ab05e23001 100644
--- a/net/qrtr/qrtr.c
+++ b/net/qrtr/qrtr.c
@@ -1120,7 +1120,7 @@ static int __init qrtr_proto_init(void)
 
 	return 0;
 }
-module_init(qrtr_proto_init);
+postcore_initcall(qrtr_proto_init);
 
 static void __exit qrtr_proto_fini(void)
 {
-- 
2.15.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] qrtr: Move to postcore_initcall
  2017-11-07  4:50 [PATCH] qrtr: Move to postcore_initcall Bjorn Andersson
@ 2017-11-08  5:33 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-11-08  5:33 UTC (permalink / raw)
  To: bjorn.andersson; +Cc: netdev, linux-kernel, linux-arm-msm

From: Bjorn Andersson <bjorn.andersson@linaro.org>
Date: Mon,  6 Nov 2017 20:50:35 -0800

> Registering qrtr with module_init makes the ability of typical platform
> code to create AF_QIPCRTR socket during probe a matter of link order
> luck. Moving qrtr to postcore_initcall() avoids this.
> 
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>

Applied.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-11-08  5:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-07  4:50 [PATCH] qrtr: Move to postcore_initcall Bjorn Andersson
2017-11-08  5:33 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).