linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Cornelia Huck <cohuck@redhat.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
	linux-kernel@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Martin Schwidefsky <schwidefsky@de.ibm.com>,
	Heiko Carstens <heiko.carstens@de.ibm.com>,
	linux-s390@vger.kernel.org
Subject: Re: [PATCH v2] s390/virtio: mark headers as BSD licensed
Date: Wed, 8 Nov 2017 19:15:31 +0100	[thread overview]
Message-ID: <20171108191531.2d2f7210.cohuck@redhat.com> (raw)
In-Reply-To: <9c2debae-5c00-75ad-bc4d-13af9c4f431d@de.ibm.com>

On Wed, 8 Nov 2017 19:12:25 +0100
Christian Borntraeger <borntraeger@de.ibm.com> wrote:

> On 11/08/2017 05:59 PM, Michael S. Tsirkin wrote:
> > Virtio UAPI headers aren't just for UAPI, it's for guests/hypervisors as
> > well.  The s390 ones need to be BSD as well.
> > 
> > Fixes: e2be04c7f995 ("License cleanup: add SPDX license identifier to uapi header files with a license")
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> > 
> > since v1:
> > 	drop an extra comment chunk, reported by Cornelia
> > 
> >  arch/s390/include/uapi/asm/kvm_virtio.h | 26 +++++++++++++++++++++++++-  
> 
> FWIW, this file will go away anyway. 
> Looks like the following commit in the s390 feature branch 
> https://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git/commit/drivers/s390/virtio/Makefile?h=features&id=7fb2b2d512448cf0e914c4647a1cf02b52263702
> missed this file.

Can we simply rip this out?

> 
> 
> Regarding the virtio-ccw.h headers it is probably something that happened by accident.
> Back then Rusty (as an IBMer) proposed to change all virtio headers to BSD licence.

ISTR that the relicensing already went through... is that not the case?
I thought this was just a fixup to align with reality?

> 
> >  arch/s390/include/uapi/asm/virtio-ccw.h | 26 +++++++++++++++++++++++++-
> >  2 files changed, 50 insertions(+), 2 deletions(-)

  reply	other threads:[~2017-11-08 18:15 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-08 16:59 [PATCH v2] s390/virtio: mark headers as BSD licensed Michael S. Tsirkin
2017-11-08 17:01 ` Michael S. Tsirkin
2017-11-08 17:28   ` Cornelia Huck
2017-11-08 17:02 ` Cornelia Huck
2017-11-08 18:10 ` Heiko Carstens
2017-11-08 18:12 ` Christian Borntraeger
2017-11-08 18:15   ` Cornelia Huck [this message]
2017-11-08 18:33     ` Christian Borntraeger
2017-11-08 18:57       ` Christian Borntraeger
2017-11-08 18:59         ` Christian Borntraeger
2017-11-08 19:35         ` Michael S. Tsirkin
2017-11-08 19:39           ` Christian Borntraeger
2017-11-08 19:58             ` Michael S. Tsirkin
2017-11-09  8:29               ` Christian Borntraeger
2017-11-09  8:57                 ` Cornelia Huck
2017-11-09 19:48                 ` Michael S. Tsirkin
2017-11-08 19:41       ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171108191531.2d2f7210.cohuck@redhat.com \
    --to=cohuck@redhat.com \
    --cc=borntraeger@de.ibm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heiko.carstens@de.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=schwidefsky@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).