From: Christian Borntraeger <borntraeger@de.ibm.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Cornelia Huck <cohuck@redhat.com>,
linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
linux-s390@vger.kernel.org
Subject: Re: [PATCH v2] s390/virtio: mark headers as BSD licensed
Date: Thu, 9 Nov 2017 09:29:32 +0100 [thread overview]
Message-ID: <778f7cff-5a67-ce97-3c79-7ae71bb0c696@de.ibm.com> (raw)
In-Reply-To: <20171108215816-mutt-send-email-mst@kernel.org>
On 11/08/2017 08:58 PM, Michael S. Tsirkin wrote:
> On Wed, Nov 08, 2017 at 08:39:11PM +0100, Christian Borntraeger wrote:
>>
>>
>> On 11/08/2017 08:35 PM, Michael S. Tsirkin wrote:
>>> On Wed, Nov 08, 2017 at 07:57:28PM +0100, Christian Borntraeger wrote:
>>>> So what about the following
>>>>
>>>> - leave kvm_virtio.h unchanged and we will delete this file via the s390 tree
>>>
>>> Seems to be used by kvm_virtio.c - are you removing that too?
>>
>> Yes, so sorry my first url for the git.kernel.org was in the wrong subfolder:
>> https://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git/commit?h=features&id=7fb2b2d512448cf0e914c4647a1cf02b52263702
>>
>>
>>>
>>>> - change virtio_ccw.h to BSD license. The content of this file is really really trivial
>>>> and it boils down to 2 defines, that can be easily reconstructed by looking at the virtio spec.
>>>> Not even sure if something like this can be copyrighted.
>>>
>>> Yes. What prompted this was Greg's patch.
>>>
>>>>
>>>> For reference the content of this file minus comments is
>>>>
>>>> - snip -
>>>> #define KVM_VIRTIO_CCW_RING_ALIGN 4096
>>>> #define KVM_S390_VIRTIO_CCW_NOTIFY 3
>>>> - snip -
>>>>
>>>>
>>
>> [..]
>
>
> So for ccw if both you and Cornelia ACK, we'll be fine I think.
> No one else touched this code.
A patch that changes virtio_ccw.h to a dual gpl2/bsd licence is
Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
as it matches the original intent of the virtio header relicensing
from 2008 while at the same time covers the fact that the whole
kernel is GPL2.
next prev parent reply other threads:[~2017-11-09 8:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-08 16:59 [PATCH v2] s390/virtio: mark headers as BSD licensed Michael S. Tsirkin
2017-11-08 17:01 ` Michael S. Tsirkin
2017-11-08 17:28 ` Cornelia Huck
2017-11-08 17:02 ` Cornelia Huck
2017-11-08 18:10 ` Heiko Carstens
2017-11-08 18:12 ` Christian Borntraeger
2017-11-08 18:15 ` Cornelia Huck
2017-11-08 18:33 ` Christian Borntraeger
2017-11-08 18:57 ` Christian Borntraeger
2017-11-08 18:59 ` Christian Borntraeger
2017-11-08 19:35 ` Michael S. Tsirkin
2017-11-08 19:39 ` Christian Borntraeger
2017-11-08 19:58 ` Michael S. Tsirkin
2017-11-09 8:29 ` Christian Borntraeger [this message]
2017-11-09 8:57 ` Cornelia Huck
2017-11-09 19:48 ` Michael S. Tsirkin
2017-11-08 19:41 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=778f7cff-5a67-ce97-3c79-7ae71bb0c696@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mst@redhat.com \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).