* [PATCH] net: sfc: remove redundant variable start
@ 2017-11-09 8:01 Colin King
2017-11-09 8:39 ` Bert Kenward
2017-11-11 10:14 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2017-11-09 8:01 UTC (permalink / raw)
To: Solarflare linux maintainers, Edward Cree, Bert Kenward, netdev
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Variable start is assigned but never read hence it is redundant
and can be removed. Cleans up clang warning:
drivers/net/ethernet/sfc/ptp.c:655:2: warning: Value stored to 'start'
is never read
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/ethernet/sfc/ptp.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/sfc/ptp.c b/drivers/net/ethernet/sfc/ptp.c
index 56c2db398def..caa89bf7603e 100644
--- a/drivers/net/ethernet/sfc/ptp.c
+++ b/drivers/net/ethernet/sfc/ptp.c
@@ -648,11 +648,9 @@ static void efx_ptp_send_times(struct efx_nic *efx,
struct pps_event_time now;
struct timespec64 limit;
struct efx_ptp_data *ptp = efx->ptp_data;
- struct timespec64 start;
int *mc_running = ptp->start.addr;
pps_get_ts(&now);
- start = now.ts_real;
limit = now.ts_real;
timespec64_add_ns(&limit, SYNCHRONISE_PERIOD_NS);
--
2.14.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: sfc: remove redundant variable start
2017-11-09 8:01 [PATCH] net: sfc: remove redundant variable start Colin King
@ 2017-11-09 8:39 ` Bert Kenward
2017-11-11 10:14 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Bert Kenward @ 2017-11-09 8:39 UTC (permalink / raw)
To: Colin King, Solarflare linux maintainers, Edward Cree, netdev
Cc: kernel-janitors, linux-kernel
On 09/11/17 08:01, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable start is assigned but never read hence it is redundant
> and can be removed. Cleans up clang warning:
>
> drivers/net/ethernet/sfc/ptp.c:655:2: warning: Value stored to 'start'
> is never read
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Bert Kenward <bkenward@solarflare.com>
Thanks Colin.
> ---
> drivers/net/ethernet/sfc/ptp.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/sfc/ptp.c b/drivers/net/ethernet/sfc/ptp.c
> index 56c2db398def..caa89bf7603e 100644
> --- a/drivers/net/ethernet/sfc/ptp.c
> +++ b/drivers/net/ethernet/sfc/ptp.c
> @@ -648,11 +648,9 @@ static void efx_ptp_send_times(struct efx_nic *efx,
> struct pps_event_time now;
> struct timespec64 limit;
> struct efx_ptp_data *ptp = efx->ptp_data;
> - struct timespec64 start;
> int *mc_running = ptp->start.addr;
>
> pps_get_ts(&now);
> - start = now.ts_real;
> limit = now.ts_real;
> timespec64_add_ns(&limit, SYNCHRONISE_PERIOD_NS);
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: sfc: remove redundant variable start
2017-11-09 8:01 [PATCH] net: sfc: remove redundant variable start Colin King
2017-11-09 8:39 ` Bert Kenward
@ 2017-11-11 10:14 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-11-11 10:14 UTC (permalink / raw)
To: colin.king
Cc: linux-net-drivers, ecree, bkenward, netdev, kernel-janitors,
linux-kernel
From: Colin King <colin.king@canonical.com>
Date: Thu, 9 Nov 2017 08:01:22 +0000
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable start is assigned but never read hence it is redundant
> and can be removed. Cleans up clang warning:
>
> drivers/net/ethernet/sfc/ptp.c:655:2: warning: Value stored to 'start'
> is never read
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-11 10:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-09 8:01 [PATCH] net: sfc: remove redundant variable start Colin King
2017-11-09 8:39 ` Bert Kenward
2017-11-11 10:14 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).