From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Damien Riegel <damien.riegel@savoirfairelinux.com>
Cc: linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
kernel@savoirfairelinux.com
Subject: Re: [PATCH 1/4] arm64: dts: qcom: pm8916: fix wcd_codec indentation
Date: Thu, 9 Nov 2017 08:49:41 -0800 [thread overview]
Message-ID: <20171109164941.GZ28761@minitux> (raw)
In-Reply-To: <20171101175335.22123-2-damien.riegel@savoirfairelinux.com>
On Wed 01 Nov 10:53 PDT 2017, Damien Riegel wrote:
> Indentation did not respect kernel standards, so fix that for the usual
> indent with tabs, align with spaces. While at it, remove some empty
> lines before and after the closing parenthesis of this block.
>
> Signed-off-by: Damien Riegel <damien.riegel@savoirfairelinux.com>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> ---
> arch/arm64/boot/dts/qcom/pm8916.dtsi | 82 ++++++++++++++++++------------------
> 1 file changed, 40 insertions(+), 42 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/pm8916.dtsi b/arch/arm64/boot/dts/qcom/pm8916.dtsi
> index 53deebf9f515..d19f4cb9a5f3 100644
> --- a/arch/arm64/boot/dts/qcom/pm8916.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pm8916.dtsi
> @@ -96,47 +96,45 @@
> #address-cells = <1>;
> #size-cells = <0>;
>
> - wcd_codec: codec@f000 {
> - compatible = "qcom,pm8916-wcd-analog-codec";
> - reg = <0xf000 0x200>;
> - reg-names = "pmic-codec-core";
> - clocks = <&gcc GCC_CODEC_DIGCODEC_CLK>;
> - clock-names = "mclk";
> - interrupt-parent = <&spmi_bus>;
> - interrupts = <0x1 0xf0 0x0 IRQ_TYPE_NONE>,
> - <0x1 0xf0 0x1 IRQ_TYPE_NONE>,
> - <0x1 0xf0 0x2 IRQ_TYPE_NONE>,
> - <0x1 0xf0 0x3 IRQ_TYPE_NONE>,
> - <0x1 0xf0 0x4 IRQ_TYPE_NONE>,
> - <0x1 0xf0 0x5 IRQ_TYPE_NONE>,
> - <0x1 0xf0 0x6 IRQ_TYPE_NONE>,
> - <0x1 0xf0 0x7 IRQ_TYPE_NONE>,
> - <0x1 0xf1 0x0 IRQ_TYPE_NONE>,
> - <0x1 0xf1 0x1 IRQ_TYPE_NONE>,
> - <0x1 0xf1 0x2 IRQ_TYPE_NONE>,
> - <0x1 0xf1 0x3 IRQ_TYPE_NONE>,
> - <0x1 0xf1 0x4 IRQ_TYPE_NONE>,
> - <0x1 0xf1 0x5 IRQ_TYPE_NONE>;
> - interrupt-names = "cdc_spk_cnp_int",
> - "cdc_spk_clip_int",
> - "cdc_spk_ocp_int",
> - "mbhc_ins_rem_det1",
> - "mbhc_but_rel_det",
> - "mbhc_but_press_det",
> - "mbhc_ins_rem_det",
> - "mbhc_switch_int",
> - "cdc_ear_ocp_int",
> - "cdc_hphr_ocp_int",
> - "cdc_hphl_ocp_det",
> - "cdc_ear_cnp_int",
> - "cdc_hphr_cnp_int",
> - "cdc_hphl_cnp_int";
> - vdd-cdc-io-supply = <&pm8916_l5>;
> - vdd-cdc-tx-rx-cx-supply = <&pm8916_l5>;
> - vdd-micbias-supply = <&pm8916_l13>;
> - #sound-dai-cells = <1>;
> -
> - };
> -
> + wcd_codec: codec@f000 {
> + compatible = "qcom,pm8916-wcd-analog-codec";
> + reg = <0xf000 0x200>;
> + reg-names = "pmic-codec-core";
> + clocks = <&gcc GCC_CODEC_DIGCODEC_CLK>;
> + clock-names = "mclk";
> + interrupt-parent = <&spmi_bus>;
> + interrupts = <0x1 0xf0 0x0 IRQ_TYPE_NONE>,
> + <0x1 0xf0 0x1 IRQ_TYPE_NONE>,
> + <0x1 0xf0 0x2 IRQ_TYPE_NONE>,
> + <0x1 0xf0 0x3 IRQ_TYPE_NONE>,
> + <0x1 0xf0 0x4 IRQ_TYPE_NONE>,
> + <0x1 0xf0 0x5 IRQ_TYPE_NONE>,
> + <0x1 0xf0 0x6 IRQ_TYPE_NONE>,
> + <0x1 0xf0 0x7 IRQ_TYPE_NONE>,
> + <0x1 0xf1 0x0 IRQ_TYPE_NONE>,
> + <0x1 0xf1 0x1 IRQ_TYPE_NONE>,
> + <0x1 0xf1 0x2 IRQ_TYPE_NONE>,
> + <0x1 0xf1 0x3 IRQ_TYPE_NONE>,
> + <0x1 0xf1 0x4 IRQ_TYPE_NONE>,
> + <0x1 0xf1 0x5 IRQ_TYPE_NONE>;
> + interrupt-names = "cdc_spk_cnp_int",
> + "cdc_spk_clip_int",
> + "cdc_spk_ocp_int",
> + "mbhc_ins_rem_det1",
> + "mbhc_but_rel_det",
> + "mbhc_but_press_det",
> + "mbhc_ins_rem_det",
> + "mbhc_switch_int",
> + "cdc_ear_ocp_int",
> + "cdc_hphr_ocp_int",
> + "cdc_hphl_ocp_det",
> + "cdc_ear_cnp_int",
> + "cdc_hphr_cnp_int",
> + "cdc_hphl_cnp_int";
> + vdd-cdc-io-supply = <&pm8916_l5>;
> + vdd-cdc-tx-rx-cx-supply = <&pm8916_l5>;
> + vdd-micbias-supply = <&pm8916_l13>;
> + #sound-dai-cells = <1>;
> + };
> };
> };
> --
> 2.15.0
>
next prev parent reply other threads:[~2017-11-09 16:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-01 17:53 [PATCH 0/4] arm64: dts: qcom: dts improvements Damien Riegel
2017-11-01 17:53 ` [PATCH 1/4] arm64: dts: qcom: pm8916: fix wcd_codec indentation Damien Riegel
2017-11-09 16:49 ` Bjorn Andersson [this message]
2017-11-01 17:53 ` [PATCH 2/4] arm64: dts: qcom: msm8916-pins: remove assignments to bias-disable Damien Riegel
2017-11-09 16:50 ` Bjorn Andersson
2017-11-01 17:53 ` [PATCH 3/4] arm64: dts: qcom: msm8916: normalize I2C bindings Damien Riegel
2017-11-09 16:56 ` Bjorn Andersson
2017-11-01 17:53 ` [PATCH 4/4] arm64: dts: qcom: msm8916: add bindings for i2c1, i2c3, i2c5 Damien Riegel
2017-11-09 17:00 ` Bjorn Andersson
2017-11-09 17:14 ` Damien Riegel
2017-11-11 7:56 ` Bjorn Andersson
2017-11-14 23:13 ` Damien Riegel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171109164941.GZ28761@minitux \
--to=bjorn.andersson@linaro.org \
--cc=andy.gross@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=damien.riegel@savoirfairelinux.com \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@savoirfairelinux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).