* [PATCH net] net: dsa: return after vlan prepare phase
@ 2017-11-08 15:50 Vivien Didelot
2017-11-08 15:53 ` Andrew Lunn
2017-11-11 6:45 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Vivien Didelot @ 2017-11-08 15:50 UTC (permalink / raw)
To: netdev
Cc: linux-kernel, kernel, David S. Miller, Florian Fainelli,
Andrew Lunn, Egil Hjelmeland, Vivien Didelot
The current code does not return after successfully preparing the VLAN
addition on every ports member of a it. Fix this.
Fixes: 1ca4aa9cd4cc ("net: dsa: check VLAN capability of every switch")
Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
---
net/dsa/switch.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/dsa/switch.c b/net/dsa/switch.c
index 73746fa148f1..1e2929f4290a 100644
--- a/net/dsa/switch.c
+++ b/net/dsa/switch.c
@@ -182,6 +182,8 @@ static int dsa_switch_vlan_add(struct dsa_switch *ds,
if (err)
return err;
}
+
+ return 0;
}
for_each_set_bit(port, members, ds->num_ports)
--
2.15.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] net: dsa: return after vlan prepare phase
2017-11-08 15:50 [PATCH net] net: dsa: return after vlan prepare phase Vivien Didelot
@ 2017-11-08 15:53 ` Andrew Lunn
2017-11-11 6:45 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2017-11-08 15:53 UTC (permalink / raw)
To: Vivien Didelot
Cc: netdev, linux-kernel, kernel, David S. Miller, Florian Fainelli,
Egil Hjelmeland
On Wed, Nov 08, 2017 at 10:50:10AM -0500, Vivien Didelot wrote:
> The current code does not return after successfully preparing the VLAN
> addition on every ports member of a it. Fix this.
>
> Fixes: 1ca4aa9cd4cc ("net: dsa: check VLAN capability of every switch")
> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] net: dsa: return after vlan prepare phase
2017-11-08 15:50 [PATCH net] net: dsa: return after vlan prepare phase Vivien Didelot
2017-11-08 15:53 ` Andrew Lunn
@ 2017-11-11 6:45 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-11-11 6:45 UTC (permalink / raw)
To: vivien.didelot; +Cc: netdev, linux-kernel, kernel, f.fainelli, andrew, privat
From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Date: Wed, 8 Nov 2017 10:50:10 -0500
> The current code does not return after successfully preparing the VLAN
> addition on every ports member of a it. Fix this.
>
> Fixes: 1ca4aa9cd4cc ("net: dsa: check VLAN capability of every switch")
> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-11 6:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-08 15:50 [PATCH net] net: dsa: return after vlan prepare phase Vivien Didelot
2017-11-08 15:53 ` Andrew Lunn
2017-11-11 6:45 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).