* [PATCH] omap3-n900: enable autofocus
@ 2017-11-12 11:25 Pavel Machek
2017-11-12 12:07 ` Pali Rohár
2017-11-12 14:29 ` Sebastian Reichel
0 siblings, 2 replies; 4+ messages in thread
From: Pavel Machek @ 2017-11-12 11:25 UTC (permalink / raw)
To: pali.rohar, sre, kernel list, linux-arm-kernel, linux-omap, tony,
khilman, aaro.koskinen, ivo.g.dimitrov.75, patrikbachan, serge,
abcloriens, clayton, martijn, sakari.ailus
[-- Attachment #1: Type: text/plain, Size: 663 bytes --]
Connect auto-focus coil to the camera sensor, so that it can be used
by camera applications.
Signed-off-by: Pavel Machek <pavel@ucw.cz>
diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts
index 669c51c..59cc743 100644
--- a/arch/arm/boot/dts/omap3-n900.dts
+++ b/arch/arm/boot/dts/omap3-n900.dts
@@ -778,6 +778,8 @@
reset-gpio = <&gpio4 6 GPIO_ACTIVE_HIGH>; /* 102 */
+ lens-focus = <&ad5820>;
+
port {
csi_cam1: endpoint {
bus-type = <3>; /* CCP2 */
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] omap3-n900: enable autofocus
2017-11-12 11:25 [PATCH] omap3-n900: enable autofocus Pavel Machek
@ 2017-11-12 12:07 ` Pali Rohár
2017-11-12 14:29 ` Sebastian Reichel
1 sibling, 0 replies; 4+ messages in thread
From: Pali Rohár @ 2017-11-12 12:07 UTC (permalink / raw)
To: Pavel Machek
Cc: sre, kernel list, linux-arm-kernel, linux-omap, tony, khilman,
aaro.koskinen, ivo.g.dimitrov.75, patrikbachan, serge,
abcloriens, clayton, martijn, sakari.ailus
On Sunday 12 November 2017 12:25:29 Pavel Machek wrote:
>
> Connect auto-focus coil to the camera sensor, so that it can be used
> by camera applications.
>
> Signed-off-by: Pavel Machek <pavel@ucw.cz>
Acked-by: Pali Rohár <pali.rohar@gmail.com>
> diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts
> index 669c51c..59cc743 100644
> --- a/arch/arm/boot/dts/omap3-n900.dts
> +++ b/arch/arm/boot/dts/omap3-n900.dts
> @@ -778,6 +778,8 @@
>
> reset-gpio = <&gpio4 6 GPIO_ACTIVE_HIGH>; /* 102 */
>
> + lens-focus = <&ad5820>;
> +
> port {
> csi_cam1: endpoint {
> bus-type = <3>; /* CCP2 */
>
--
Pali Rohár
pali.rohar@gmail.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] omap3-n900: enable autofocus
2017-11-12 11:25 [PATCH] omap3-n900: enable autofocus Pavel Machek
2017-11-12 12:07 ` Pali Rohár
@ 2017-11-12 14:29 ` Sebastian Reichel
2017-11-13 10:29 ` Pavel Machek
1 sibling, 1 reply; 4+ messages in thread
From: Sebastian Reichel @ 2017-11-12 14:29 UTC (permalink / raw)
To: Pavel Machek
Cc: pali.rohar, kernel list, linux-arm-kernel, linux-omap, tony,
khilman, aaro.koskinen, ivo.g.dimitrov.75, patrikbachan, serge,
abcloriens, clayton, martijn, sakari.ailus
[-- Attachment #1: Type: text/plain, Size: 960 bytes --]
Hi,
On Sun, Nov 12, 2017 at 12:25:29PM +0100, Pavel Machek wrote:
>
> Connect auto-focus coil to the camera sensor, so that it can be used
> by camera applications.
>
> Signed-off-by: Pavel Machek <pavel@ucw.cz>
I think you should replace auto-focus with lens-focus. This is not
automatic. Otherwise:
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
-- Sebastian
> diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts
> index 669c51c..59cc743 100644
> --- a/arch/arm/boot/dts/omap3-n900.dts
> +++ b/arch/arm/boot/dts/omap3-n900.dts
> @@ -778,6 +778,8 @@
>
> reset-gpio = <&gpio4 6 GPIO_ACTIVE_HIGH>; /* 102 */
>
> + lens-focus = <&ad5820>;
> +
> port {
> csi_cam1: endpoint {
> bus-type = <3>; /* CCP2 */
>
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] omap3-n900: enable autofocus
2017-11-12 14:29 ` Sebastian Reichel
@ 2017-11-13 10:29 ` Pavel Machek
0 siblings, 0 replies; 4+ messages in thread
From: Pavel Machek @ 2017-11-13 10:29 UTC (permalink / raw)
To: Sebastian Reichel
Cc: pali.rohar, kernel list, linux-arm-kernel, linux-omap, tony,
khilman, aaro.koskinen, ivo.g.dimitrov.75, patrikbachan, serge,
abcloriens, clayton, martijn, sakari.ailus
[-- Attachment #1: Type: text/plain, Size: 690 bytes --]
On Sun 2017-11-12 15:29:18, Sebastian Reichel wrote:
> Hi,
>
> On Sun, Nov 12, 2017 at 12:25:29PM +0100, Pavel Machek wrote:
> >
> > Connect auto-focus coil to the camera sensor, so that it can be used
> > by camera applications.
> >
> > Signed-off-by: Pavel Machek <pavel@ucw.cz>
>
> I think you should replace auto-focus with lens-focus. This is not
> automatic. Otherwise:
You are right... althrough the lens is really meant for auto-focus.
Anyway, I can send the updated patch if neccessary.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-11-13 10:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-12 11:25 [PATCH] omap3-n900: enable autofocus Pavel Machek
2017-11-12 12:07 ` Pali Rohár
2017-11-12 14:29 ` Sebastian Reichel
2017-11-13 10:29 ` Pavel Machek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).