* [PATCH] irqdomain: drop pointless NULL check in virq_debug_show_one
@ 2017-11-12 21:29 Rasmus Villemoes
2017-11-12 22:31 ` [tip:irq/core] irqdomain: Drop " tip-bot for Rasmus Villemoes
0 siblings, 1 reply; 2+ messages in thread
From: Rasmus Villemoes @ 2017-11-12 21:29 UTC (permalink / raw)
To: Marc Zyngier, Thomas Gleixner; +Cc: Rasmus Villemoes, linux-kernel
We've already done data->irq and data->hwirq, and also unconditionally
dereference data in the irq_data_get_irq_chip_data() call.
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
---
kernel/irq/irqdomain.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
index ac4644e92b49..8aba7b4a2a91 100644
--- a/kernel/irq/irqdomain.c
+++ b/kernel/irq/irqdomain.c
@@ -921,8 +921,7 @@ static void virq_debug_show_one(struct seq_file *m, struct irq_desc *desc)
chip = irq_data_get_irq_chip(data);
seq_printf(m, "%-15s ", (chip && chip->name) ? chip->name : "none");
- seq_printf(m, data ? "0x%p " : " %p ",
- irq_data_get_irq_chip_data(data));
+ seq_printf(m, "0x%p ", irq_data_get_irq_chip_data(data));
seq_printf(m, " %c ", (desc->action && desc->action->handler) ? '*' : ' ');
direct = (irq == hwirq) && (irq < domain->revmap_direct_max_irq);
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [tip:irq/core] irqdomain: Drop pointless NULL check in virq_debug_show_one
2017-11-12 21:29 [PATCH] irqdomain: drop pointless NULL check in virq_debug_show_one Rasmus Villemoes
@ 2017-11-12 22:31 ` tip-bot for Rasmus Villemoes
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Rasmus Villemoes @ 2017-11-12 22:31 UTC (permalink / raw)
To: linux-tip-commits; +Cc: hpa, linux-kernel, mingo, marc.zyngier, tglx, linux
Commit-ID: 306eb5a38dfc1a4c8a5c910c9844da6a97f2b9a4
Gitweb: https://git.kernel.org/tip/306eb5a38dfc1a4c8a5c910c9844da6a97f2b9a4
Author: Rasmus Villemoes <linux@rasmusvillemoes.dk>
AuthorDate: Sun, 12 Nov 2017 22:29:03 +0100
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Sun, 12 Nov 2017 23:25:40 +0100
irqdomain: Drop pointless NULL check in virq_debug_show_one
data has been already derefenced unconditionally, so it's pointless to do a
NULL pointer check on it afterwards. Drop it.
[ tglx: Depersonify changelog. ]
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Marc Zyngier <marc.zyngier@arm.com>
Link: https://lkml.kernel.org/r/20171112212904.28574-1-linux@rasmusvillemoes.dk
---
kernel/irq/irqdomain.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
index fbbf342..4f4f600 100644
--- a/kernel/irq/irqdomain.c
+++ b/kernel/irq/irqdomain.c
@@ -921,8 +921,7 @@ static void virq_debug_show_one(struct seq_file *m, struct irq_desc *desc)
chip = irq_data_get_irq_chip(data);
seq_printf(m, "%-15s ", (chip && chip->name) ? chip->name : "none");
- seq_printf(m, data ? "0x%p " : " %p ",
- irq_data_get_irq_chip_data(data));
+ seq_printf(m, "0x%p ", irq_data_get_irq_chip_data(data));
seq_printf(m, " %c ", (desc->action && desc->action->handler) ? '*' : ' ');
direct = (irq == hwirq) && (irq < domain->revmap_direct_max_irq);
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-12 22:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-12 21:29 [PATCH] irqdomain: drop pointless NULL check in virq_debug_show_one Rasmus Villemoes
2017-11-12 22:31 ` [tip:irq/core] irqdomain: Drop " tip-bot for Rasmus Villemoes
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).