* [PATCH net-next] net: dsa: lan9303: Fix lan9303_alr_del_port()
@ 2017-11-08 10:44 Egil Hjelmeland
2017-11-08 14:08 ` Vivien Didelot
2017-11-13 1:01 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Egil Hjelmeland @ 2017-11-08 10:44 UTC (permalink / raw)
To: andrew, vivien.didelot, f.fainelli, netdev, linux-kernel; +Cc: Egil Hjelmeland
Fix embarrassing bug in lan9303_alr_del_port(): Instead of zeroing
entr->mac_addr, I destroyed the next cache entry. Affected .port_fdb_del and
.port_mdb_del.
Fixes: 0620427ea0d6 ("net: dsa: lan9303: Add fdb/mdb manipulation")
Signed-off-by: Egil Hjelmeland <privat@egil-hjelmeland.no>
---
drivers/net/dsa/lan9303-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dsa/lan9303-core.c b/drivers/net/dsa/lan9303-core.c
index 320651a57c6f..c0910aebc037 100644
--- a/drivers/net/dsa/lan9303-core.c
+++ b/drivers/net/dsa/lan9303-core.c
@@ -702,7 +702,7 @@ static int lan9303_alr_del_port(struct lan9303 *chip, const u8 *mac, int port)
entr->port_map &= ~BIT(port);
if (entr->port_map == 0) /* zero means its free again */
- eth_zero_addr(&entr->port_map);
+ eth_zero_addr(entr->mac_addr);
lan9303_alr_set_entry(chip, mac, entr->port_map, entr->stp_override);
return 0;
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: dsa: lan9303: Fix lan9303_alr_del_port()
2017-11-08 10:44 [PATCH net-next] net: dsa: lan9303: Fix lan9303_alr_del_port() Egil Hjelmeland
@ 2017-11-08 14:08 ` Vivien Didelot
2017-11-13 1:01 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Vivien Didelot @ 2017-11-08 14:08 UTC (permalink / raw)
To: Egil Hjelmeland, andrew, f.fainelli, netdev, linux-kernel; +Cc: Egil Hjelmeland
Egil Hjelmeland <privat@egil-hjelmeland.no> writes:
> Fix embarrassing bug in lan9303_alr_del_port(): Instead of zeroing
> entr->mac_addr, I destroyed the next cache entry. Affected .port_fdb_del and
> .port_mdb_del.
>
> Fixes: 0620427ea0d6 ("net: dsa: lan9303: Add fdb/mdb manipulation")
> Signed-off-by: Egil Hjelmeland <privat@egil-hjelmeland.no>
Reviewed-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: dsa: lan9303: Fix lan9303_alr_del_port()
2017-11-08 10:44 [PATCH net-next] net: dsa: lan9303: Fix lan9303_alr_del_port() Egil Hjelmeland
2017-11-08 14:08 ` Vivien Didelot
@ 2017-11-13 1:01 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-11-13 1:01 UTC (permalink / raw)
To: privat; +Cc: andrew, vivien.didelot, f.fainelli, netdev, linux-kernel
From: Egil Hjelmeland <privat@egil-hjelmeland.no>
Date: Wed, 8 Nov 2017 11:44:36 +0100
> Fix embarrassing bug in lan9303_alr_del_port(): Instead of zeroing
> entr->mac_addr, I destroyed the next cache entry. Affected .port_fdb_del and
> .port_mdb_del.
>
> Fixes: 0620427ea0d6 ("net: dsa: lan9303: Add fdb/mdb manipulation")
> Signed-off-by: Egil Hjelmeland <privat@egil-hjelmeland.no>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-13 1:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-08 10:44 [PATCH net-next] net: dsa: lan9303: Fix lan9303_alr_del_port() Egil Hjelmeland
2017-11-08 14:08 ` Vivien Didelot
2017-11-13 1:01 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).