From: Johan Hovold <johan@kernel.org>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: Johan Hovold <johan@kernel.org>, Tony Lindgren <tony@atomide.com>,
Lee Jones <lee.jones@linaro.org>,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
stable <stable@vger.kernel.org>
Subject: Re: [PATCH 1/2] mfd: twl4030-audio: fix sibling-node lookup
Date: Tue, 14 Nov 2017 19:07:43 +0100 [thread overview]
Message-ID: <20171114180743.GB11226@localhost> (raw)
In-Reply-To: <189caf41-7298-ab1e-6a67-f6ff86fea47f@ti.com>
On Mon, Nov 13, 2017 at 10:13:42PM +0200, Peter Ujfalusi wrote:
> On 11/11/2017 05:38 PM, Johan Hovold wrote:
> > A helper purported to look up a child node based on its name was using
> > the wrong of-helper and ended up prematurely freeing the parent of-node
> > while leaking any matching node.
> >
> > To make things worse, any matching node would not even necessarily be a
> > child node as the whole device tree was searched depth-first starting at
> > the parent.
>
> I think it is the same case as with the twl6040, there were no
> of_get_child_by_name() when this was done...
>
> Thanks for fixing it!
>
> Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Thanks for the acks.
Johan
next prev parent reply other threads:[~2017-11-14 18:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-11 15:38 [PATCH 1/2] mfd: twl4030-audio: fix sibling-node lookup Johan Hovold
2017-11-11 15:38 ` [PATCH 2/2] mfd: twl6040: fix child-node lookup Johan Hovold
2017-11-13 9:12 ` Lee Jones
2017-11-13 20:14 ` Peter Ujfalusi
2017-11-29 11:25 ` Lee Jones
2017-11-13 9:12 ` [PATCH 1/2] mfd: twl4030-audio: fix sibling-node lookup Lee Jones
2017-11-13 20:13 ` Peter Ujfalusi
2017-11-14 18:07 ` Johan Hovold [this message]
2017-11-29 11:24 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171114180743.GB11226@localhost \
--to=johan@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=stable@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).