* [PATCH] arm: Remove unused __readwrite_bug function
@ 2017-11-15 19:33 Corentin Labbe
2017-11-16 7:24 ` Uwe Kleine-König
0 siblings, 1 reply; 2+ messages in thread
From: Corentin Labbe @ 2017-11-15 19:33 UTC (permalink / raw)
To: linux; +Cc: linux-arm-kernel, linux-kernel, Corentin Labbe
The function __readwrite_bug() is not used at all, so this patch remove
it.
Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
---
arch/arm/include/asm/io.h | 5 -----
arch/arm/kernel/traps.c | 7 -------
2 files changed, 12 deletions(-)
diff --git a/arch/arm/include/asm/io.h b/arch/arm/include/asm/io.h
index 2cfbc531f63b..6a9d9d2d4c0a 100644
--- a/arch/arm/include/asm/io.h
+++ b/arch/arm/include/asm/io.h
@@ -150,11 +150,6 @@ extern void __iomem * (*arch_ioremap_caller)(phys_addr_t, size_t,
extern void (*arch_iounmap)(volatile void __iomem *);
/*
- * Bad read/write accesses...
- */
-extern void __readwrite_bug(const char *fn);
-
-/*
* A typesafe __io() helper
*/
static inline void __iomem *__typesafe_io(unsigned long addr)
diff --git a/arch/arm/kernel/traps.c b/arch/arm/kernel/traps.c
index 5cf04888c581..cce8b18d673f 100644
--- a/arch/arm/kernel/traps.c
+++ b/arch/arm/kernel/traps.c
@@ -757,13 +757,6 @@ baddataabort(int code, unsigned long instr, struct pt_regs *regs)
arm_notify_die("unknown data abort code", regs, &info, instr, 0);
}
-void __readwrite_bug(const char *fn)
-{
- pr_err("%s called, but not implemented\n", fn);
- BUG();
-}
-EXPORT_SYMBOL(__readwrite_bug);
-
void __pte_error(const char *file, int line, pte_t pte)
{
pr_err("%s:%d: bad pte %08llx.\n", file, line, (long long)pte_val(pte));
--
2.13.6
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arm: Remove unused __readwrite_bug function
2017-11-15 19:33 [PATCH] arm: Remove unused __readwrite_bug function Corentin Labbe
@ 2017-11-16 7:24 ` Uwe Kleine-König
0 siblings, 0 replies; 2+ messages in thread
From: Uwe Kleine-König @ 2017-11-16 7:24 UTC (permalink / raw)
To: Corentin Labbe; +Cc: linux, linux-kernel, linux-arm-kernel, Rob Herring
On Wed, Nov 15, 2017 at 07:33:22PM +0000, Corentin Labbe wrote:
> The function __readwrite_bug() is not used at all, so this patch remove
> it.
This function seems unused since
5621caac1d95 ("ARM: kill off __mem_pci"). Adding Rob as author to Cc.
Best regards
Uwe
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> ---
> arch/arm/include/asm/io.h | 5 -----
> arch/arm/kernel/traps.c | 7 -------
> 2 files changed, 12 deletions(-)
>
> diff --git a/arch/arm/include/asm/io.h b/arch/arm/include/asm/io.h
> index 2cfbc531f63b..6a9d9d2d4c0a 100644
> --- a/arch/arm/include/asm/io.h
> +++ b/arch/arm/include/asm/io.h
> @@ -150,11 +150,6 @@ extern void __iomem * (*arch_ioremap_caller)(phys_addr_t, size_t,
> extern void (*arch_iounmap)(volatile void __iomem *);
>
> /*
> - * Bad read/write accesses...
> - */
> -extern void __readwrite_bug(const char *fn);
> -
> -/*
> * A typesafe __io() helper
> */
> static inline void __iomem *__typesafe_io(unsigned long addr)
> diff --git a/arch/arm/kernel/traps.c b/arch/arm/kernel/traps.c
> index 5cf04888c581..cce8b18d673f 100644
> --- a/arch/arm/kernel/traps.c
> +++ b/arch/arm/kernel/traps.c
> @@ -757,13 +757,6 @@ baddataabort(int code, unsigned long instr, struct pt_regs *regs)
> arm_notify_die("unknown data abort code", regs, &info, instr, 0);
> }
>
> -void __readwrite_bug(const char *fn)
> -{
> - pr_err("%s called, but not implemented\n", fn);
> - BUG();
> -}
> -EXPORT_SYMBOL(__readwrite_bug);
> -
> void __pte_error(const char *file, int line, pte_t pte)
> {
> pr_err("%s:%d: bad pte %08llx.\n", file, line, (long long)pte_val(pte));
> --
> 2.13.6
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-16 7:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-15 19:33 [PATCH] arm: Remove unused __readwrite_bug function Corentin Labbe
2017-11-16 7:24 ` Uwe Kleine-König
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).