* [PATCH] irqchip/qcom: fix u32 comparison with value less than zero
@ 2017-11-17 18:35 Colin King
2017-11-23 19:09 ` [tip:irq/urgent] irqchip/qcom: Fix " tip-bot for Colin Ian King
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2017-11-17 18:35 UTC (permalink / raw)
To: Thomas Gleixner, Jason Cooper, Marc Zyngier; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The comparison of u32 nregs being less than zero is never true since
nregs is unsigned. Fix this by making nregs a signed integer.
Fixes: f20cc9b00c7b ("irqchip/qcom: Add IRQ combiner driver")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/irqchip/qcom-irq-combiner.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/irqchip/qcom-irq-combiner.c b/drivers/irqchip/qcom-irq-combiner.c
index 6aa3ea479214..f31265937439 100644
--- a/drivers/irqchip/qcom-irq-combiner.c
+++ b/drivers/irqchip/qcom-irq-combiner.c
@@ -238,7 +238,7 @@ static int __init combiner_probe(struct platform_device *pdev)
{
struct combiner *combiner;
size_t alloc_sz;
- u32 nregs;
+ int nregs;
int err;
nregs = count_registers(pdev);
--
2.14.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [tip:irq/urgent] irqchip/qcom: Fix u32 comparison with value less than zero
2017-11-17 18:35 [PATCH] irqchip/qcom: fix u32 comparison with value less than zero Colin King
@ 2017-11-23 19:09 ` tip-bot for Colin Ian King
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Colin Ian King @ 2017-11-23 19:09 UTC (permalink / raw)
To: linux-tip-commits
Cc: tglx, jason, mingo, colin.king, hpa, marc.zyngier, linux-kernel
Commit-ID: e9990d70e8a063a7b894c5cbb99f630a0f41200d
Gitweb: https://git.kernel.org/tip/e9990d70e8a063a7b894c5cbb99f630a0f41200d
Author: Colin Ian King <colin.king@canonical.com>
AuthorDate: Fri, 17 Nov 2017 18:35:53 +0000
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Thu, 23 Nov 2017 20:03:58 +0100
irqchip/qcom: Fix u32 comparison with value less than zero
The comparison of u32 nregs being less than zero is never true since
nregs is unsigned. Fix this by making nregs a signed integer.
Fixes: f20cc9b00c7b ("irqchip/qcom: Add IRQ combiner driver")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Marc Zyngier <marc.zyngier@arm.com>
Cc: kernel-janitors@vger.kernel.org
Cc: Jason Cooper <jason@lakedaemon.net>
Link: https://lkml.kernel.org/r/20171117183553.2739-1-colin.king@canonical.com
---
drivers/irqchip/qcom-irq-combiner.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/irqchip/qcom-irq-combiner.c b/drivers/irqchip/qcom-irq-combiner.c
index 6aa3ea4..f312659 100644
--- a/drivers/irqchip/qcom-irq-combiner.c
+++ b/drivers/irqchip/qcom-irq-combiner.c
@@ -238,7 +238,7 @@ static int __init combiner_probe(struct platform_device *pdev)
{
struct combiner *combiner;
size_t alloc_sz;
- u32 nregs;
+ int nregs;
int err;
nregs = count_registers(pdev);
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-23 19:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-17 18:35 [PATCH] irqchip/qcom: fix u32 comparison with value less than zero Colin King
2017-11-23 19:09 ` [tip:irq/urgent] irqchip/qcom: Fix " tip-bot for Colin Ian King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).