From: Dan Carpenter <dan.carpenter@oracle.com>
To: Ching Huang <ching2048@areca.com.tw>
Cc: martin.petersen@oracle.com,
James.Bottomley@HansenPartnership.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
jthumshirn@suse.de, hare@suse.de, hch@infradead.org
Subject: Re: [PATCH 2/3] scsi: arcmsr: Add driver module parameter msix_enable
Date: Thu, 23 Nov 2017 14:43:36 +0300 [thread overview]
Message-ID: <20171123114336.bnekgwbrdbx7kvnn@mwanda> (raw)
In-Reply-To: <1511400674.9832.23.camel@Centos6.3-64>
On Thu, Nov 23, 2017 at 09:31:14AM +0800, Ching Huang wrote:
> @@ -829,12 +833,15 @@ arcmsr_request_irq(struct pci_dev *pdev,
> unsigned long flags;
> int nvec, i;
>
> + if (msix_enable == 0)
> + goto msi_int0;
I feel like this goto is not very beautiful, but I can't actually apply
this patch? Which tree is this written against? I'm using linux-next.
regards,
dan carpenter
next prev parent reply other threads:[~2017-11-23 11:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-23 1:31 [PATCH 2/3] scsi: arcmsr: Add driver module parameter msix_enable Ching Huang
2017-11-23 11:43 ` Dan Carpenter [this message]
2017-11-23 19:11 ` Ching Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171123114336.bnekgwbrdbx7kvnn@mwanda \
--to=dan.carpenter@oracle.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=ching2048@areca.com.tw \
--cc=hare@suse.de \
--cc=hch@infradead.org \
--cc=jthumshirn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).