* [PATCH] atm: nicstar: use the setup_timer helper
@ 2017-11-24 8:59 Colin King
2017-11-30 14:23 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2017-11-24 8:59 UTC (permalink / raw)
To: Chas Williams, linux-atm-general, netdev; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Replace init_timer and two explicit assignments with the setup_timer
helper.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/atm/nicstar.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/atm/nicstar.c b/drivers/atm/nicstar.c
index a9702836cbae..335447ed0ba4 100644
--- a/drivers/atm/nicstar.c
+++ b/drivers/atm/nicstar.c
@@ -284,10 +284,8 @@ static int __init nicstar_init(void)
XPRINTK("nicstar: nicstar_init() returned.\n");
if (!error) {
- init_timer(&ns_timer);
+ setup_timer(&ns_timer, ns_poll, 0UL);
ns_timer.expires = jiffies + NS_POLL_PERIOD;
- ns_timer.data = 0UL;
- ns_timer.function = ns_poll;
add_timer(&ns_timer);
}
--
2.14.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] atm: nicstar: use the setup_timer helper
2017-11-24 8:59 [PATCH] atm: nicstar: use the setup_timer helper Colin King
@ 2017-11-30 14:23 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-11-30 14:23 UTC (permalink / raw)
To: colin.king
Cc: 3chas3, linux-atm-general, netdev, kernel-janitors, linux-kernel
From: Colin King <colin.king@canonical.com>
Date: Fri, 24 Nov 2017 08:59:25 +0000
> From: Colin Ian King <colin.king@canonical.com>
>
> Replace init_timer and two explicit assignments with the setup_timer
> helper.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
setup_timer() no longer even exists in the tree.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-30 14:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-24 8:59 [PATCH] atm: nicstar: use the setup_timer helper Colin King
2017-11-30 14:23 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).